Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1723518 > unrolled thread

[PATCH][net-next][V3] bpf: test_maps: fix typos, "conenct" and "listeen"

Back to article view | Back to linux.kernel

Contents

  [PATCH][net-next][V3] bpf: test_maps: fix typos, "conenct" and "listeen" Colin King <colin.king@canonical.com> - 2017-08-30 19:20 +0200
    Re: [PATCH][net-next][V3] bpf: test_maps: fix typos, "conenct" and  "listeen" John Fastabend <john.fastabend@gmail.com> - 2017-08-30 19:40 +0200
    Re: [PATCH][net-next][V3] bpf: test_maps: fix typos, "conenct" and  "listeen" Daniel Borkmann <daniel@iogearbox.net> - 2017-08-30 20:50 +0200
      Re: [PATCH][net-next][V3] bpf: test_maps: fix typos, "conenct" and  "listeen" Shuah Khan <shuah@kernel.org> - 2017-08-30 22:20 +0200
        Re: [PATCH][net-next][V3] bpf: test_maps: fix typos, "conenct" and  "listeen" Daniel Borkmann <daniel@iogearbox.net> - 2017-08-30 22:30 +0200
    Re: [PATCH][net-next][V3] bpf: test_maps: fix typos, "conenct" and  "listeen" David Miller <davem@davemloft.net> - 2017-08-31 00:40 +0200

#1723518 — [PATCH][net-next][V3] bpf: test_maps: fix typos, "conenct" and "listeen"

From: Colin Ian King <colin.king@canonical.com>

Trivial fix to typos in printf error messages:
"conenct" -> "connect"
"listeen" -> "listen"

thanks to Daniel Borkmann for spotting one of these mistakes

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 tools/testing/selftests/bpf/test_maps.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/testing/selftests/bpf/test_maps.c b/tools/testing/selftests/bpf/test_maps.c
index 7059bb315a10..4acc772a28c0 100644
--- a/tools/testing/selftests/bpf/test_maps.c
+++ b/tools/testing/selftests/bpf/test_maps.c
@@ -504,7 +504,7 @@ static void test_sockmap(int tasks, void *data)
 		}
 		err = listen(sfd[i], 32);
 		if (err < 0) {
-			printf("failed to listeen\n");
+			printf("failed to listen\n");
 			goto out;
 		}
 	}
@@ -525,7 +525,7 @@ static void test_sockmap(int tasks, void *data)
 		addr.sin_port = htons(ports[i - 2]);
 		err = connect(sfd[i], (struct sockaddr *)&addr, sizeof(addr));
 		if (err) {
-			printf("failed to conenct\n");
+			printf("failed to connect\n");
 			goto out;
 		}
 	}
-- 
2.14.1

[toc] | [next] | [standalone]

#1723535 — Re: [PATCH][net-next][V3] bpf: test_maps: fix typos, "conenct" and "listeen"

On 08/30/2017 10:15 AM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> Trivial fix to typos in printf error messages:
> "conenct" -> "connect"
> "listeen" -> "listen"
> 
> thanks to Daniel Borkmann for spotting one of these mistakes
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---

Thanks. Even though its a spelling typo best to add fixes tag
I think.

Fixes: 6f6d33f3b3d0 ("bpf: selftests add sockmap tests")
Acked-by: John Fastabend <john.fastabend@gmail.com>

[toc] | [prev] | [next] | [standalone]

#1723591 — Re: [PATCH][net-next][V3] bpf: test_maps: fix typos, "conenct" and "listeen"

On 08/30/2017 07:15 PM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Trivial fix to typos in printf error messages:
> "conenct" -> "connect"
> "listeen" -> "listen"
>
> thanks to Daniel Borkmann for spotting one of these mistakes
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Acked-by: Daniel Borkmann <daniel@iogearbox.net>

[toc] | [prev] | [next] | [standalone]

#1723637 — Re: [PATCH][net-next][V3] bpf: test_maps: fix typos, "conenct" and "listeen"

On 08/30/2017 12:47 PM, Daniel Borkmann wrote:
> On 08/30/2017 07:15 PM, Colin King wrote:
>> From: Colin Ian King <colin.king@canonical.com>
>>
>> Trivial fix to typos in printf error messages:
>> "conenct" -> "connect"
>> "listeen" -> "listen"
>>
>> thanks to Daniel Borkmann for spotting one of these mistakes
>>
>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> 
> Acked-by: Daniel Borkmann <daniel@iogearbox.net>
> 
> 

I can get this into 4.14-rc1 unless it should go through net-next
for dependencies. In which case,

Acked-by: Shuah Khan <shuahkh@osg.samsung.com>

thanks,
-- Shuah

[toc] | [prev] | [next] | [standalone]

#1723649 — Re: [PATCH][net-next][V3] bpf: test_maps: fix typos, "conenct" and "listeen"

On 08/30/2017 10:13 PM, Shuah Khan wrote:
> On 08/30/2017 12:47 PM, Daniel Borkmann wrote:
>> On 08/30/2017 07:15 PM, Colin King wrote:
>>> From: Colin Ian King <colin.king@canonical.com>
>>>
>>> Trivial fix to typos in printf error messages:
>>> "conenct" -> "connect"
>>> "listeen" -> "listen"
>>>
>>> thanks to Daniel Borkmann for spotting one of these mistakes
>>>
>>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
>>
>> Acked-by: Daniel Borkmann <daniel@iogearbox.net>
>
> I can get this into 4.14-rc1 unless it should go through net-next
> for dependencies. In which case,

Yeah, it does depends on work sitting in net-next so easier
to go that route.

Thanks,
Daniel

[toc] | [prev] | [next] | [standalone]

#1723714 — Re: [PATCH][net-next][V3] bpf: test_maps: fix typos, "conenct" and "listeen"

From: Colin King <colin.king@canonical.com>
Date: Wed, 30 Aug 2017 18:15:25 +0100

> From: Colin Ian King <colin.king@canonical.com>
> 
> Trivial fix to typos in printf error messages:
> "conenct" -> "connect"
> "listeen" -> "listen"
> 
> thanks to Daniel Borkmann for spotting one of these mistakes
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Applied.

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web