Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1722697 > unrolled thread
| Started by | Himanshu Jha <himanshujha199640@gmail.com> |
|---|---|
| First post | 2017-08-29 21:00 +0200 |
| Last post | 2017-08-30 19:00 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] rsi: remove memset before memcpy Himanshu Jha <himanshujha199640@gmail.com> - 2017-08-29 21:00 +0200
Re: rsi: remove memset before memcpy Kalle Valo <kvalo@codeaurora.org> - 2017-08-30 19:00 +0200
| From | Himanshu Jha <himanshujha199640@gmail.com> |
|---|---|
| Date | 2017-08-29 21:00 +0200 |
| Subject | [PATCH] rsi: remove memset before memcpy |
| Message-ID | <ujTTX-6ib-1@gated-at.bofh.it> |
calling memcpy immediately after memset with the same region of memory
makes memset redundant.
Signed-off-by: Himanshu Jha <himanshujha199640@gmail.com>
---
drivers/net/wireless/rsi/rsi_91x_sdio.c | 1 -
drivers/net/wireless/rsi/rsi_91x_usb.c | 1 -
2 files changed, 2 deletions(-)
diff --git a/drivers/net/wireless/rsi/rsi_91x_sdio.c b/drivers/net/wireless/rsi/rsi_91x_sdio.c
index 742f6cd..8d3a483 100644
--- a/drivers/net/wireless/rsi/rsi_91x_sdio.c
+++ b/drivers/net/wireless/rsi/rsi_91x_sdio.c
@@ -584,7 +584,6 @@ static int rsi_sdio_load_data_master_write(struct rsi_hw *adapter,
}
for (offset = 0, i = 0; i < num_blocks; i++, offset += block_size) {
- memset(temp_buf, 0, block_size);
memcpy(temp_buf, ta_firmware + offset, block_size);
lsb_address = (u16)base_address;
status = rsi_sdio_write_register_multiple
diff --git a/drivers/net/wireless/rsi/rsi_91x_usb.c b/drivers/net/wireless/rsi/rsi_91x_usb.c
index 9097f7e..81df09d 100644
--- a/drivers/net/wireless/rsi/rsi_91x_usb.c
+++ b/drivers/net/wireless/rsi/rsi_91x_usb.c
@@ -439,7 +439,6 @@ static int rsi_usb_load_data_master_write(struct rsi_hw *adapter,
rsi_dbg(INFO_ZONE, "num_blocks: %d\n", num_blocks);
for (cur_indx = 0, i = 0; i < num_blocks; i++, cur_indx += block_size) {
- memset(temp_buf, 0, block_size);
memcpy(temp_buf, ta_firmware + cur_indx, block_size);
status = rsi_usb_write_register_multiple(adapter, base_address,
(u8 *)(temp_buf),
--
2.7.4
[toc] | [next] | [standalone]
| From | Kalle Valo <kvalo@codeaurora.org> |
|---|---|
| Date | 2017-08-30 19:00 +0200 |
| Subject | Re: rsi: remove memset before memcpy |
| Message-ID | <ukevo-2lz-9@gated-at.bofh.it> |
| In reply to | #1722697 |
Himanshu Jha <himanshujha199640@gmail.com> wrote: > calling memcpy immediately after memset with the same region of memory > makes memset redundant. > > Signed-off-by: Himanshu Jha <himanshujha199640@gmail.com> Patch applied to wireless-drivers-next.git, thanks. 66a3479e1217 rsi: remove memset before memcpy -- https://patchwork.kernel.org/patch/9927943/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web