Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1720832 > unrolled thread

Re: [PATCH 1/3] thunderbolt: Remove superfluous check

Started byMika Westerberg <mika.westerberg@linux.intel.com>
First post2017-08-27 15:40 +0200
Last post2017-08-30 16:30 +0200
Articles 4 — 4 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [PATCH 1/3] thunderbolt: Remove superfluous check Mika Westerberg <mika.westerberg@linux.intel.com> - 2017-08-27 15:40 +0200
    Re: [PATCH 1/3] thunderbolt: Remove superfluous check Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-08-28 16:30 +0200
      Re: [PATCH 1/3] thunderbolt: Remove superfluous check "Bernat, Yehezkel" <yehezkel.bernat@intel.com> - 2017-08-30 16:10 +0200
        Re: [PATCH 1/3] thunderbolt: Remove superfluous check "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org> - 2017-08-30 16:30 +0200

#1720832 — Re: [PATCH 1/3] thunderbolt: Remove superfluous check

FromMika Westerberg <mika.westerberg@linux.intel.com>
Date2017-08-27 15:40 +0200
SubjectRe: [PATCH 1/3] thunderbolt: Remove superfluous check
Message-ID<uj5Xe-8k0-51@gated-at.bofh.it>
On Tue, Aug 15, 2017 at 10:02:28AM +0300, Mika Westerberg wrote:
> On Tue, Aug 15, 2017 at 08:19:01AM +0300, Bernat, Yehezkel wrote:
> > The key size is tested by hex2bin() already (as '\0' isn't an hex digit)
> > 
> > Suggested-by: Andy Shevchenko <andriy.shevchenko@intel.com>
> > Signed-off-by: Yehezkel Bernat <yehezkel.bernat@intel.com>
> 
> Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>

Hi Greg,

Do you have any comments regarding these patches? If not could you take
them to your char-misc tree?

Thanks!

[toc] | [next] | [standalone]


#1721661

FromGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Date2017-08-28 16:30 +0200
Message-ID<ujtd7-6G2-15@gated-at.bofh.it>
In reply to#1720832
On Sun, Aug 27, 2017 at 04:31:27PM +0300, Mika Westerberg wrote:
> On Tue, Aug 15, 2017 at 10:02:28AM +0300, Mika Westerberg wrote:
> > On Tue, Aug 15, 2017 at 08:19:01AM +0300, Bernat, Yehezkel wrote:
> > > The key size is tested by hex2bin() already (as '\0' isn't an hex digit)
> > > 
> > > Suggested-by: Andy Shevchenko <andriy.shevchenko@intel.com>
> > > Signed-off-by: Yehezkel Bernat <yehezkel.bernat@intel.com>
> > 
> > Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
> 
> Hi Greg,
> 
> Do you have any comments regarding these patches? If not could you take
> them to your char-misc tree?

Will do, thanks.

greg k-h

[toc] | [prev] | [next] | [standalone]


#1723364

From"Bernat, Yehezkel" <yehezkel.bernat@intel.com>
Date2017-08-30 16:10 +0200
Message-ID<ukbQT-R3-31@gated-at.bofh.it>
In reply to#1721661
On Mon, 2017-08-28 at 16:20 +0200, Greg Kroah-Hartman wrote:
> On Sun, Aug 27, 2017 at 04:31:27PM +0300, Mika Westerberg wrote:
> > 
> > On Tue, Aug 15, 2017 at 10:02:28AM +0300, Mika Westerberg wrote:
> > > 
> > > On Tue, Aug 15, 2017 at 08:19:01AM +0300, Bernat, Yehezkel wrote:
> > > > 
> > > > The key size is tested by hex2bin() already (as '\0' isn't an
> > > > hex digit)
> > > > 
> > > > Suggested-by: Andy Shevchenko <andriy.shevchenko@intel.com>
> > > > Signed-off-by: Yehezkel Bernat <yehezkel.bernat@intel.com>
> > > Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
> > Hi Greg,
> > 
> > Do you have any comments regarding these patches? If not could you
> > take
> > them to your char-misc tree?
> Will do, thanks.
> 
> greg k-h

Hi Greg,

I'm not sure if you intended to do so anyway, but I think it worth
adding to v4.13, as these are fixes (and somewhat security related).

Thanks,
Yehezkel

[toc] | [prev] | [next] | [standalone]


#1723393

From"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
Date2017-08-30 16:30 +0200
Message-ID<ukcaf-ZN-43@gated-at.bofh.it>
In reply to#1723364
On Wed, Aug 30, 2017 at 02:00:53PM +0000, Bernat, Yehezkel wrote:
> On Mon, 2017-08-28 at 16:20 +0200, Greg Kroah-Hartman wrote:
> > On Sun, Aug 27, 2017 at 04:31:27PM +0300, Mika Westerberg wrote:
> > > 
> > > On Tue, Aug 15, 2017 at 10:02:28AM +0300, Mika Westerberg wrote:
> > > > 
> > > > On Tue, Aug 15, 2017 at 08:19:01AM +0300, Bernat, Yehezkel wrote:
> > > > > 
> > > > > The key size is tested by hex2bin() already (as '\0' isn't an
> > > > > hex digit)
> > > > > 
> > > > > Suggested-by: Andy Shevchenko <andriy.shevchenko@intel.com>
> > > > > Signed-off-by: Yehezkel Bernat <yehezkel.bernat@intel.com>
> > > > Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
> > > Hi Greg,
> > > 
> > > Do you have any comments regarding these patches? If not could you
> > > take
> > > them to your char-misc tree?
> > Will do, thanks.
> > 
> > greg k-h
> 
> Hi Greg,
> 
> I'm not sure if you intended to do so anyway, but I think it worth
> adding to v4.13, as these are fixes (and somewhat security related).

I didn't intend to, it's a bit late for 4.13, if you think these should
be backported, let stable@vger.kernel.org know the git commit ids when
they land in Linus's tree, and I'll be glad to backport them.

thanks,

greg k-h

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web