Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1723299 > unrolled thread
| Started by | Stephen Rothwell <sfr@canb.auug.org.au> |
|---|---|
| First post | 2017-08-30 15:10 +0200 |
| Last post | 2017-08-30 19:30 +0200 |
| Articles | 5 — 3 participants |
Back to article view | Back to linux.kernel
linux-next: Signed-off-by missing for commit in the arm-soc tree Stephen Rothwell <sfr@canb.auug.org.au> - 2017-08-30 15:10 +0200
Re: linux-next: Signed-off-by missing for commit in the arm-soc tree Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2017-08-30 15:20 +0200
Re: linux-next: Signed-off-by missing for commit in the arm-soc tree Olof Johansson <olof@lixom.net> - 2017-08-30 18:30 +0200
Re: linux-next: Signed-off-by missing for commit in the arm-soc tree Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2017-08-30 18:50 +0200
Re: linux-next: Signed-off-by missing for commit in the arm-soc tree Stephen Rothwell <sfr@canb.auug.org.au> - 2017-08-30 19:30 +0200
| From | Stephen Rothwell <sfr@canb.auug.org.au> |
|---|---|
| Date | 2017-08-30 15:10 +0200 |
| Subject | linux-next: Signed-off-by missing for commit in the arm-soc tree |
| Message-ID | <ukaUN-i2-3@gated-at.bofh.it> |
Hi all,
Commit
1a9f9af07e80 ("ARM: dts: at91: at91sam9g45: add AC97")
is missing a Signed-off-by from its author.
--
Cheers,
Stephen Rothwell
[toc] | [next] | [standalone]
| From | Alexandre Belloni <alexandre.belloni@free-electrons.com> |
|---|---|
| Date | 2017-08-30 15:20 +0200 |
| Message-ID | <ukb4t-li-3@gated-at.bofh.it> |
| In reply to | #1723299 |
On 30/08/2017 at 23:07:12 +1000, Stephen Rothwell wrote:
> Hi all,
>
> Commit
>
> 1a9f9af07e80 ("ARM: dts: at91: at91sam9g45: add AC97")
>
> is missing a Signed-off-by from its author.
>
Oh crap, it was the only one not in linux-next... iThe original
submission had the SoB:
https://patchwork.kernel.org/patch/9794803/
Olof, how do you want to proceed?
> --
> Cheers,
> Stephen Rothwell
--
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
[toc] | [prev] | [next] | [standalone]
| From | Olof Johansson <olof@lixom.net> |
|---|---|
| Date | 2017-08-30 18:30 +0200 |
| Message-ID | <uke2m-2bH-19@gated-at.bofh.it> |
| In reply to | #1723314 |
On Wed, Aug 30, 2017 at 6:19 AM, Alexandre Belloni
<alexandre.belloni@free-electrons.com> wrote:
> On 30/08/2017 at 23:07:12 +1000, Stephen Rothwell wrote:
>> Hi all,
>>
>> Commit
>>
>> 1a9f9af07e80 ("ARM: dts: at91: at91sam9g45: add AC97")
>>
>> is missing a Signed-off-by from its author.
>>
>
> Oh crap, it was the only one not in linux-next... iThe original
> submission had the SoB:
> https://patchwork.kernel.org/patch/9794803/
>
> Olof, how do you want to proceed?
Please prepare a new branch. I'll rebuild next/dt (and our for-next)
to drop your previous version, and merge it when it's ready.
Thanks for the heads up, Stephen. I presume you have a script that
checks this? It's something we should run too, do you keep it in a
shared location?
-Olof
[toc] | [prev] | [next] | [standalone]
| From | Alexandre Belloni <alexandre.belloni@free-electrons.com> |
|---|---|
| Date | 2017-08-30 18:50 +0200 |
| Message-ID | <ukelH-2il-3@gated-at.bofh.it> |
| In reply to | #1723486 |
On 30/08/2017 at 09:21:47 -0700, Olof Johansson wrote:
> On Wed, Aug 30, 2017 at 6:19 AM, Alexandre Belloni
> <alexandre.belloni@free-electrons.com> wrote:
> > On 30/08/2017 at 23:07:12 +1000, Stephen Rothwell wrote:
> >> Hi all,
> >>
> >> Commit
> >>
> >> 1a9f9af07e80 ("ARM: dts: at91: at91sam9g45: add AC97")
> >>
> >> is missing a Signed-off-by from its author.
> >>
> >
> > Oh crap, it was the only one not in linux-next... iThe original
> > submission had the SoB:
> > https://patchwork.kernel.org/patch/9794803/
> >
> > Olof, how do you want to proceed?
>
> Please prepare a new branch. I'll rebuild next/dt (and our for-next)
> to drop your previous version, and merge it when it's ready.
>
> Thanks for the heads up, Stephen. I presume you have a script that
> checks this? It's something we should run too, do you keep it in a
> shared location?
>
Yeah, I'm interested as well as I'm already using a pre_push hook to check
that my SoB is there.
--
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
[toc] | [prev] | [next] | [standalone]
| From | Stephen Rothwell <sfr@canb.auug.org.au> |
|---|---|
| Date | 2017-08-30 19:30 +0200 |
| Subject | Re: linux-next: Signed-off-by missing for commit in the arm-soc tree |
| Message-ID | <ukeYp-2MD-7@gated-at.bofh.it> |
| In reply to | #1723486 |
Hi Olof, On Wed, 30 Aug 2017 09:21:47 -0700 Olof Johansson <olof@lixom.net> wrote: > > Thanks for the heads up, Stephen. I presume you have a script that > checks this? It's something we should run too, do you keep it in a > shared location? Script below. -- Cheers, Stephen Rothwell #!/bin/bash if [ "$#" -lt 1 ]; then printf "Usage: %s <commit range>\n", "$0" 1>&2 exit 1 fi for c in $(git rev-list --no-merges "$@"); do ae=$(git log -1 --format='%ae' "$c") aE=$(git log -1 --format='%aE' "$c") an=$(git log -1 --format='%an' "$c") aN=$(git log -1 --format='%aN' "$c") ce=$(git log -1 --format='%ce' "$c") cE=$(git log -1 --format='%cE' "$c") cn=$(git log -1 --format='%cn' "$c") cN=$(git log -1 --format='%cN' "$c") sob=$(git log -1 --format='%b' "$c" | grep -i '^[[:space:]]*Signed-off-by:') am=false cm=false grep -i -q "<$ae>" <<<"$sob" || grep -i -q "<$aE>" <<<"$sob" || grep -i -q ":[[:space:]]*$an[[:space:]]*<" <<<"$sob" || grep -i -q ":[[:space:]]*$aN[[:space:]]*<" <<<"$sob" || am=true grep -i -q "<$ce>" <<<"$sob" || grep -i -q "<$cE>" <<<"$sob" || grep -i -q ":[[:space:]]*$cn[[:space:]]*<" <<<"$sob" || grep -i -q ":[[:space:]]*$cN[[:space:]]*<" <<<"$sob" || cm=true if "$am" || "$cm"; then printf "Commit %s\n" "$c" "$am" && printf "\tauthor SOB missing\n" "$cm" && printf "\tcommitter SOB missing\n" printf "%s %s\n%s\n" "$ae" "$ce" "$sob" fi done exec gitk "$@"
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web