Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1725246 > unrolled thread
| Started by | Jaegeuk Kim <jaegeuk@kernel.org> |
|---|---|
| First post | 2017-09-01 19:30 +0200 |
| Last post | 2017-09-04 03:40 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH 2/2] f2fs: don't check inode's checksum if it was dirtied or writebacked Jaegeuk Kim <jaegeuk@kernel.org> - 2017-09-01 19:30 +0200
Re: [f2fs-dev] [PATCH 2/2] f2fs: don't check inode's checksum if it was dirtied or writebacked Chao Yu <yuchao0@huawei.com> - 2017-09-04 03:40 +0200
| From | Jaegeuk Kim <jaegeuk@kernel.org> |
|---|---|
| Date | 2017-09-01 19:30 +0200 |
| Subject | [PATCH 2/2] f2fs: don't check inode's checksum if it was dirtied or writebacked |
| Message-ID | <ukXVv-8aN-1@gated-at.bofh.it> |
If another thread already made the page dirtied or writebacked, we must avoid to verify checksum. If we got an error, we need to remove its uptodate as well. Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org> --- fs/f2fs/inode.c | 3 ++- fs/f2fs/node.c | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/fs/f2fs/inode.c b/fs/f2fs/inode.c index b4c401d456e7..c33b05aec1a1 100644 --- a/fs/f2fs/inode.c +++ b/fs/f2fs/inode.c @@ -153,7 +153,8 @@ bool f2fs_inode_chksum_verify(struct f2fs_sb_info *sbi, struct page *page) struct f2fs_inode *ri; __u32 provided, calculated; - if (!f2fs_enable_inode_chksum(sbi, page)) + if (!f2fs_enable_inode_chksum(sbi, page) || + PageDirty(page) || PageWriteback(page)) return true; ri = &F2FS_NODE(page)->i; diff --git a/fs/f2fs/node.c b/fs/f2fs/node.c index 388a00262a5f..fca87835a1da 100644 --- a/fs/f2fs/node.c +++ b/fs/f2fs/node.c @@ -1187,9 +1187,9 @@ static struct page *__get_node_page(struct f2fs_sb_info *sbi, pgoff_t nid, nid, nid_of_node(page), ino_of_node(page), ofs_of_node(page), cpver_of_node(page), next_blkaddr_of_node(page)); - ClearPageUptodate(page); err = -EINVAL; out_err: + ClearPageUptodate(page); f2fs_put_page(page, 1); return ERR_PTR(err); } -- 2.14.0.rc1.383.gd1ce394fe2-goog
[toc] | [next] | [standalone]
| From | Chao Yu <yuchao0@huawei.com> |
|---|---|
| Date | 2017-09-04 03:40 +0200 |
| Subject | Re: [f2fs-dev] [PATCH 2/2] f2fs: don't check inode's checksum if it was dirtied or writebacked |
| Message-ID | <ulOwO-7s0-1@gated-at.bofh.it> |
| In reply to | #1725246 |
On 2017/9/2 1:25, Jaegeuk Kim wrote: > If another thread already made the page dirtied or writebacked, we must avoid > to verify checksum. If we got an error, we need to remove its uptodate as well. > > Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org> Reviewed-by: Chao Yu <yuchao0@huawei.com> > --- > fs/f2fs/inode.c | 3 ++- > fs/f2fs/node.c | 2 +- > 2 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/fs/f2fs/inode.c b/fs/f2fs/inode.c > index b4c401d456e7..c33b05aec1a1 100644 > --- a/fs/f2fs/inode.c > +++ b/fs/f2fs/inode.c > @@ -153,7 +153,8 @@ bool f2fs_inode_chksum_verify(struct f2fs_sb_info *sbi, struct page *page) > struct f2fs_inode *ri; > __u32 provided, calculated; > > - if (!f2fs_enable_inode_chksum(sbi, page)) > + if (!f2fs_enable_inode_chksum(sbi, page) || > + PageDirty(page) || PageWriteback(page)) > return true; > > ri = &F2FS_NODE(page)->i; > diff --git a/fs/f2fs/node.c b/fs/f2fs/node.c > index 388a00262a5f..fca87835a1da 100644 > --- a/fs/f2fs/node.c > +++ b/fs/f2fs/node.c > @@ -1187,9 +1187,9 @@ static struct page *__get_node_page(struct f2fs_sb_info *sbi, pgoff_t nid, > nid, nid_of_node(page), ino_of_node(page), > ofs_of_node(page), cpver_of_node(page), > next_blkaddr_of_node(page)); > - ClearPageUptodate(page); > err = -EINVAL; > out_err: > + ClearPageUptodate(page); > f2fs_put_page(page, 1); > return ERR_PTR(err); > } >
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web