Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1724924 > unrolled thread
| Started by | Colin King <colin.king@canonical.com> |
|---|---|
| First post | 2017-09-01 12:00 +0200 |
| Last post | 2017-09-04 05:40 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH][next] Thermal: int3406_thermal: fix unused variable warning Colin King <colin.king@canonical.com> - 2017-09-01 12:00 +0200
Re: [PATCH][next] Thermal: int3406_thermal: fix unused variable warning Zhang Rui <rui.zhang@intel.com> - 2017-09-04 05:40 +0200
| From | Colin King <colin.king@canonical.com> |
|---|---|
| Date | 2017-09-01 12:00 +0200 |
| Subject | [PATCH][next] Thermal: int3406_thermal: fix unused variable warning |
| Message-ID | <ukQU1-29D-1@gated-at.bofh.it> |
From: Colin Ian King <colin.king@canonical.com>
The variable index was introduced by an earlier commit and is not
used, and hence should be removed.
Cleans up warning: "unused variable 'index'"
Fixes: c658894562ba ("Thermal: int3406_thermal: fix thermal sysfs I/F")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/thermal/int340x_thermal/int3406_thermal.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/thermal/int340x_thermal/int3406_thermal.c b/drivers/thermal/int340x_thermal/int3406_thermal.c
index e31509ead1c9..f69ab026ba24 100644
--- a/drivers/thermal/int340x_thermal/int3406_thermal.c
+++ b/drivers/thermal/int340x_thermal/int3406_thermal.c
@@ -113,7 +113,6 @@ static void int3406_thermal_get_limit(struct int3406_thermal_data *d)
{
acpi_status status;
unsigned long long lower_limit, upper_limit;
- int index;
status = acpi_evaluate_integer(d->handle, "DDDL", NULL, &lower_limit);
if (ACPI_SUCCESS(status))
--
2.14.1
[toc] | [next] | [standalone]
| From | Zhang Rui <rui.zhang@intel.com> |
|---|---|
| Date | 2017-09-04 05:40 +0200 |
| Subject | Re: [PATCH][next] Thermal: int3406_thermal: fix unused variable warning |
| Message-ID | <ulQoV-fc-7@gated-at.bofh.it> |
| In reply to | #1724924 |
On Fri, 2017-09-01 at 10:58 +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The variable index was introduced by an earlier commit and is not
> used, and hence should be removed.
>
> Cleans up warning: "unused variable 'index'"
>
> Fixes: c658894562ba ("Thermal: int3406_thermal: fix thermal sysfs
> I/F")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
thanks, I will fold this cleanup into the previous commit c658894562ba
("Thermal: int3406_thermal: fix thermal sysfs I/F").
thanks,
rui
> ---
> drivers/thermal/int340x_thermal/int3406_thermal.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/thermal/int340x_thermal/int3406_thermal.c
> b/drivers/thermal/int340x_thermal/int3406_thermal.c
> index e31509ead1c9..f69ab026ba24 100644
> --- a/drivers/thermal/int340x_thermal/int3406_thermal.c
> +++ b/drivers/thermal/int340x_thermal/int3406_thermal.c
> @@ -113,7 +113,6 @@ static void int3406_thermal_get_limit(struct
> int3406_thermal_data *d)
> {
> acpi_status status;
> unsigned long long lower_limit, upper_limit;
> - int index;
>
> status = acpi_evaluate_integer(d->handle, "DDDL", NULL,
> &lower_limit);
> if (ACPI_SUCCESS(status))
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web