Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1721864 > unrolled thread
| Started by | Bhumika Goyal <bhumirks@gmail.com> |
|---|---|
| First post | 2017-08-28 20:10 +0200 |
| Last post | 2017-08-28 20:50 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] IPMI: make ipmi_poweroff_handler const Bhumika Goyal <bhumirks@gmail.com> - 2017-08-28 20:10 +0200
Re: [PATCH] IPMI: make ipmi_poweroff_handler const Corey Minyard <minyard@acm.org> - 2017-08-28 20:50 +0200
| From | Bhumika Goyal <bhumirks@gmail.com> |
|---|---|
| Date | 2017-08-28 20:10 +0200 |
| Subject | [PATCH] IPMI: make ipmi_poweroff_handler const |
| Message-ID | <ujwE2-pb-21@gated-at.bofh.it> |
Make this const as it is only passed to a const argument of the function
ipmi_create_user.
Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
---
drivers/char/ipmi/ipmi_poweroff.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/char/ipmi/ipmi_poweroff.c b/drivers/char/ipmi/ipmi_poweroff.c
index 9f2e3be..cd0f41f 100644
--- a/drivers/char/ipmi/ipmi_poweroff.c
+++ b/drivers/char/ipmi/ipmi_poweroff.c
@@ -133,7 +133,7 @@ static void receive_handler(struct ipmi_recv_msg *recv_msg, void *handler_data)
complete(comp);
}
-static struct ipmi_user_hndl ipmi_poweroff_handler = {
+static const struct ipmi_user_hndl ipmi_poweroff_handler = {
.ipmi_recv_hndl = receive_handler
};
--
1.9.1
[toc] | [next] | [standalone]
| From | Corey Minyard <minyard@acm.org> |
|---|---|
| Date | 2017-08-28 20:50 +0200 |
| Message-ID | <ujxgK-Em-19@gated-at.bofh.it> |
| In reply to | #1721864 |
On 08/28/2017 01:08 PM, Bhumika Goyal wrote:
> Make this const as it is only passed to a const argument of the function
> ipmi_create_user.
Queued for the next kernel release.
-corey
> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
> ---
> drivers/char/ipmi/ipmi_poweroff.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/char/ipmi/ipmi_poweroff.c b/drivers/char/ipmi/ipmi_poweroff.c
> index 9f2e3be..cd0f41f 100644
> --- a/drivers/char/ipmi/ipmi_poweroff.c
> +++ b/drivers/char/ipmi/ipmi_poweroff.c
> @@ -133,7 +133,7 @@ static void receive_handler(struct ipmi_recv_msg *recv_msg, void *handler_data)
> complete(comp);
> }
>
> -static struct ipmi_user_hndl ipmi_poweroff_handler = {
> +static const struct ipmi_user_hndl ipmi_poweroff_handler = {
> .ipmi_recv_hndl = receive_handler
> };
>
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web