Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1720631 > unrolled thread

[PATCH 3/5] [media] solo6x10: make video_device const

Started byBhumika Goyal <bhumirks@gmail.com>
First post2017-08-26 13:20 +0200
Last post2017-08-28 20:50 +0200
Articles 2 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  [PATCH 3/5] [media] solo6x10:  make video_device const Bhumika Goyal <bhumirks@gmail.com> - 2017-08-26 13:20 +0200
    Re: [PATCH 3/5] [media] solo6x10:  make video_device const Ismael Luceno <ismael@iodev.co.uk> - 2017-08-28 20:50 +0200

#1720631 — [PATCH 3/5] [media] solo6x10: make video_device const

FromBhumika Goyal <bhumirks@gmail.com>
Date2017-08-26 13:20 +0200
Subject[PATCH 3/5] [media] solo6x10: make video_device const
Message-ID<uiHia-ul-11@gated-at.bofh.it>
Make this const as it is only used in a copy operation.

Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
---
 drivers/media/pci/solo6x10/solo6x10-v4l2.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/pci/solo6x10/solo6x10-v4l2.c b/drivers/media/pci/solo6x10/solo6x10-v4l2.c
index 3266fc2..99ffd1e 100644
--- a/drivers/media/pci/solo6x10/solo6x10-v4l2.c
+++ b/drivers/media/pci/solo6x10/solo6x10-v4l2.c
@@ -630,7 +630,7 @@ static int solo_s_ctrl(struct v4l2_ctrl *ctrl)
 	.vidioc_unsubscribe_event	= v4l2_event_unsubscribe,
 };
 
-static struct video_device solo_v4l2_template = {
+static const struct video_device solo_v4l2_template = {
 	.name			= SOLO6X10_NAME,
 	.fops			= &solo_v4l2_fops,
 	.ioctl_ops		= &solo_v4l2_ioctl_ops,
-- 
1.9.1

[toc] | [next] | [standalone]


#1721900

FromIsmael Luceno <ismael@iodev.co.uk>
Date2017-08-28 20:50 +0200
Message-ID<ujxgJ-Em-1@gated-at.bofh.it>
In reply to#1720631
On 26/Aug/2017 16:43, Bhumika Goyal wrote:
> Make this const as it is only used in a copy operation.
> 
> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
> ---
>  drivers/media/pci/solo6x10/solo6x10-v4l2.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/pci/solo6x10/solo6x10-v4l2.c b/drivers/media/pci/solo6x10/solo6x10-v4l2.c
> index 3266fc2..99ffd1e 100644
> --- a/drivers/media/pci/solo6x10/solo6x10-v4l2.c
> +++ b/drivers/media/pci/solo6x10/solo6x10-v4l2.c
> @@ -630,7 +630,7 @@ static int solo_s_ctrl(struct v4l2_ctrl *ctrl)
>  	.vidioc_unsubscribe_event	= v4l2_event_unsubscribe,
>  };
>  
> -static struct video_device solo_v4l2_template = {
> +static const struct video_device solo_v4l2_template = {
>  	.name			= SOLO6X10_NAME,
>  	.fops			= &solo_v4l2_fops,
>  	.ioctl_ops		= &solo_v4l2_ioctl_ops,
> -- 
> 1.9.1
> 

Signed-off-by: Ismael Luceno <ismael@iodev.co.uk>

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web