Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1721876 > unrolled thread
| Started by | Christoffer Dall <cdall@linaro.org> |
|---|---|
| First post | 2017-08-28 20:20 +0200 |
| Last post | 2017-08-30 13:10 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH v3 43/59] KVM: arm/arm64: GICv4: Unmap VLPI when freeing an LPI Christoffer Dall <cdall@linaro.org> - 2017-08-28 20:20 +0200
Re: [PATCH v3 43/59] KVM: arm/arm64: GICv4: Unmap VLPI when freeing an LPI Marc Zyngier <marc.zyngier@arm.com> - 2017-08-30 13:10 +0200
| From | Christoffer Dall <cdall@linaro.org> |
|---|---|
| Date | 2017-08-28 20:20 +0200 |
| Subject | Re: [PATCH v3 43/59] KVM: arm/arm64: GICv4: Unmap VLPI when freeing an LPI |
| Message-ID | <ujwNI-sx-29@gated-at.bofh.it> |
On Mon, Jul 31, 2017 at 06:26:21PM +0100, Marc Zyngier wrote:
> When freeing an LPI (on a DISCARD command, for example), we need
> to unmap the VLPI down to the physical ITS level.
>
> Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
> ---
> virt/kvm/arm/vgic/vgic-its.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/virt/kvm/arm/vgic/vgic-its.c b/virt/kvm/arm/vgic/vgic-its.c
> index 40aeadef33fe..79bac93d3e7d 100644
> --- a/virt/kvm/arm/vgic/vgic-its.c
> +++ b/virt/kvm/arm/vgic/vgic-its.c
> @@ -623,8 +623,12 @@ static void its_free_ite(struct kvm *kvm, struct its_ite *ite)
> list_del(&ite->ite_list);
>
> /* This put matches the get in vgic_add_lpi. */
> - if (ite->irq)
> + if (ite->irq) {
> + if (ite->irq->hw)
> + its_unmap_vlpi(ite->irq->host_irq);
nit: should we raise a warning on a bad return value?
Otherwise:
Acked-by: Christoffer Dall <cdall@linaro.org>
> +
> vgic_put_irq(kvm, ite->irq);
> + }
>
> kfree(ite);
> }
> --
> 2.11.0
>
[toc] | [next] | [standalone]
| From | Marc Zyngier <marc.zyngier@arm.com> |
|---|---|
| Date | 2017-08-30 13:10 +0200 |
| Message-ID | <uk92H-7yD-17@gated-at.bofh.it> |
| In reply to | #1721876 |
On 28/08/17 19:18, Christoffer Dall wrote:
> On Mon, Jul 31, 2017 at 06:26:21PM +0100, Marc Zyngier wrote:
>> When freeing an LPI (on a DISCARD command, for example), we need
>> to unmap the VLPI down to the physical ITS level.
>>
>> Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
>> ---
>> virt/kvm/arm/vgic/vgic-its.c | 6 +++++-
>> 1 file changed, 5 insertions(+), 1 deletion(-)
>>
>> diff --git a/virt/kvm/arm/vgic/vgic-its.c b/virt/kvm/arm/vgic/vgic-its.c
>> index 40aeadef33fe..79bac93d3e7d 100644
>> --- a/virt/kvm/arm/vgic/vgic-its.c
>> +++ b/virt/kvm/arm/vgic/vgic-its.c
>> @@ -623,8 +623,12 @@ static void its_free_ite(struct kvm *kvm, struct its_ite *ite)
>> list_del(&ite->ite_list);
>>
>> /* This put matches the get in vgic_add_lpi. */
>> - if (ite->irq)
>> + if (ite->irq) {
>> + if (ite->irq->hw)
>> + its_unmap_vlpi(ite->irq->host_irq);
>
> nit: should we raise a warning on a bad return value?
I guess we could. Getting an error here is am indication that something
has gone wrong...
> Otherwise:
>
> Acked-by: Christoffer Dall <cdall@linaro.org>
Thanks,
M.
--
Jazz is not dead. It just smells funny...
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web