Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1721648 > unrolled thread

Re: [PATCH] drivers: tty: Fix improper spaces and braces

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH] drivers: tty: Fix improper spaces and braces Greg KH <gregkh@linuxfoundation.org> - 2017-08-28 16:20 +0200
    Re: [PATCH] drivers: tty: Fix improper spaces and braces Himanshu Jha <himanshujha199640@gmail.com> - 2017-08-28 17:10 +0200

#1721648 — Re: [PATCH] drivers: tty: Fix improper spaces and braces

On Mon, Aug 21, 2017 at 06:24:41PM +0530, Himanshu Jha wrote:
> Fixes improper spacing by adding/subtracting necessary spaces
> around expression and keywords, and removing unnecessary braces.
> 
> Signed-off-by: Himanshu Jha <himanshujha199640@gmail.com>
> ---
>  drivers/tty/amiserial.c | 107 +++++++++++++++++++++++-------------------------
>  1 file changed, 51 insertions(+), 56 deletions(-)

Please put the driver name in the subject.

Also, you sent multiple patches for this driver, and I don't know which
one to apply in which order, please fix up and resend it as a series.

thanks,

greg k-h

[toc] | [next] | [standalone]

#1721710

On Mon, Aug 28, 2017 at 04:14:08PM +0200, Greg KH wrote:
> On Mon, Aug 21, 2017 at 06:24:41PM +0530, Himanshu Jha wrote:
> > Fixes improper spacing by adding/subtracting necessary spaces
> > around expression and keywords, and removing unnecessary braces.
> > 
> > Signed-off-by: Himanshu Jha <himanshujha199640@gmail.com>
> > ---
> >  drivers/tty/amiserial.c | 107 +++++++++++++++++++++++-------------------------
> >  1 file changed, 51 insertions(+), 56 deletions(-)
> 
> Please put the driver name in the subject.
I will send this again with appropriate subject.
> 
> Also, you sent multiple patches for this driver, and I don't know which
> one to apply in which order, please fix up and resend it as a series.
I have only send 1 patch for this driver and that has been added to the
tty-testing branch.

Patch title: "tty: serial: 8250_mtk: Use PTR_ERR_OR_ZERO"

I don't know if you are talking about staging/rtl8723bs patches that i
sent you while ago ?

Please let me know!

Thanks

> 
> thanks,
> 
> greg k-h

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web