Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1721310 > unrolled thread

Re: [PATCH] staging: gdm724x: Rename variable for consistency

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH] staging: gdm724x: Rename variable for consistency Greg KH <gregkh@linuxfoundation.org> - 2017-08-28 10:50 +0200
    [PATCH v2] staging : gdm724x: Rename variable for consistency Nick Fox <fox.nicholas.j@gmail.com> - 2017-08-30 05:20 +0200
      Re: [PATCH v2] staging : gdm724x: Rename variable for consistency Greg KH <gregkh@linuxfoundation.org> - 2017-08-31 18:30 +0200

#1721310 — Re: [PATCH] staging: gdm724x: Rename variable for consistency

On Thu, Aug 24, 2017 at 07:18:53PM -0400, Nick Fox wrote:
> Rename dftEpsId variable to dft_eps_ID to be consistent with other
> variables in the source file.
> 
> Signed-off-by: Nick Fox <fox.nicholas.j@gmail.com>
> ---
>  drivers/staging/gdm724x/hci_packet.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Always test-build your patches, to not do so is rude to those of us you
expect to apply your patch :(

greg k-h

[toc] | [next] | [standalone]

#1722999 — [PATCH v2] staging : gdm724x: Rename variable for consistency

v2: Undo the renaming of the dft_eps_id variable in hci_pdn_table_ind
to resolve a compiler error.

Signed-off-by: Nick Fox <fox.nicholas.j@gmail.com>
---
 drivers/staging/gdm724x/hci_packet.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/gdm724x/hci_packet.h b/drivers/staging/gdm724x/hci_packet.h
index 22ce8b9477b6..f8837c7103ac 100644
--- a/drivers/staging/gdm724x/hci_packet.h
+++ b/drivers/staging/gdm724x/hci_packet.h
@@ -50,7 +50,7 @@ struct tlv {
 struct sdu_header {
 	__dev16 cmd_evt;
 	__dev16 len;
-	__dev32 dftEpsId;
+	__dev32 dft_eps_ID;
 	__dev32 bearer_ID;
 	__dev32 nic_type;
 } __packed;
-- 
2.13.5

[toc] | [prev] | [next] | [standalone]

#1724395 — Re: [PATCH v2] staging : gdm724x: Rename variable for consistency

On Tue, Aug 29, 2017 at 11:11:29PM -0400, Nick Fox wrote:
> v2: Undo the renaming of the dft_eps_id variable in hci_pdn_table_ind
> to resolve a compiler error.

What compiler error?  Who reported it?

And why put v2 here in the changelog area?

totally confused,

greg k-h

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web