Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1720973 > unrolled thread

[PATCH] pinctrl: uniphier: fix members of rmii group for Pro4

Back to article view | Back to linux.kernel

Contents

  [PATCH] pinctrl: uniphier: fix members of rmii group for Pro4 Kunihiko Hayashi <hayashi.kunihiko@socionext.com> - 2017-08-28 04:30 +0200
    Re: [PATCH] pinctrl: uniphier: fix members of rmii group for Pro4 Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-08-28 04:30 +0200
      Re: [PATCH] pinctrl: uniphier: fix members of rmii group for Pro4 Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-08-28 05:20 +0200
    Re: [PATCH] pinctrl: uniphier: fix members of rmii group for Pro4 Linus Walleij <linus.walleij@linaro.org> - 2017-08-31 16:00 +0200

#1720973 — [PATCH] pinctrl: uniphier: fix members of rmii group for Pro4

The ether_rmii_groups should have "ether_rmii" and "ether_rmiib" as
members. This patch replaces to them.

Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
---
 drivers/pinctrl/uniphier/pinctrl-uniphier-pro4.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pinctrl/uniphier/pinctrl-uniphier-pro4.c b/drivers/pinctrl/uniphier/pinctrl-uniphier-pro4.c
index a433a30..adc65ea 100644
--- a/drivers/pinctrl/uniphier/pinctrl-uniphier-pro4.c
+++ b/drivers/pinctrl/uniphier/pinctrl-uniphier-pro4.c
@@ -1462,7 +1462,7 @@ static const struct uniphier_pinctrl_group uniphier_pro4_groups[] = {
 static const char * const emmc_groups[] = {"emmc", "emmc_dat8"};
 static const char * const ether_mii_groups[] = {"ether_mii"};
 static const char * const ether_rgmii_groups[] = {"ether_rgmii"};
-static const char * const ether_rmii_groups[] = {"ether_rgmii", "ether_rgmiib"};
+static const char * const ether_rmii_groups[] = {"ether_rmii", "ether_rmiib"};
 static const char * const i2c0_groups[] = {"i2c0"};
 static const char * const i2c1_groups[] = {"i2c1"};
 static const char * const i2c2_groups[] = {"i2c2"};
-- 
2.7.4

[toc] | [next] | [standalone]

#1720974

2017-08-28 11:21 GMT+09:00 Kunihiko Hayashi <hayashi.kunihiko@socionext.com>:
> The ether_rmii_groups should have "ether_rmii" and "ether_rmiib" as
> members. This patch replaces to them.


Linus,
When you pick up this, please add

Fixes: 1e359ab1285e ("1e359ab1285eaa7")


> Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>


Otherwise, looks good to me.

Acked-by: Masahiro Yamada <yamada.masahiro@socionext.com>





-- 
Best Regards
Masahiro Yamada

[toc] | [prev] | [next] | [standalone]

#1720983

2017-08-28 11:28 GMT+09:00 Masahiro Yamada <yamada.masahiro@socionext.com>:
> 2017-08-28 11:21 GMT+09:00 Kunihiko Hayashi <hayashi.kunihiko@socionext.com>:
>> The ether_rmii_groups should have "ether_rmii" and "ether_rmiib" as
>> members. This patch replaces to them.
>
>
> Linus,
> When you pick up this, please add
>
> Fixes: 1e359ab1285e ("1e359ab1285eaa7")

My mistake.  I mean,

Fixes: 1e359ab1285e ("pinctrl: uniphier: add Ethernet pin-mux settings")



>
>> Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
>
>
> Otherwise, looks good to me.
>
> Acked-by: Masahiro Yamada <yamada.masahiro@socionext.com>
>
>
>
>
>
> --
> Best Regards
> Masahiro Yamada



-- 
Best Regards
Masahiro Yamada

[toc] | [prev] | [next] | [standalone]

#1724268

On Mon, Aug 28, 2017 at 4:21 AM, Kunihiko Hayashi
<hayashi.kunihiko@socionext.com> wrote:

> The ether_rmii_groups should have "ether_rmii" and "ether_rmiib" as
> members. This patch replaces to them.
>
> Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>

Patch applied with Fixes: tag and ACKs.

Yours,
Linus Walleij

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web