Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1720675 > unrolled thread

Re: [PATCH v2] ASoC: Add a sanity check before using dai driver name

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH v2] ASoC: Add a sanity check before using dai driver name Donglin Peng <dolinux.peng@gmail.com> - 2017-08-26 17:20 +0200
    Re: [PATCH v2] ASoC: Add a sanity check before using dai driver name Mark Brown <broonie@kernel.org> - 2017-08-27 14:20 +0200
      Re: [PATCH v2] ASoC: Add a sanity check before using dai driver name Donglin Peng <dolinux.peng@gmail.com> - 2017-08-27 16:00 +0200
        Re: [PATCH v2] ASoC: Add a sanity check before using dai driver name Mark Brown <broonie@kernel.org> - 2017-08-27 16:30 +0200
        Re: [PATCH v2] ASoC: Add a sanity check before using dai driver name Mark Brown <broonie@kernel.org> - 2017-08-27 16:40 +0200
          Re: [PATCH v2] ASoC: Add a sanity check before using dai driver name jeffy <jeffy.chen@rock-chips.com> - 2017-08-28 00:30 +0200
        Re: [PATCH v2] ASoC: Add a sanity check before using dai driver name Donglin Peng <dolinux.peng@gmail.com> - 2017-08-28 03:50 +0200

#1720675 — Re: [PATCH v2] ASoC: Add a sanity check before using dai driver name

Hi Mark,

On Sat, Aug 26, 2017 at 10:13 PM, kbuild test robot <lkp@intel.com> wrote:
> Hi Jeffy,
>
> [auto build test ERROR on asoc/for-next]
> [also build test ERROR on next-20170825]
> [cannot apply to v4.13-rc6]
> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
>
> url:    https://github.com/0day-ci/linux/commits/Jeffy-Chen/ASoC-Add-a-sanity-check-before-using-dai-driver-name/20170826-195851
> base:   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
> config: x86_64-randconfig-it0-08261958 (attached as .config)
> compiler: gcc-4.9 (Debian 4.9.4-2) 4.9.4
> reproduce:
>         # save the attached .config to linux build tree
>         make ARCH=x86_64
>
> All error/warnings (new ones prefixed by >>):
>
>    sound//soc/soc-core.c: In function 'snd_soc_find_dai':
>>> sound//soc/soc-core.c:4321:0: error: unterminated argument list invoking macro "if"
>     MODULE_ALIAS("platform:soc-audio");
>     ^
>>> sound//soc/soc-core.c:1031:4: error: expected '(' at end of input
>        if (dlc->dai_name && strcmp(dai->name, dlc->dai_name)
>        ^

It seems that the v3 patch should be applied other than v2.

[toc] | [next] | [standalone]

#1720811

[Multipart message — attachments visible in raw view] — view raw

On Sat, Aug 26, 2017 at 11:09:49PM +0800, Donglin Peng wrote:

> It seems that the v3 patch should be applied other than v2.

Please send incremental fixes rather than new versions for things that
are are already applied.

[toc] | [prev] | [next] | [standalone]

#1720836

Hi Jeffy,

On Sun, Aug 27, 2017 at 8:19 PM, Mark Brown <broonie@kernel.org> wrote:
> On Sat, Aug 26, 2017 at 11:09:49PM +0800, Donglin Peng wrote:
>
>> It seems that the v3 patch should be applied other than v2.
>
> Please send incremental fixes rather than new versions for things that
> are are already applied.

You should send a incremental patch rather than v3 patch, because your
v2 patch had been applied and caused this issue.

[toc] | [prev] | [next] | [standalone]

#1720840

[Multipart message — attachments visible in raw view] — view raw

On Sun, Aug 27, 2017 at 09:54:09PM +0800, Donglin Peng wrote:
> On Sun, Aug 27, 2017 at 8:19 PM, Mark Brown <broonie@kernel.org> wrote:

> > Please send incremental fixes rather than new versions for things that
> > are are already applied.

> You should send a incremental patch rather than v3 patch, because your
> v2 patch had been applied and caused this issue.

Right, so I actually just looked at this and I think the right thing got
applied as everything seems to be building fine but I could be confused
here.

[toc] | [prev] | [next] | [standalone]

#1720841

[Multipart message — attachments visible in raw view] — view raw

On Sun, Aug 27, 2017 at 10:31:52PM +0800, Jeffy Chen wrote:

This is a HTML only mail and I have a text only client...

[toc] | [prev] | [next] | [standalone]

#1720936

hi Mark,

On 08/27/2017 10:34 PM, Mark Brown wrote:
> On Sun, Aug 27, 2017 at 10:31:52PM +0800, Jeffy Chen wrote:
>
> This is a HTML only mail and I have a text only client...
>
sorry, i was replying with my phone, didn't notice it would use html by 
default...

i think you've applied the right version of patch(v3), and the robot is 
warning the v2 version :)

[toc] | [prev] | [next] | [standalone]

#1720967

On Sun, Aug 27, 2017 at 10:31 PM, Jeffy Chen <jeffy.chen@rock-chips.com> wrote:
> hi dong,
>
> thanks for noticing, but i think mark've applied the right version.
>
> this amazing robot would help to test all patches, not only the ones already
> applied :)

I also think so.

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web