Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1720800 > unrolled thread
| Started by | Angelo Dureghello <angelo@sysam.it> |
|---|---|
| First post | 2017-08-27 13:30 +0200 |
| Last post | 2017-08-27 23:20 +0200 |
| Articles | 4 — 3 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH] m68knommu: remove dead code Angelo Dureghello <angelo@sysam.it> - 2017-08-27 13:30 +0200
Re: [PATCH] m68knommu: remove dead code Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2017-08-27 21:20 +0200
Re: [PATCH] m68knommu: remove dead code Steven King <sfking@fdwdc.com> - 2017-08-27 22:00 +0200
Re: [PATCH] m68knommu: remove dead code Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2017-08-27 23:20 +0200
| From | Angelo Dureghello <angelo@sysam.it> |
|---|---|
| Date | 2017-08-27 13:30 +0200 |
| Subject | Re: [PATCH] m68knommu: remove dead code |
| Message-ID | <uj3Vn-6XJ-7@gated-at.bofh.it> |
Hi,
just to inform you that i have in mind to add spi(soon, at least seems
just a matter con Kconfig changes) and usdhc(later)
drivers/support for stmark2 mcf5441x based board.
But no problem, in case i'll re-add the this code as needed.
On 24/08/2017 16:34, Alexandre Belloni wrote:
> As CONFIG_RTC_DRV_M5441x doesn't exist because the driver never made it
> upstream, there is no device to register. Remove code that is never
> compiled and init_BSP() as it doesn't do anything.
>
> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> ---
> arch/m68k/coldfire/m5441x.c | 37 -------------------------------------
> 1 file changed, 37 deletions(-)
>
> diff --git a/arch/m68k/coldfire/m5441x.c b/arch/m68k/coldfire/m5441x.c
> index dc589b039b62..04fd7fde9fb3 100644
> --- a/arch/m68k/coldfire/m5441x.c
> +++ b/arch/m68k/coldfire/m5441x.c
> @@ -222,40 +222,3 @@ void __init config_BSP(char *commandp, int size)
> m5441x_uarts_init();
> m5441x_fec_init();
> }
> -
> -
> -#if IS_ENABLED(CONFIG_RTC_DRV_M5441x)
> -static struct resource m5441x_rtc_resources[] = {
> - {
> - .start = MCFRTC_BASE,
> - .end = MCFRTC_BASE + MCFRTC_SIZE - 1,
> - .flags = IORESOURCE_MEM,
> - },
> - {
> - .start = MCF_IRQ_RTC,
> - .end = MCF_IRQ_RTC,
> - .flags = IORESOURCE_IRQ,
> - },
> -};
> -
> -static struct platform_device m5441x_rtc = {
> - .name = "mcfrtc",
> - .id = 0,
> - .resource = m5441x_rtc_resources,
> - .num_resources = ARRAY_SIZE(m5441x_rtc_resources),
> -};
> -#endif
> -
> -static struct platform_device *m5441x_devices[] __initdata = {
> -#if IS_ENABLED(CONFIG_RTC_DRV_M5441x)
> - &m5441x_rtc,
> -#endif
> -};
> -
> -static int __init init_BSP(void)
> -{
> - platform_add_devices(m5441x_devices, ARRAY_SIZE(m5441x_devices));
> - return 0;
> -}
> -
> -arch_initcall(init_BSP);
>
Regards,
Angelo
[toc] | [next] | [standalone]
| From | Alexandre Belloni <alexandre.belloni@free-electrons.com> |
|---|---|
| Date | 2017-08-27 21:20 +0200 |
| Message-ID | <ujbgd-3uv-11@gated-at.bofh.it> |
| In reply to | #1720800 |
On 27/08/2017 at 13:22:09 +0200, Angelo Dureghello wrote:
> Hi,
>
> just to inform you that i have in mind to add spi(soon, at least seems
> just a matter con Kconfig changes) and usdhc(later)
> drivers/support for stmark2 mcf5441x based board.
> But no problem, in case i'll re-add the this code as needed.
>
I think it is easy enough to reintroduce init_BSP with your patch. It is
unfortunate that this useless function stayed that way so long, waiting
for a real user :)
> On 24/08/2017 16:34, Alexandre Belloni wrote:
> > As CONFIG_RTC_DRV_M5441x doesn't exist because the driver never made it
> > upstream, there is no device to register. Remove code that is never
> > compiled and init_BSP() as it doesn't do anything.
> >
> > Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> > ---
> > arch/m68k/coldfire/m5441x.c | 37 -------------------------------------
> > 1 file changed, 37 deletions(-)
> >
> > diff --git a/arch/m68k/coldfire/m5441x.c b/arch/m68k/coldfire/m5441x.c
> > index dc589b039b62..04fd7fde9fb3 100644
> > --- a/arch/m68k/coldfire/m5441x.c
> > +++ b/arch/m68k/coldfire/m5441x.c
> > @@ -222,40 +222,3 @@ void __init config_BSP(char *commandp, int size)
> > m5441x_uarts_init();
> > m5441x_fec_init();
> > }
> > -
> > -
> > -#if IS_ENABLED(CONFIG_RTC_DRV_M5441x)
> > -static struct resource m5441x_rtc_resources[] = {
> > - {
> > - .start = MCFRTC_BASE,
> > - .end = MCFRTC_BASE + MCFRTC_SIZE - 1,
> > - .flags = IORESOURCE_MEM,
> > - },
> > - {
> > - .start = MCF_IRQ_RTC,
> > - .end = MCF_IRQ_RTC,
> > - .flags = IORESOURCE_IRQ,
> > - },
> > -};
> > -
> > -static struct platform_device m5441x_rtc = {
> > - .name = "mcfrtc",
> > - .id = 0,
> > - .resource = m5441x_rtc_resources,
> > - .num_resources = ARRAY_SIZE(m5441x_rtc_resources),
> > -};
> > -#endif
> > -
> > -static struct platform_device *m5441x_devices[] __initdata = {
> > -#if IS_ENABLED(CONFIG_RTC_DRV_M5441x)
> > - &m5441x_rtc,
> > -#endif
> > -};
> > -
> > -static int __init init_BSP(void)
> > -{
> > - platform_add_devices(m5441x_devices, ARRAY_SIZE(m5441x_devices));
> > - return 0;
> > -}
> > -
> > -arch_initcall(init_BSP);
> >
>
> Regards,
> Angelo
--
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
[toc] | [prev] | [next] | [standalone]
| From | Steven King <sfking@fdwdc.com> |
|---|---|
| Date | 2017-08-27 22:00 +0200 |
| Message-ID | <ujbSV-3Kt-7@gated-at.bofh.it> |
| In reply to | #1720910 |
On Sunday 27 August 2017 12:09:59 pm Alexandre Belloni wrote: > On 27/08/2017 at 13:22:09 +0200, Angelo Dureghello wrote: > > Hi, > > > > just to inform you that i have in mind to add spi(soon, at least seems > > just a matter con Kconfig changes) and usdhc(later) > > drivers/support for stmark2 mcf5441x based board. > > But no problem, in case i'll re-add the this code as needed. > > I think it is easy enough to reintroduce init_BSP with your patch. It is > unfortunate that this useless function stayed that way so long, waiting > for a real user :) I believe I was the original author, I dont remember why the code wasn't merged. I still have the branch, if some wants to take it over and see it gets merged I wouldn't have any objections ;-)
[toc] | [prev] | [next] | [standalone]
| From | Alexandre Belloni <alexandre.belloni@free-electrons.com> |
|---|---|
| Date | 2017-08-27 23:20 +0200 |
| Message-ID | <ujd8l-4Nb-9@gated-at.bofh.it> |
| In reply to | #1720917 |
On 27/08/2017 at 12:36:31 -0700, Steven King wrote: > On Sunday 27 August 2017 12:09:59 pm Alexandre Belloni wrote: > > On 27/08/2017 at 13:22:09 +0200, Angelo Dureghello wrote: > > > Hi, > > > > > > just to inform you that i have in mind to add spi(soon, at least seems > > > just a matter con Kconfig changes) and usdhc(later) > > > drivers/support for stmark2 mcf5441x based board. > > > But no problem, in case i'll re-add the this code as needed. > > > > I think it is easy enough to reintroduce init_BSP with your patch. It is > > unfortunate that this useless function stayed that way so long, waiting > > for a real user :) > > I believe I was the original author, I dont remember why the code wasn't > merged. I still have the branch, if some wants to take it over and see it > gets merged I wouldn't have any objections ;-) There were comments from Geert that were not addressed: http://patchwork.ozlabs.org/patch/165328/ -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web