Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1721846 > unrolled thread

[PATCH] fpga: make xlnx_pr_decoupler_br_ops const

Back to article view | Back to linux.kernel

Contents

  [PATCH] fpga: make xlnx_pr_decoupler_br_ops const Bhumika Goyal <bhumirks@gmail.com> - 2017-08-28 19:40 +0200
    Re: [PATCH] fpga: make xlnx_pr_decoupler_br_ops const Moritz Fischer <moritz.fischer@ettus.com> - 2017-08-29 18:10 +0200

#1721846 — [PATCH] fpga: make xlnx_pr_decoupler_br_ops const

Make this const as it is only passed to a const argument of the function
fpga_bridge_register.

Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
---
 drivers/fpga/xilinx-pr-decoupler.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/fpga/xilinx-pr-decoupler.c b/drivers/fpga/xilinx-pr-decoupler.c
index e359930..0d77430 100644
--- a/drivers/fpga/xilinx-pr-decoupler.c
+++ b/drivers/fpga/xilinx-pr-decoupler.c
@@ -79,7 +79,7 @@ static int xlnx_pr_decoupler_enable_show(struct fpga_bridge *bridge)
 	return !status;
 }
 
-static struct fpga_bridge_ops xlnx_pr_decoupler_br_ops = {
+static const struct fpga_bridge_ops xlnx_pr_decoupler_br_ops = {
 	.enable_set = xlnx_pr_decoupler_enable_set,
 	.enable_show = xlnx_pr_decoupler_enable_show,
 };
-- 
1.9.1

[toc] | [next] | [standalone]

#1722587

On Tue, Aug 29, 2017 at 12:00 AM, Michal Simek <michal.simek@xilinx.com> wrote:
> On 28.8.2017 19:32, Bhumika Goyal wrote:
>> Make this const as it is only passed to a const argument of the function
>> fpga_bridge_register.
>>
>> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>

Acked-by: Moritz Fischer <mdf@kernel.org>
>> ---
>>  drivers/fpga/xilinx-pr-decoupler.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/fpga/xilinx-pr-decoupler.c b/drivers/fpga/xilinx-pr-decoupler.c
>> index e359930..0d77430 100644
>> --- a/drivers/fpga/xilinx-pr-decoupler.c
>> +++ b/drivers/fpga/xilinx-pr-decoupler.c
>> @@ -79,7 +79,7 @@ static int xlnx_pr_decoupler_enable_show(struct fpga_bridge *bridge)
>>       return !status;
>>  }
>>
>> -static struct fpga_bridge_ops xlnx_pr_decoupler_br_ops = {
>> +static const struct fpga_bridge_ops xlnx_pr_decoupler_br_ops = {
>>       .enable_set = xlnx_pr_decoupler_enable_set,
>>       .enable_show = xlnx_pr_decoupler_enable_show,
>>  };

Must've been a leftover from when I worked on integrating a simple
GPIO based one.
I'll have to rebase that and submit it.
>>
>
> Acked-by: Michal Simek <michal.simek@xilinx.com>
>
> Thanks,
> Michal
> --
> To unsubscribe from this list: send the line "unsubscribe linux-fpga" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Thanks,
Moritz

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web