Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1722057 > unrolled thread
| Started by | Jonathan Whitaker <jon.b.whitaker@gmail.com> |
|---|---|
| First post | 2017-08-29 01:40 +0200 |
| Last post | 2017-08-29 08:30 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] Staging: ks7010: Fix hardcoded function names in strings. Warnings reported by checkpatch.pl. Jonathan Whitaker <jon.b.whitaker@gmail.com> - 2017-08-29 01:40 +0200
Re: [PATCH] Staging: ks7010: Fix hardcoded function names in strings. Warnings reported by checkpatch.pl. Greg KH <gregkh@linuxfoundation.org> - 2017-08-29 08:30 +0200
| From | Jonathan Whitaker <jon.b.whitaker@gmail.com> |
|---|---|
| Date | 2017-08-29 01:40 +0200 |
| Subject | [PATCH] Staging: ks7010: Fix hardcoded function names in strings. Warnings reported by checkpatch.pl. |
| Message-ID | <ujBNn-3pw-7@gated-at.bofh.it> |
This commit replaces hardcoded function name strings to the more preferred '"%s...", __func__' style. These warnings were reported by checkpatch.pl. Signed-off-by: Jonathan Whitaker <jon.b.whitaker@gmail.com> --- drivers/staging/ks7010/ks7010_sdio.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/ks7010/ks7010_sdio.c b/drivers/staging/ks7010/ks7010_sdio.c index 9b28ee1..c0e91c3 100644 --- a/drivers/staging/ks7010/ks7010_sdio.c +++ b/drivers/staging/ks7010/ks7010_sdio.c @@ -834,7 +834,7 @@ static int ks7010_sdio_probe(struct sdio_func *func, unsigned char byte; int ret; - DPRINTK(5, "ks7010_sdio_probe()\n"); + DPRINTK(5, "%s()\n", __func__); priv = NULL; netdev = NULL; @@ -1008,7 +1008,7 @@ static void ks7010_sdio_remove(struct sdio_func *func) struct ks_sdio_card *card; struct ks_wlan_private *priv; - DPRINTK(1, "ks7010_sdio_remove()\n"); + DPRINTK(1, "%s()\n", __func__); card = sdio_get_drvdata(func); -- 2.7.4
[toc] | [next] | [standalone]
| From | Greg KH <gregkh@linuxfoundation.org> |
|---|---|
| Date | 2017-08-29 08:30 +0200 |
| Subject | Re: [PATCH] Staging: ks7010: Fix hardcoded function names in strings. Warnings reported by checkpatch.pl. |
| Message-ID | <ujIcb-7vX-33@gated-at.bofh.it> |
| In reply to | #1722057 |
On Mon, Aug 28, 2017 at 05:32:39PM -0600, Jonathan Whitaker wrote: > This commit replaces hardcoded function name strings to the more preferred '"%s...", __func__' > style. These warnings were reported by checkpatch.pl. Please wrap your changelog text at 72 columns. And your subject is very odd, please fix that up as well. > > Signed-off-by: Jonathan Whitaker <jon.b.whitaker@gmail.com> > --- > drivers/staging/ks7010/ks7010_sdio.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/ks7010/ks7010_sdio.c b/drivers/staging/ks7010/ks7010_sdio.c > index 9b28ee1..c0e91c3 100644 > --- a/drivers/staging/ks7010/ks7010_sdio.c > +++ b/drivers/staging/ks7010/ks7010_sdio.c > @@ -834,7 +834,7 @@ static int ks7010_sdio_probe(struct sdio_func *func, > unsigned char byte; > int ret; > > - DPRINTK(5, "ks7010_sdio_probe()\n"); > + DPRINTK(5, "%s()\n", __func__); > > priv = NULL; > netdev = NULL; > @@ -1008,7 +1008,7 @@ static void ks7010_sdio_remove(struct sdio_func *func) > struct ks_sdio_card *card; > struct ks_wlan_private *priv; > > - DPRINTK(1, "ks7010_sdio_remove()\n"); > + DPRINTK(1, "%s()\n", __func__); These lines can just be deleted entirely, we have in-kernel functionality for tracing kernel function calls, no need to have special debug lines just for that. thanks, greg k-h
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web