Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1721609 > unrolled thread

[PATCH net-next] hinic: don't build the module by default

Started byVitaly Kuznetsov <vkuznets@redhat.com>
First post2017-08-28 15:20 +0200
Last post2017-08-29 06:50 +0200
Articles 2 — 2 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH net-next] hinic: don't build the module by default Vitaly Kuznetsov <vkuznets@redhat.com> - 2017-08-28 15:20 +0200
    Re: [PATCH net-next] hinic: don't build the module by default David Miller <davem@davemloft.net> - 2017-08-29 06:50 +0200

#1721609 — [PATCH net-next] hinic: don't build the module by default

FromVitaly Kuznetsov <vkuznets@redhat.com>
Date2017-08-28 15:20 +0200
Subject[PATCH net-next] hinic: don't build the module by default
Message-ID<ujs7n-62E-3@gated-at.bofh.it>
We probably don't want to enable code supporting particular hardware by
default e.g. when someone does 'make defconfig'. Other ethernet modules
don't do it.

Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>
---
 drivers/net/ethernet/huawei/hinic/Kconfig | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/net/ethernet/huawei/hinic/Kconfig b/drivers/net/ethernet/huawei/hinic/Kconfig
index 69f2b1fba48d..08db24954f7e 100644
--- a/drivers/net/ethernet/huawei/hinic/Kconfig
+++ b/drivers/net/ethernet/huawei/hinic/Kconfig
@@ -5,7 +5,6 @@
 config HINIC
 	tristate "Huawei Intelligent PCIE Network Interface Card"
 	depends on (PCI_MSI && X86)
-	default m
 	---help---
 	  This driver supports HiNIC PCIE Ethernet cards.
 	  To compile this driver as part of the kernel, choose Y here.
-- 
2.13.5

[toc] | [next] | [standalone]


#1722138

FromDavid Miller <davem@davemloft.net>
Date2017-08-29 06:50 +0200
Message-ID<ujGDo-6rm-9@gated-at.bofh.it>
In reply to#1721609
From: Vitaly Kuznetsov <vkuznets@redhat.com>
Date: Mon, 28 Aug 2017 15:16:05 +0200

> We probably don't want to enable code supporting particular hardware by
> default e.g. when someone does 'make defconfig'. Other ethernet modules
> don't do it.
> 
> Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>

Applied, thanks.

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web