Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1720639 > unrolled thread
| Started by | Arvind Yadav <arvind.yadav.cs@gmail.com> |
|---|---|
| First post | 2017-08-26 13:30 +0200 |
| Last post | 2017-08-29 00:50 +0200 |
| Articles | 4 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] sparc: leon: grpci2: constify of_device_id Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-26 13:30 +0200
[PATCH] sparc: leon: grpci1: constify of_device_id Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-26 13:30 +0200
Re: [PATCH] sparc: leon: grpci1: constify of_device_id David Miller <davem@davemloft.net> - 2017-08-29 00:50 +0200
Re: [PATCH] sparc: leon: grpci2: constify of_device_id David Miller <davem@davemloft.net> - 2017-08-29 00:50 +0200
| From | Arvind Yadav <arvind.yadav.cs@gmail.com> |
|---|---|
| Date | 2017-08-26 13:30 +0200 |
| Subject | [PATCH] sparc: leon: grpci2: constify of_device_id |
| Message-ID | <uiHrQ-yx-11@gated-at.bofh.it> |
of_device_id are not supposed to change at runtime. All functions
working with of_device_id provided by <linux/of.h> work with const
of_device_ids. So mark the const and __initconst.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
arch/sparc/kernel/leon_pci_grpci2.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/sparc/kernel/leon_pci_grpci2.c b/arch/sparc/kernel/leon_pci_grpci2.c
index f727c4d..ff0e5c9 100644
--- a/arch/sparc/kernel/leon_pci_grpci2.c
+++ b/arch/sparc/kernel/leon_pci_grpci2.c
@@ -886,7 +886,7 @@ static int grpci2_of_probe(struct platform_device *ofdev)
return err;
}
-static struct of_device_id grpci2_of_match[] = {
+static const struct of_device_id grpci2_of_match[] __initconst = {
{
.name = "GAISLER_GRPCI2",
},
--
2.7.4
[toc] | [next] | [standalone]
| From | Arvind Yadav <arvind.yadav.cs@gmail.com> |
|---|---|
| Date | 2017-08-26 13:30 +0200 |
| Subject | [PATCH] sparc: leon: grpci1: constify of_device_id |
| Message-ID | <uiHrQ-yx-13@gated-at.bofh.it> |
| In reply to | #1720639 |
of_device_id are not supposed to change at runtime. All functions
working with of_device_id provided by <linux/of.h> work with const
of_device_ids. So mark the const and __initconst.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
arch/sparc/kernel/leon_pci_grpci1.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/sparc/kernel/leon_pci_grpci1.c b/arch/sparc/kernel/leon_pci_grpci1.c
index 1e77128..c5fc762 100644
--- a/arch/sparc/kernel/leon_pci_grpci1.c
+++ b/arch/sparc/kernel/leon_pci_grpci1.c
@@ -695,7 +695,7 @@ static int grpci1_of_probe(struct platform_device *ofdev)
return err;
}
-static struct of_device_id grpci1_of_match[] = {
+static const struct of_device_id grpci1_of_match[] __initconst = {
{
.name = "GAISLER_PCIFBRG",
},
--
2.7.4
[toc] | [prev] | [next] | [standalone]
| From | David Miller <davem@davemloft.net> |
|---|---|
| Date | 2017-08-29 00:50 +0200 |
| Subject | Re: [PATCH] sparc: leon: grpci1: constify of_device_id |
| Message-ID | <ujB0Z-2TO-7@gated-at.bofh.it> |
| In reply to | #1720640 |
From: Arvind Yadav <arvind.yadav.cs@gmail.com> Date: Sat, 26 Aug 2017 16:58:48 +0530 > of_device_id are not supposed to change at runtime. All functions > working with of_device_id provided by <linux/of.h> work with const > of_device_ids. So mark the const and __initconst. > > Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com> Applied.
[toc] | [prev] | [next] | [standalone]
| From | David Miller <davem@davemloft.net> |
|---|---|
| Date | 2017-08-29 00:50 +0200 |
| Message-ID | <ujB0Z-2TO-3@gated-at.bofh.it> |
| In reply to | #1720639 |
From: Arvind Yadav <arvind.yadav.cs@gmail.com> Date: Sat, 26 Aug 2017 16:58:34 +0530 > of_device_id are not supposed to change at runtime. All functions > working with of_device_id provided by <linux/of.h> work with const > of_device_ids. So mark the const and __initconst. > > Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com> Applied.
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web