Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1720833 > unrolled thread

Re: [PATCH resend] thunderbolt: Fix reset response_type

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH resend] thunderbolt: Fix reset response_type Mika Westerberg <mika.westerberg@linux.intel.com> - 2017-08-27 15:50 +0200

#1720833 — Re: [PATCH resend] thunderbolt: Fix reset response_type

On Wed, Aug 16, 2017 at 11:54:17AM +0300, Dan Carpenter wrote:
> There is a mistake here where we accidentally use sizeof(TB_CFG_PKG_RESET)
> instead of just TB_CFG_PKG_RESET.  The size of an int is 4 so it's the
> same as TB_CFG_PKG_NOTIFY_ACK.
> 
> Fixes: d7f781bfdbf4 ("thunderbolt: Rework control channel to be more reliable")
> Reported-by: Colin King <colin.king@canonical.com>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
> ---
> Resending with Greg CC'd.  This was also:
> Signed-off-by: Andreas Noever <andreas.noever@gmail.com>
> But I wasn't sure if I should add that tag.

Hi Greg,

Can you pick this fix to your char-misc tree?

Thanks!

[toc] | [standalone]

Back to top | Article view | linux.kernel

csiph-web