Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1720104 > unrolled thread

[PATCH 0/7] net: make some structures const

Back to article view | Back to linux.kernel

Contents

  [PATCH 0/7] net: make some structures const Bhumika Goyal <bhumirks@gmail.com> - 2017-08-25 16:30 +0200
    [PATCH 2/7] bridge: make ebt_table const Bhumika Goyal <bhumirks@gmail.com> - 2017-08-25 16:30 +0200
      Re: [PATCH 2/7] bridge: make ebt_table const David Miller <davem@davemloft.net> - 2017-08-28 20:40 +0200
    [PATCH 7/7] SUNRPC: make kvec const Bhumika Goyal <bhumirks@gmail.com> - 2017-08-25 16:30 +0200
      Re: [PATCH 7/7] SUNRPC: make kvec const Jeff Layton <jlayton@redhat.com> - 2017-08-25 16:50 +0200
    [PATCH 5/7] RDS: make rhashtable_params const Bhumika Goyal <bhumirks@gmail.com> - 2017-08-25 16:30 +0200
      Re: [PATCH 5/7] RDS: make rhashtable_params const Santosh Shilimkar <santosh.shilimkar@oracle.com> - 2017-08-25 17:40 +0200
      Re: [PATCH 5/7] RDS: make rhashtable_params const David Miller <davem@davemloft.net> - 2017-08-28 20:40 +0200
    [PATCH 6/7] netfilter: nat: make rhashtable_params const Bhumika Goyal <bhumirks@gmail.com> - 2017-08-25 16:30 +0200
    [PATCH 1/7] Bluetooth: 6lowpan: make header_ops const Bhumika Goyal <bhumirks@gmail.com> - 2017-08-25 16:30 +0200
    [PATCH 3/7] ieee802154: 6lowpan: make header_ops const Bhumika Goyal <bhumirks@gmail.com> - 2017-08-25 16:30 +0200
      Re: [PATCH 3/7] ieee802154: 6lowpan: make header_ops const Stefan Schmidt <stefan@osg.samsung.com> - 2017-08-25 16:40 +0200
      Re: [PATCH 3/7] ieee802154: 6lowpan: make header_ops const Marcel Holtmann <marcel@holtmann.org> - 2017-08-25 18:20 +0200
    [PATCH 4/7] ipv4: make net_protocol const Bhumika Goyal <bhumirks@gmail.com> - 2017-08-25 16:30 +0200
      Re: [PATCH 4/7] ipv4: make net_protocol const David Miller <davem@davemloft.net> - 2017-08-28 20:40 +0200

#1720104 — [PATCH 0/7] net: make some structures const

Make these const as they are not modified.

Bhumika Goyal (7):
  Bluetooth: 6lowpan: make header_ops const
  bridge: make ebt_table const
  ieee802154: 6lowpan: make header_ops const
  ipv4: make net_protocol const
  RDS: make rhashtable_params const
  netfilter: nat: make rhashtable_params const
  SUNRPC: make kvec const

 net/bluetooth/6lowpan.c            | 2 +-
 net/bridge/netfilter/ebtable_nat.c | 2 +-
 net/ieee802154/6lowpan/core.c      | 2 +-
 net/ipv4/af_inet.c                 | 4 ++--
 net/netfilter/nf_nat_core.c        | 2 +-
 net/rds/bind.c                     | 2 +-
 net/sunrpc/xdr.c                   | 2 +-
 7 files changed, 8 insertions(+), 8 deletions(-)

-- 
1.9.1

[toc] | [next] | [standalone]

#1720105 — [PATCH 2/7] bridge: make ebt_table const

Make this const as it is only passed to a const argument of the function
ebt_register_table.

Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
---
 net/bridge/netfilter/ebtable_nat.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/bridge/netfilter/ebtable_nat.c b/net/bridge/netfilter/ebtable_nat.c
index 4ecf506..57cd5bb 100644
--- a/net/bridge/netfilter/ebtable_nat.c
+++ b/net/bridge/netfilter/ebtable_nat.c
@@ -48,7 +48,7 @@ static int check(const struct ebt_table_info *info, unsigned int valid_hooks)
 	return 0;
 }
 
-static struct ebt_table frame_nat = {
+static const struct ebt_table frame_nat = {
 	.name		= "nat",
 	.table		= &initial_table,
 	.valid_hooks	= NAT_VALID_HOOKS,
-- 
1.9.1

[toc] | [prev] | [next] | [standalone]

#1721895 — Re: [PATCH 2/7] bridge: make ebt_table const

From: Bhumika Goyal <bhumirks@gmail.com>
Date: Fri, 25 Aug 2017 19:51:42 +0530

> Make this const as it is only passed to a const argument of the function
> ebt_register_table.
> 
> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>

Applied.

[toc] | [prev] | [next] | [standalone]

#1720107 — [PATCH 7/7] SUNRPC: make kvec const

Make this const as it is only used during a copy operation.

Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
---
 net/sunrpc/xdr.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/sunrpc/xdr.c b/net/sunrpc/xdr.c
index e34f4ee..a096025 100644
--- a/net/sunrpc/xdr.c
+++ b/net/sunrpc/xdr.c
@@ -998,7 +998,7 @@ void xdr_enter_page(struct xdr_stream *xdr, unsigned int len)
 }
 EXPORT_SYMBOL_GPL(xdr_enter_page);
 
-static struct kvec empty_iov = {.iov_base = NULL, .iov_len = 0};
+static const struct kvec empty_iov = {.iov_base = NULL, .iov_len = 0};
 
 void
 xdr_buf_from_iov(struct kvec *iov, struct xdr_buf *buf)
-- 
1.9.1

[toc] | [prev] | [next] | [standalone]

#1720139 — Re: [PATCH 7/7] SUNRPC: make kvec const

On Fri, 2017-08-25 at 19:51 +0530, Bhumika Goyal wrote:
> Make this const as it is only used during a copy operation.
> 
> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
> ---
>  net/sunrpc/xdr.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/sunrpc/xdr.c b/net/sunrpc/xdr.c
> index e34f4ee..a096025 100644
> --- a/net/sunrpc/xdr.c
> +++ b/net/sunrpc/xdr.c
> @@ -998,7 +998,7 @@ void xdr_enter_page(struct xdr_stream *xdr, unsigned int len)
>  }
>  EXPORT_SYMBOL_GPL(xdr_enter_page);
>  
> -static struct kvec empty_iov = {.iov_base = NULL, .iov_len = 0};
> +static const struct kvec empty_iov = {.iov_base = NULL, .iov_len = 0};
>  
>  void
>  xdr_buf_from_iov(struct kvec *iov, struct xdr_buf *buf)

Reviewed-by: Jeff Layton <jlayton@redhat.com>

[toc] | [prev] | [next] | [standalone]

#1720108 — [PATCH 5/7] RDS: make rhashtable_params const

Make this const as it is either used during a copy operation or passed
to a const argument of the function rhltable_init

Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
---
 net/rds/bind.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/rds/bind.c b/net/rds/bind.c
index 3a915be..75d43dc 100644
--- a/net/rds/bind.c
+++ b/net/rds/bind.c
@@ -40,7 +40,7 @@
 
 static struct rhashtable bind_hash_table;
 
-static struct rhashtable_params ht_parms = {
+static const struct rhashtable_params ht_parms = {
 	.nelem_hint = 768,
 	.key_len = sizeof(u64),
 	.key_offset = offsetof(struct rds_sock, rs_bound_key),
-- 
1.9.1

[toc] | [prev] | [next] | [standalone]

#1720194 — Re: [PATCH 5/7] RDS: make rhashtable_params const

8/25/2017 7:21 AM, Bhumika Goyal wrote:
> Make this const as it is either used during a copy operation or passed
> to a const argument of the function rhltable_init
> 
> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
> ---
Acked-by: Santosh Shilimkar <santosh.shilimkar@oracle.com>

[toc] | [prev] | [next] | [standalone]

#1721898 — Re: [PATCH 5/7] RDS: make rhashtable_params const

From: Bhumika Goyal <bhumirks@gmail.com>
Date: Fri, 25 Aug 2017 19:51:45 +0530

> Make this const as it is either used during a copy operation or passed
> to a const argument of the function rhltable_init
> 
> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>

Applied.

[toc] | [prev] | [next] | [standalone]

#1720109 — [PATCH 6/7] netfilter: nat: make rhashtable_params const

Make this const as it is either used during a copy operation or passed
to a const argument of the function rhltable_init.

Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
---
 net/netfilter/nf_nat_core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/netfilter/nf_nat_core.c b/net/netfilter/nf_nat_core.c
index b1d3740..df983ea 100644
--- a/net/netfilter/nf_nat_core.c
+++ b/net/netfilter/nf_nat_core.c
@@ -198,7 +198,7 @@ static int nf_nat_bysource_cmp(struct rhashtable_compare_arg *arg,
 	return 0;
 }
 
-static struct rhashtable_params nf_nat_bysource_params = {
+static const struct rhashtable_params nf_nat_bysource_params = {
 	.head_offset = offsetof(struct nf_conn, nat_bysource),
 	.obj_hashfn = nf_nat_bysource_hash,
 	.obj_cmpfn = nf_nat_bysource_cmp,
-- 
1.9.1

[toc] | [prev] | [next] | [standalone]

#1720111 — [PATCH 1/7] Bluetooth: 6lowpan: make header_ops const

Make this const as it is only stored as a reference in a const field of
a net_device structure.

Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
---
 net/bluetooth/6lowpan.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/bluetooth/6lowpan.c b/net/bluetooth/6lowpan.c
index 4e2576f..50fcdd1 100644
--- a/net/bluetooth/6lowpan.c
+++ b/net/bluetooth/6lowpan.c
@@ -581,7 +581,7 @@ static int bt_dev_init(struct net_device *dev)
 	.ndo_start_xmit		= bt_xmit,
 };
 
-static struct header_ops header_ops = {
+static const struct header_ops header_ops = {
 	.create	= header_create,
 };
 
-- 
1.9.1

[toc] | [prev] | [next] | [standalone]

#1720114 — [PATCH 3/7] ieee802154: 6lowpan: make header_ops const

Make this const as it is only stored as a reference in a const field of
a net_device structure.

Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
---
 net/ieee802154/6lowpan/core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/ieee802154/6lowpan/core.c b/net/ieee802154/6lowpan/core.c
index de2661c..974765b 100644
--- a/net/ieee802154/6lowpan/core.c
+++ b/net/ieee802154/6lowpan/core.c
@@ -54,7 +54,7 @@
 
 static int open_count;
 
-static struct header_ops lowpan_header_ops = {
+static const struct header_ops lowpan_header_ops = {
 	.create	= lowpan_header_create,
 };
 
-- 
1.9.1

[toc] | [prev] | [next] | [standalone]

#1720126 — Re: [PATCH 3/7] ieee802154: 6lowpan: make header_ops const

Hello.

On 08/25/2017 04:21 PM, Bhumika Goyal wrote:
> Make this const as it is only stored as a reference in a const field of
> a net_device structure.
> 
> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
> ---
>   net/ieee802154/6lowpan/core.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/ieee802154/6lowpan/core.c b/net/ieee802154/6lowpan/core.c
> index de2661c..974765b 100644
> --- a/net/ieee802154/6lowpan/core.c
> +++ b/net/ieee802154/6lowpan/core.c
> @@ -54,7 +54,7 @@
>   
>   static int open_count;
>   
> -static struct header_ops lowpan_header_ops = {
> +static const struct header_ops lowpan_header_ops = {
>   	.create	= lowpan_header_create,
>   };
>   
> 

Acked-by: Stefan Schmidt <stefan@osg.samsung.com>

regards
Stefan Schmidt

[toc] | [prev] | [next] | [standalone]

#1720239 — Re: [PATCH 3/7] ieee802154: 6lowpan: make header_ops const

Hi Bhumika,

> Make this const as it is only stored as a reference in a const field of
> a net_device structure.
> 
> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
> ---
> net/ieee802154/6lowpan/core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

patch has been applied to bluetooth-next tree.

Regards

Marcel

[toc] | [prev] | [next] | [standalone]

#1720115 — [PATCH 4/7] ipv4: make net_protocol const

Make these const as they are only passed to a const argument of the
function inet_add_protocol.

Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
---
 net/ipv4/af_inet.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/net/ipv4/af_inet.c b/net/ipv4/af_inet.c
index d678820..19aee07 100644
--- a/net/ipv4/af_inet.c
+++ b/net/ipv4/af_inet.c
@@ -1596,7 +1596,7 @@ u64 snmp_fold_field64(void __percpu *mib, int offt, size_t syncp_offset)
 };
 #endif
 
-static struct net_protocol tcp_protocol = {
+static const struct net_protocol tcp_protocol = {
 	.early_demux	=	tcp_v4_early_demux,
 	.early_demux_handler =  tcp_v4_early_demux,
 	.handler	=	tcp_v4_rcv,
@@ -1606,7 +1606,7 @@ u64 snmp_fold_field64(void __percpu *mib, int offt, size_t syncp_offset)
 	.icmp_strict_tag_validation = 1,
 };
 
-static struct net_protocol udp_protocol = {
+static const struct net_protocol udp_protocol = {
 	.early_demux =	udp_v4_early_demux,
 	.early_demux_handler =	udp_v4_early_demux,
 	.handler =	udp_rcv,
-- 
1.9.1

[toc] | [prev] | [next] | [standalone]

#1721892 — Re: [PATCH 4/7] ipv4: make net_protocol const

From: Bhumika Goyal <bhumirks@gmail.com>
Date: Fri, 25 Aug 2017 19:51:44 +0530

> Make these const as they are only passed to a const argument of the
> function inet_add_protocol.
> 
> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>

Applied.

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web