Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1716677 > unrolled thread
| Started by | Jerome Brunet <jbrunet@baylibre.com> |
|---|---|
| First post | 2017-08-21 18:10 +0200 |
| Last post | 2017-08-25 02:10 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH v2 15/16] mmc: meson-gx: change default tx phase Jerome Brunet <jbrunet@baylibre.com> - 2017-08-21 18:10 +0200
Re: [PATCH v2 15/16] mmc: meson-gx: change default tx phase Kevin Hilman <khilman@baylibre.com> - 2017-08-25 02:10 +0200
| From | Jerome Brunet <jbrunet@baylibre.com> |
|---|---|
| Date | 2017-08-21 18:10 +0200 |
| Subject | [PATCH v2 15/16] mmc: meson-gx: change default tx phase |
| Message-ID | <ugXr6-6yO-85@gated-at.bofh.it> |
Initial default tx phase was set to 0 while the datasheet recommends 270. Some cards fails to initialize with this setting and eMMC mode DDR52 does not work. Changing this setting to 270 fixes these issues, without any regression so far Signed-off-by: Jerome Brunet <jbrunet@baylibre.com> --- drivers/mmc/host/meson-gx-mmc.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/mmc/host/meson-gx-mmc.c b/drivers/mmc/host/meson-gx-mmc.c index 3167f561e1a6..290631d46a4b 100644 --- a/drivers/mmc/host/meson-gx-mmc.c +++ b/drivers/mmc/host/meson-gx-mmc.c @@ -1158,8 +1158,14 @@ static int meson_mmc_probe(struct platform_device *pdev) if (ret) goto free_host; + /* + * Set phases : These values are mostly the datasheet recommended ones + * except for the Tx phase. Datasheet recommends 180 but some cards + * fail at initialisation with it. 270 works just fine, it fixes these + * initialisation issues and enable eMMC DDR52 mode. + */ host->tp.core_phase = 180; - host->tp.tx_phase = 0; + host->tp.tx_phase = 270; host->tp.rx_phase = 0; ret = meson_mmc_clk_init(host); -- 2.9.5
[toc] | [next] | [standalone]
| From | Kevin Hilman <khilman@baylibre.com> |
|---|---|
| Date | 2017-08-25 02:10 +0200 |
| Message-ID | <uiame-5bk-9@gated-at.bofh.it> |
| In reply to | #1716677 |
Jerome Brunet <jbrunet@baylibre.com> writes: > Initial default tx phase was set to 0 while the datasheet recommends 270. > Some cards fails to initialize with this setting and eMMC mode DDR52 does > not work. > > Changing this setting to 270 fixes these issues, without any regression > so far > > Signed-off-by: Jerome Brunet <jbrunet@baylibre.com> Reviewed-by: Kevin Hilman <khilman@baylibre.com>
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web