Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1720543 > unrolled thread
| Started by | Arvind Yadav <arvind.yadav.cs@gmail.com> |
|---|---|
| First post | 2017-08-26 08:30 +0200 |
| Last post | 2017-08-26 11:40 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] nfc: microread: mei: constify mei_cl_device_id Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-26 08:30 +0200
RE: [PATCH] nfc: microread: mei: constify mei_cl_device_id "Winkler, Tomas" <tomas.winkler@intel.com> - 2017-08-26 11:40 +0200
| From | Arvind Yadav <arvind.yadav.cs@gmail.com> |
|---|---|
| Date | 2017-08-26 08:30 +0200 |
| Subject | [PATCH] nfc: microread: mei: constify mei_cl_device_id |
| Message-ID | <uiCLv-680-7@gated-at.bofh.it> |
mei_cl_device_id are not supposed to change at runtime.
mei driver is working with const 'id_table'. So mark
the non-const mei_cl_device_id structs as const.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/nfc/microread/mei.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/nfc/microread/mei.c b/drivers/nfc/microread/mei.c
index eb5eddf..70bf7a1 100644
--- a/drivers/nfc/microread/mei.c
+++ b/drivers/nfc/microread/mei.c
@@ -66,7 +66,7 @@ static int microread_mei_remove(struct mei_cl_device *cldev)
return 0;
}
-static struct mei_cl_device_id microread_mei_tbl[] = {
+static const struct mei_cl_device_id microread_mei_tbl[] = {
{ MICROREAD_DRIVER_NAME, MEI_NFC_UUID, MEI_CL_VERSION_ANY},
/* required last entry */
--
2.7.4
[toc] | [next] | [standalone]
| From | "Winkler, Tomas" <tomas.winkler@intel.com> |
|---|---|
| Date | 2017-08-26 11:40 +0200 |
| Message-ID | <uiFJo-7SH-19@gated-at.bofh.it> |
| In reply to | #1720543 |
> mei_cl_device_id are not supposed to change at runtime.
> mei driver is working with const 'id_table'. So mark the non-const
> mei_cl_device_id structs as const.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Ack.
> drivers/nfc/microread/mei.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/nfc/microread/mei.c b/drivers/nfc/microread/mei.c index
> eb5eddf..70bf7a1 100644
> --- a/drivers/nfc/microread/mei.c
> +++ b/drivers/nfc/microread/mei.c
> @@ -66,7 +66,7 @@ static int microread_mei_remove(struct mei_cl_device
> *cldev)
> return 0;
> }
>
> -static struct mei_cl_device_id microread_mei_tbl[] = {
> +static const struct mei_cl_device_id microread_mei_tbl[] = {
> { MICROREAD_DRIVER_NAME, MEI_NFC_UUID,
> MEI_CL_VERSION_ANY},
>
> /* required last entry */
> --
> 2.7.4
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web