Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1719375 > unrolled thread
| Started by | Waiman Long <longman@redhat.com> |
|---|---|
| First post | 2017-08-24 18:10 +0200 |
| Last post | 2017-08-24 20:00 +0200 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] cpuset: Fix incorrect memory_pressure control file mapping Waiman Long <longman@redhat.com> - 2017-08-24 18:10 +0200
Re: [PATCH] cpuset: Fix incorrect memory_pressure control file mapping Tejun Heo <tj@kernel.org> - 2017-08-24 18:50 +0200
Re: [PATCH] cpuset: Fix incorrect memory_pressure control file mapping Waiman Long <longman@redhat.com> - 2017-08-24 20:00 +0200
| From | Waiman Long <longman@redhat.com> |
|---|---|
| Date | 2017-08-24 18:10 +0200 |
| Subject | [PATCH] cpuset: Fix incorrect memory_pressure control file mapping |
| Message-ID | <ui2RJ-kG-63@gated-at.bofh.it> |
The memory_pressure control file was incorrectly set up without
a private value (0, by default). As a result, this control
file was treated like memory_migrate on read. By adding back the
FILE_MEMORY_PRESSURE private value, the correct memory pressure value
will be returned.
Signed-off-by: Waiman Long <longman@redhat.com>
---
kernel/cgroup/cpuset.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/kernel/cgroup/cpuset.c b/kernel/cgroup/cpuset.c
index f3539a4..84ba237 100644
--- a/kernel/cgroup/cpuset.c
+++ b/kernel/cgroup/cpuset.c
@@ -1898,6 +1898,7 @@ static s64 cpuset_read_s64(struct cgroup_subsys_state *css, struct cftype *cft)
{
.name = "memory_pressure",
.read_u64 = cpuset_read_u64,
+ .private = FILE_MEMORY_PRESSURE,
},
{
--
1.8.3.1
[toc] | [next] | [standalone]
| From | Tejun Heo <tj@kernel.org> |
|---|---|
| Date | 2017-08-24 18:50 +0200 |
| Subject | Re: [PATCH] cpuset: Fix incorrect memory_pressure control file mapping |
| Message-ID | <ui3up-zR-5@gated-at.bofh.it> |
| In reply to | #1719375 |
On Thu, Aug 24, 2017 at 12:04:29PM -0400, Waiman Long wrote: > The memory_pressure control file was incorrectly set up without > a private value (0, by default). As a result, this control > file was treated like memory_migrate on read. By adding back the > FILE_MEMORY_PRESSURE private value, the correct memory pressure value > will be returned. > > Signed-off-by: Waiman Long <longman@redhat.com> Oops, applied to cgroup/for-4.13-fixes w/ stable cc'd. I broke it way back in v4.4 which makes me wonder whether anybody is actually using it. Thanks a lot for catching it. -- tejun
[toc] | [prev] | [next] | [standalone]
| From | Waiman Long <longman@redhat.com> |
|---|---|
| Date | 2017-08-24 20:00 +0200 |
| Subject | Re: [PATCH] cpuset: Fix incorrect memory_pressure control file mapping |
| Message-ID | <ui4Aa-1eO-13@gated-at.bofh.it> |
| In reply to | #1719423 |
On 08/24/2017 12:45 PM, Tejun Heo wrote: > On Thu, Aug 24, 2017 at 12:04:29PM -0400, Waiman Long wrote: >> The memory_pressure control file was incorrectly set up without >> a private value (0, by default). As a result, this control >> file was treated like memory_migrate on read. By adding back the >> FILE_MEMORY_PRESSURE private value, the correct memory pressure value >> will be returned. >> >> Signed-off-by: Waiman Long <longman@redhat.com> > Oops, applied to cgroup/for-4.13-fixes w/ stable cc'd. I broke it way > back in v4.4 which makes me wonder whether anybody is actually using > it. Probably not. Cheers, Longman
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web