Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1717177 > unrolled thread

[PATCH] net: mdio-gpio: make mdiobb_ops const

Back to article view | Back to linux.kernel

Contents

  [PATCH] net: mdio-gpio: make mdiobb_ops const Bhumika Goyal <bhumirks@gmail.com> - 2017-08-22 10:20 +0200
    Re: [PATCH] net: mdio-gpio: make mdiobb_ops const Andrew Lunn <andrew@lunn.ch> - 2017-08-22 15:20 +0200
    Re: [PATCH] net: mdio-gpio: make mdiobb_ops const David Miller <davem@davemloft.net> - 2017-08-22 23:30 +0200

#1717177 — [PATCH] net: mdio-gpio: make mdiobb_ops const

Make this const as it is only stored in a const field of a
mdiobb_ctrl structure.

Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
---
 drivers/net/phy/mdio-gpio.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/phy/mdio-gpio.c b/drivers/net/phy/mdio-gpio.c
index 7faa79b..4333c6e 100644
--- a/drivers/net/phy/mdio-gpio.c
+++ b/drivers/net/phy/mdio-gpio.c
@@ -116,7 +116,7 @@ static void mdc_set(struct mdiobb_ctrl *ctrl, int what)
 	gpiod_set_value(bitbang->mdc, what);
 }
 
-static struct mdiobb_ops mdio_gpio_ops = {
+static const struct mdiobb_ops mdio_gpio_ops = {
 	.owner = THIS_MODULE,
 	.set_mdc = mdc_set,
 	.set_mdio_dir = mdio_dir,
-- 
1.9.1

[toc] | [next] | [standalone]

#1717404

On Tue, Aug 22, 2017 at 01:43:29PM +0530, Bhumika Goyal wrote:
> Make this const as it is only stored in a const field of a
> mdiobb_ctrl structure.
> 
> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew

[toc] | [prev] | [next] | [standalone]

#1717847

From: Bhumika Goyal <bhumirks@gmail.com>
Date: Tue, 22 Aug 2017 13:43:29 +0530

> Make this const as it is only stored in a const field of a
> mdiobb_ctrl structure.
> 
> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>

Applied.

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web