Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1717817 > unrolled thread
| Started by | Bjorn Helgaas <helgaas@kernel.org> |
|---|---|
| First post | 2017-08-22 22:40 +0200 |
| Last post | 2017-08-22 23:10 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH] PCI: dwc: dra7xx: fix error return code in dra7xx_pcie_probe() Bjorn Helgaas <helgaas@kernel.org> - 2017-08-22 22:40 +0200
Re: [PATCH] PCI: dwc: dra7xx: fix error return code in dra7xx_pcie_probe() "Gustavo A. R. Silva" <gustavo@embeddedor.com> - 2017-08-22 23:10 +0200
| From | Bjorn Helgaas <helgaas@kernel.org> |
|---|---|
| Date | 2017-08-22 22:40 +0200 |
| Subject | Re: [PATCH] PCI: dwc: dra7xx: fix error return code in dra7xx_pcie_probe() |
| Message-ID | <uho7U-7sy-23@gated-at.bofh.it> |
On Wed, Aug 09, 2017 at 11:16:03AM -0500, Gustavo A. R. Silva wrote:
> platform_get_irq() returns an error code, but the pci-dra7xx driver
> ignores it and always returns -EINVAL. This is not correct and,
> prevents -EPROBE_DEFER from being propagated properly.
>
> Print and propagate the return value of platform_get_irq on failure.
>
> This issue was detected with the help of Coccinelle.
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Applied with Kishon's ack to pci/host-dra7xx for v4.14, thanks!
> ---
> drivers/pci/dwc/pci-dra7xx.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pci/dwc/pci-dra7xx.c b/drivers/pci/dwc/pci-dra7xx.c
> index f2fc5f4..f58e1b4 100644
> --- a/drivers/pci/dwc/pci-dra7xx.c
> +++ b/drivers/pci/dwc/pci-dra7xx.c
> @@ -616,8 +616,8 @@ static int __init dra7xx_pcie_probe(struct platform_device *pdev)
>
> irq = platform_get_irq(pdev, 0);
> if (irq < 0) {
> - dev_err(dev, "missing IRQ resource\n");
> - return -EINVAL;
> + dev_err(dev, "missing IRQ resource: %d\n", irq);
> + return irq;
> }
>
> res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "ti_conf");
> --
> 2.5.0
>
[toc] | [next] | [standalone]
| From | "Gustavo A. R. Silva" <gustavo@embeddedor.com> |
|---|---|
| Date | 2017-08-22 23:10 +0200 |
| Message-ID | <uhoAV-7V4-5@gated-at.bofh.it> |
| In reply to | #1717817 |
Hi Bjorn,
On 08/22/2017 03:37 PM, Bjorn Helgaas wrote:
> On Wed, Aug 09, 2017 at 11:16:03AM -0500, Gustavo A. R. Silva wrote:
>> platform_get_irq() returns an error code, but the pci-dra7xx driver
>> ignores it and always returns -EINVAL. This is not correct and,
>> prevents -EPROBE_DEFER from being propagated properly.
>>
>> Print and propagate the return value of platform_get_irq on failure.
>>
>> This issue was detected with the help of Coccinelle.
>>
>> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
>
> Applied with Kishon's ack to pci/host-dra7xx for v4.14, thanks!
>
Glad to help. :)
>> ---
>> drivers/pci/dwc/pci-dra7xx.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/pci/dwc/pci-dra7xx.c b/drivers/pci/dwc/pci-dra7xx.c
>> index f2fc5f4..f58e1b4 100644
>> --- a/drivers/pci/dwc/pci-dra7xx.c
>> +++ b/drivers/pci/dwc/pci-dra7xx.c
>> @@ -616,8 +616,8 @@ static int __init dra7xx_pcie_probe(struct platform_device *pdev)
>>
>> irq = platform_get_irq(pdev, 0);
>> if (irq < 0) {
>> - dev_err(dev, "missing IRQ resource\n");
>> - return -EINVAL;
>> + dev_err(dev, "missing IRQ resource: %d\n", irq);
>> + return irq;
>> }
>>
>> res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "ti_conf");
>> --
>> 2.5.0
>>
--
Gustavo A. R. Silva
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web