Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1713610 > unrolled thread

[PATCH] ARM: sun8i: a33: add dts for Q8 tablets with different resolution

Started byIcenowy Zheng <icenowy@aosc.io>
First post2017-08-17 09:50 +0200
Last post2017-08-22 22:40 +0200
Articles 4 — 3 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH] ARM: sun8i: a33: add dts for Q8 tablets with different resolution Icenowy Zheng <icenowy@aosc.io> - 2017-08-17 09:50 +0200
    Re: [PATCH] ARM: sun8i: a33: add dts for Q8 tablets with different  resolution Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-08-21 10:50 +0200
      Re: [PATCH] ARM: sun8i: a33: add dts for Q8 tablets with different  resolution icenowy@aosc.io - 2017-08-21 10:50 +0200
        Re: [PATCH] ARM: sun8i: a33: add dts for Q8 tablets with different  resolution Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-08-22 22:40 +0200

#1713610 — [PATCH] ARM: sun8i: a33: add dts for Q8 tablets with different resolution

FromIcenowy Zheng <icenowy@aosc.io>
Date2017-08-17 09:50 +0200
Subject[PATCH] ARM: sun8i: a33: add dts for Q8 tablets with different resolution
Message-ID<ufnJ1-1Il-27@gated-at.bofh.it>
Q8 tablets with Allwinner A33 SoC now come with two kind of LCD, either
800x480 or 1024x600.

In order for sun4i-drm to be able to choose correct LCD configuration,
two different device trees should be present, one for a resolution.

Add stub device trees for two resolutions.

As the sun4i-drm driver still has some problems to support the LCDs, the
real LCD device nodes are not added to the device tree files.

Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
---
 arch/arm/boot/dts/Makefile                         |  2 +
 arch/arm/boot/dts/sun8i-a33-q8-tablet-1024x600.dts | 49 ++++++++++++++++++++++
 arch/arm/boot/dts/sun8i-a33-q8-tablet-800x480.dts  | 49 ++++++++++++++++++++++
 3 files changed, 100 insertions(+)
 create mode 100644 arch/arm/boot/dts/sun8i-a33-q8-tablet-1024x600.dts
 create mode 100644 arch/arm/boot/dts/sun8i-a33-q8-tablet-800x480.dts

diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
index 570e107bf702..eeb9d9591cf0 100644
--- a/arch/arm/boot/dts/Makefile
+++ b/arch/arm/boot/dts/Makefile
@@ -908,6 +908,8 @@ dtb-$(CONFIG_MACH_SUN8I) += \
 	sun8i-a33-ippo-q8h-v1.2.dtb \
 	sun8i-a33-olinuxino.dtb \
 	sun8i-a33-q8-tablet.dtb \
+	sun8i-a33-q8-tablet-800x480.dtb \
+	sun8i-a33-q8-tablet-1024x600.dtb \
 	sun8i-a33-sinlinx-sina33.dtb \
 	sun8i-a83t-allwinner-h8homlet-v2.dtb \
 	sun8i-a83t-cubietruck-plus.dtb \
diff --git a/arch/arm/boot/dts/sun8i-a33-q8-tablet-1024x600.dts b/arch/arm/boot/dts/sun8i-a33-q8-tablet-1024x600.dts
new file mode 100644
index 000000000000..6f8ebd6c90ee
--- /dev/null
+++ b/arch/arm/boot/dts/sun8i-a33-q8-tablet-1024x600.dts
@@ -0,0 +1,49 @@
+/*
+ * Copyright 2017 Icenowy Zheng <icenowy@aosc.io>
+ *
+ * This file is dual-licensed: you can use it either under the terms
+ * of the GPL or the X11 license, at your option. Note that this dual
+ * licensing only applies to this file, and not this project as a
+ * whole.
+ *
+ *  a) This file is free software; you can redistribute it and/or
+ *     modify it under the terms of the GNU General Public License as
+ *     published by the Free Software Foundation; either version 2 of the
+ *     License, or (at your option) any later version.
+ *
+ *     This file is distributed in the hope that it will be useful,
+ *     but WITHOUT ANY WARRANTY; without even the implied warranty of
+ *     MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ *     GNU General Public License for more details.
+ *
+ * Or, alternatively,
+ *
+ *  b) Permission is hereby granted, free of charge, to any person
+ *     obtaining a copy of this software and associated documentation
+ *     files (the "Software"), to deal in the Software without
+ *     restriction, including without limitation the rights to use,
+ *     copy, modify, merge, publish, distribute, sublicense, and/or
+ *     sell copies of the Software, and to permit persons to whom the
+ *     Software is furnished to do so, subject to the following
+ *     conditions:
+ *
+ *     The above copyright notice and this permission notice shall be
+ *     included in all copies or substantial portions of the Software.
+ *
+ *     THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
+ *     EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
+ *     OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
+ *     NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
+ *     HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
+ *     WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+ *     FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
+ *     OTHER DEALINGS IN THE SOFTWARE.
+ */
+
+#include "sun8i-a33-q8-tablet.dts"
+
+/ {
+	model = "Q8 A33 Tablet with 1024x600 LCD";
+	compatible = "allwinner,q8-a33-1024x600", "allwinner,q8-a33",
+		     "allwinner,sun8i-a33";
+};
diff --git a/arch/arm/boot/dts/sun8i-a33-q8-tablet-800x480.dts b/arch/arm/boot/dts/sun8i-a33-q8-tablet-800x480.dts
new file mode 100644
index 000000000000..ad84b94dee53
--- /dev/null
+++ b/arch/arm/boot/dts/sun8i-a33-q8-tablet-800x480.dts
@@ -0,0 +1,49 @@
+/*
+ * Copyright 2017 Icenowy Zheng <icenowy@aosc.io>
+ *
+ * This file is dual-licensed: you can use it either under the terms
+ * of the GPL or the X11 license, at your option. Note that this dual
+ * licensing only applies to this file, and not this project as a
+ * whole.
+ *
+ *  a) This file is free software; you can redistribute it and/or
+ *     modify it under the terms of the GNU General Public License as
+ *     published by the Free Software Foundation; either version 2 of the
+ *     License, or (at your option) any later version.
+ *
+ *     This file is distributed in the hope that it will be useful,
+ *     but WITHOUT ANY WARRANTY; without even the implied warranty of
+ *     MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ *     GNU General Public License for more details.
+ *
+ * Or, alternatively,
+ *
+ *  b) Permission is hereby granted, free of charge, to any person
+ *     obtaining a copy of this software and associated documentation
+ *     files (the "Software"), to deal in the Software without
+ *     restriction, including without limitation the rights to use,
+ *     copy, modify, merge, publish, distribute, sublicense, and/or
+ *     sell copies of the Software, and to permit persons to whom the
+ *     Software is furnished to do so, subject to the following
+ *     conditions:
+ *
+ *     The above copyright notice and this permission notice shall be
+ *     included in all copies or substantial portions of the Software.
+ *
+ *     THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
+ *     EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
+ *     OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
+ *     NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
+ *     HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
+ *     WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+ *     FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
+ *     OTHER DEALINGS IN THE SOFTWARE.
+ */
+
+#include "sun8i-a33-q8-tablet.dts"
+
+/ {
+	model = "Q8 A33 Tablet with 800x480 LCD";
+	compatible = "allwinner,q8-a33-800x480", "allwinner,q8-a33",
+		     "allwinner,sun8i-a33";
+};
-- 
2.13.0

[toc] | [next] | [standalone]

#1716196 — Re: [PATCH] ARM: sun8i: a33: add dts for Q8 tablets with different resolution

FromMaxime Ripard <maxime.ripard@free-electrons.com>
Date2017-08-21 10:50 +0200
SubjectRe: [PATCH] ARM: sun8i: a33: add dts for Q8 tablets with different resolution
Message-ID<ugQzg-20E-11@gated-at.bofh.it>
In reply to#1713610

[Multipart message — attachments visible in raw view] — view raw

On Thu, Aug 17, 2017 at 03:49:26PM +0800, Icenowy Zheng wrote:
> Q8 tablets with Allwinner A33 SoC now come with two kind of LCD, either
> 800x480 or 1024x600.
> 
> In order for sun4i-drm to be able to choose correct LCD configuration,
> two different device trees should be present, one for a resolution.
> 
> Add stub device trees for two resolutions.
> 
> As the sun4i-drm driver still has some problems to support the LCDs, the
> real LCD device nodes are not added to the device tree files.
> 
> Signed-off-by: Icenowy Zheng <icenowy@aosc.io>

This should be an overlay, ideally applied by the bootloader.

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[toc] | [prev] | [next] | [standalone]

#1716204 — Re: [PATCH] ARM: sun8i: a33: add dts for Q8 tablets with different resolution

Fromicenowy@aosc.io
Date2017-08-21 10:50 +0200
SubjectRe: [PATCH] ARM: sun8i: a33: add dts for Q8 tablets with different resolution
Message-ID<ugQzg-20E-27@gated-at.bofh.it>
In reply to#1716196
在 2017-08-21 16:40，Maxime Ripard 写道：
> On Thu, Aug 17, 2017 at 03:49:26PM +0800, Icenowy Zheng wrote:
>> Q8 tablets with Allwinner A33 SoC now come with two kind of LCD, 
>> either
>> 800x480 or 1024x600.
>> 
>> In order for sun4i-drm to be able to choose correct LCD configuration,
>> two different device trees should be present, one for a resolution.
>> 
>> Add stub device trees for two resolutions.
>> 
>> As the sun4i-drm driver still has some problems to support the LCDs, 
>> the
>> real LCD device nodes are not added to the device tree files.
>> 
>> Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
> 
> This should be an overlay, ideally applied by the bootloader.

I think this is not suitable for overlay.

The two kind of Q8 tablets are not compatible at all, and they
should both have a suitable device tree. The old DT without
resolution is only kept for backward compatibility.

> 
> Maxime
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

[toc] | [prev] | [next] | [standalone]

#1717816 — Re: [PATCH] ARM: sun8i: a33: add dts for Q8 tablets with different resolution

FromMaxime Ripard <maxime.ripard@free-electrons.com>
Date2017-08-22 22:40 +0200
SubjectRe: [PATCH] ARM: sun8i: a33: add dts for Q8 tablets with different resolution
Message-ID<uho7U-7sy-19@gated-at.bofh.it>
In reply to#1716204

[Multipart message — attachments visible in raw view] — view raw

On Mon, Aug 21, 2017 at 04:44:30PM +0800, icenowy@aosc.io wrote:
> 在 2017-08-21 16:40，Maxime Ripard 写道：
> > On Thu, Aug 17, 2017 at 03:49:26PM +0800, Icenowy Zheng wrote:
> > > Q8 tablets with Allwinner A33 SoC now come with two kind of LCD,
> > > either
> > > 800x480 or 1024x600.
> > > 
> > > In order for sun4i-drm to be able to choose correct LCD configuration,
> > > two different device trees should be present, one for a resolution.
> > > 
> > > Add stub device trees for two resolutions.
> > > 
> > > As the sun4i-drm driver still has some problems to support the LCDs,
> > > the
> > > real LCD device nodes are not added to the device tree files.
> > > 
> > > Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
> > 
> > This should be an overlay, ideally applied by the bootloader.
> 
> I think this is not suitable for overlay.
> 
> The two kind of Q8 tablets are not compatible at all, and they
> should both have a suitable device tree.

How are they not compatible?

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web