Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1715876 > unrolled thread

[PATCH 2/2] ARM: sunxi: add support for R40 SoC

Started byIcenowy Zheng <icenowy@aosc.io>
First post2017-08-20 07:40 +0200
Last post2017-08-22 22:10 +0200
Articles 4 — 3 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  [PATCH 2/2] ARM: sunxi: add support for R40 SoC Icenowy Zheng <icenowy@aosc.io> - 2017-08-20 07:40 +0200
    Re: [PATCH 2/2] ARM: sunxi: add support for R40 SoC Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-08-21 11:40 +0200
      Re: [PATCH 2/2] ARM: sunxi: add support for R40 SoC icenowy@aosc.io - 2017-08-22 07:20 +0200
        Re: [PATCH 2/2] ARM: sunxi: add support for R40 SoC Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-08-22 22:10 +0200

#1715876 — [PATCH 2/2] ARM: sunxi: add support for R40 SoC

FromIcenowy Zheng <icenowy@aosc.io>
Date2017-08-20 07:40 +0200
Subject[PATCH 2/2] ARM: sunxi: add support for R40 SoC
Message-ID<ugr7P-2MI-1@gated-at.bofh.it>
Allwinner R40 is a new SoC, with Quad Core Cortex-A7 and peripherals
like A20.

Add support for it.

Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
---
 Documentation/arm/sunxi/README                  | 6 ++++++
 Documentation/devicetree/bindings/arm/sunxi.txt | 1 +
 arch/arm/mach-sunxi/sunxi.c                     | 1 +
 3 files changed, 8 insertions(+)

diff --git a/Documentation/arm/sunxi/README b/Documentation/arm/sunxi/README
index d7b1f016bd62..4fa836782e46 100644
--- a/Documentation/arm/sunxi/README
+++ b/Documentation/arm/sunxi/README
@@ -75,6 +75,12 @@ SunXi family
         + Datasheet
           http://linux-sunxi.org/File:Allwinner_V3s_Datasheet_V1.0.pdf
 
+      - Allwinner R40 (sun8i)
+        + Datasheet
+          https://github.com/tinalinux/docs/raw/r40-v1.y/R40_Datasheet_V1.0.pdf
+        + User Manual
+          https://github.com/tinalinux/docs/raw/r40-v1.y/Allwinner_R40_User_Manual_V1.0.pdf
+
     * Quad ARM Cortex-A15, Quad ARM Cortex-A7 based SoCs
       - Allwinner A80
         + Datasheet
diff --git a/Documentation/devicetree/bindings/arm/sunxi.txt b/Documentation/devicetree/bindings/arm/sunxi.txt
index f35c6ada5a65..e4beec3d9ad3 100644
--- a/Documentation/devicetree/bindings/arm/sunxi.txt
+++ b/Documentation/devicetree/bindings/arm/sunxi.txt
@@ -14,6 +14,7 @@ using one of the following compatible strings:
   allwinner,sun8i-a83t
   allwinner,sun8i-h2-plus
   allwinner,sun8i-h3
+  allwinner-sun8i-r40
   allwinner,sun8i-v3s
   allwinner,sun9i-a80
   allwinner,sun50i-a64
diff --git a/arch/arm/mach-sunxi/sunxi.c b/arch/arm/mach-sunxi/sunxi.c
index 7ab353fb25f2..311e6c4fc4f4 100644
--- a/arch/arm/mach-sunxi/sunxi.c
+++ b/arch/arm/mach-sunxi/sunxi.c
@@ -66,6 +66,7 @@ static const char * const sun8i_board_dt_compat[] = {
 	"allwinner,sun8i-h2-plus",
 	"allwinner,sun8i-h3",
 	"allwinner,sun8i-v3s",
+	"allwinner,sun8i-r40",
 	NULL,
 };
 
-- 
2.13.0

[toc] | [next] | [standalone]

#1716244

FromMaxime Ripard <maxime.ripard@free-electrons.com>
Date2017-08-21 11:40 +0200
Message-ID<ugRlD-2Dd-1@gated-at.bofh.it>
In reply to#1715876

[Multipart message — attachments visible in raw view] — view raw

Hi,

On Sun, Aug 20, 2017 at 01:29:57PM +0800, Icenowy Zheng wrote:
> Allwinner R40 is a new SoC, with Quad Core Cortex-A7 and peripherals
> like A20.
> 
> Add support for it.
> 
> Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
> ---
>  Documentation/arm/sunxi/README                  | 6 ++++++
>  Documentation/devicetree/bindings/arm/sunxi.txt | 1 +
>  arch/arm/mach-sunxi/sunxi.c                     | 1 +
>  3 files changed, 8 insertions(+)
> 
> diff --git a/Documentation/arm/sunxi/README b/Documentation/arm/sunxi/README
> index d7b1f016bd62..4fa836782e46 100644
> --- a/Documentation/arm/sunxi/README
> +++ b/Documentation/arm/sunxi/README
> @@ -75,6 +75,12 @@ SunXi family
>          + Datasheet
>            http://linux-sunxi.org/File:Allwinner_V3s_Datasheet_V1.0.pdf
>  
> +      - Allwinner R40 (sun8i)
> +        + Datasheet
> +          https://github.com/tinalinux/docs/raw/r40-v1.y/R40_Datasheet_V1.0.pdf
> +        + User Manual
> +          https://github.com/tinalinux/docs/raw/r40-v1.y/Allwinner_R40_User_Manual_V1.0.pdf
> +

Please sort it by alphabetical order.

>      * Quad ARM Cortex-A15, Quad ARM Cortex-A7 based SoCs
>        - Allwinner A80
>          + Datasheet
> diff --git a/Documentation/devicetree/bindings/arm/sunxi.txt b/Documentation/devicetree/bindings/arm/sunxi.txt
> index f35c6ada5a65..e4beec3d9ad3 100644
> --- a/Documentation/devicetree/bindings/arm/sunxi.txt
> +++ b/Documentation/devicetree/bindings/arm/sunxi.txt
> @@ -14,6 +14,7 @@ using one of the following compatible strings:
>    allwinner,sun8i-a83t
>    allwinner,sun8i-h2-plus
>    allwinner,sun8i-h3
> +  allwinner-sun8i-r40
>    allwinner,sun8i-v3s
>    allwinner,sun9i-a80
>    allwinner,sun50i-a64
> diff --git a/arch/arm/mach-sunxi/sunxi.c b/arch/arm/mach-sunxi/sunxi.c
> index 7ab353fb25f2..311e6c4fc4f4 100644
> --- a/arch/arm/mach-sunxi/sunxi.c
> +++ b/arch/arm/mach-sunxi/sunxi.c
> @@ -66,6 +66,7 @@ static const char * const sun8i_board_dt_compat[] = {
>  	"allwinner,sun8i-h2-plus",
>  	"allwinner,sun8i-h3",
>  	"allwinner,sun8i-v3s",
> +	"allwinner,sun8i-r40",

And same thing here.

Thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[toc] | [prev] | [next] | [standalone]

#1717027

Fromicenowy@aosc.io
Date2017-08-22 07:20 +0200
Message-ID<uh9Lz-6cY-5@gated-at.bofh.it>
In reply to#1716244
在 2017-08-21 17:34，Maxime Ripard 写道：
> Hi,
> 
> On Sun, Aug 20, 2017 at 01:29:57PM +0800, Icenowy Zheng wrote:
>> Allwinner R40 is a new SoC, with Quad Core Cortex-A7 and peripherals
>> like A20.
>> 
>> Add support for it.
>> 
>> Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
>> ---
>>  Documentation/arm/sunxi/README                  | 6 ++++++
>>  Documentation/devicetree/bindings/arm/sunxi.txt | 1 +
>>  arch/arm/mach-sunxi/sunxi.c                     | 1 +
>>  3 files changed, 8 insertions(+)
>> 
>> diff --git a/Documentation/arm/sunxi/README 
>> b/Documentation/arm/sunxi/README
>> index d7b1f016bd62..4fa836782e46 100644
>> --- a/Documentation/arm/sunxi/README
>> +++ b/Documentation/arm/sunxi/README
>> @@ -75,6 +75,12 @@ SunXi family
>>          + Datasheet
>>            
>> http://linux-sunxi.org/File:Allwinner_V3s_Datasheet_V1.0.pdf
>> 
>> +      - Allwinner R40 (sun8i)
>> +        + Datasheet
>> +          
>> https://github.com/tinalinux/docs/raw/r40-v1.y/R40_Datasheet_V1.0.pdf
>> +        + User Manual
>> +          
>> https://github.com/tinalinux/docs/raw/r40-v1.y/Allwinner_R40_User_Manual_V1.0.pdf
>> +
> 
> Please sort it by alphabetical order.

I prefer to sort it by the wafer ID (the number after w in the official 
ID).

The current document can be explained to follow the alphabetical order
or the wafer ID.

P.S. there's some error in the V3s datasheet position, and if it's fixed
we can still continue to make the two kinds of order both meaningful ;-)

> 
>>      * Quad ARM Cortex-A15, Quad ARM Cortex-A7 based SoCs
>>        - Allwinner A80
>>          + Datasheet
>> diff --git a/Documentation/devicetree/bindings/arm/sunxi.txt 
>> b/Documentation/devicetree/bindings/arm/sunxi.txt
>> index f35c6ada5a65..e4beec3d9ad3 100644
>> --- a/Documentation/devicetree/bindings/arm/sunxi.txt
>> +++ b/Documentation/devicetree/bindings/arm/sunxi.txt
>> @@ -14,6 +14,7 @@ using one of the following compatible strings:
>>    allwinner,sun8i-a83t
>>    allwinner,sun8i-h2-plus
>>    allwinner,sun8i-h3
>> +  allwinner-sun8i-r40
>>    allwinner,sun8i-v3s
>>    allwinner,sun9i-a80
>>    allwinner,sun50i-a64
>> diff --git a/arch/arm/mach-sunxi/sunxi.c b/arch/arm/mach-sunxi/sunxi.c
>> index 7ab353fb25f2..311e6c4fc4f4 100644
>> --- a/arch/arm/mach-sunxi/sunxi.c
>> +++ b/arch/arm/mach-sunxi/sunxi.c
>> @@ -66,6 +66,7 @@ static const char * const sun8i_board_dt_compat[] = 
>> {
>>  	"allwinner,sun8i-h2-plus",
>>  	"allwinner,sun8i-h3",
>>  	"allwinner,sun8i-v3s",
>> +	"allwinner,sun8i-r40",
> 
> And same thing here.
> 
> Thanks!
> Maxime

[toc] | [prev] | [next] | [standalone]

#1717796

FromMaxime Ripard <maxime.ripard@free-electrons.com>
Date2017-08-22 22:10 +0200
Message-ID<uhnER-7gO-1@gated-at.bofh.it>
In reply to#1717027

[Multipart message — attachments visible in raw view] — view raw

On Tue, Aug 22, 2017 at 01:14:09PM +0800, icenowy@aosc.io wrote:
> 在 2017-08-21 17:34，Maxime Ripard 写道：
> > Hi,
> > 
> > On Sun, Aug 20, 2017 at 01:29:57PM +0800, Icenowy Zheng wrote:
> > > Allwinner R40 is a new SoC, with Quad Core Cortex-A7 and peripherals
> > > like A20.
> > > 
> > > Add support for it.
> > > 
> > > Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
> > > ---
> > >  Documentation/arm/sunxi/README                  | 6 ++++++
> > >  Documentation/devicetree/bindings/arm/sunxi.txt | 1 +
> > >  arch/arm/mach-sunxi/sunxi.c                     | 1 +
> > >  3 files changed, 8 insertions(+)
> > > 
> > > diff --git a/Documentation/arm/sunxi/README
> > > b/Documentation/arm/sunxi/README
> > > index d7b1f016bd62..4fa836782e46 100644
> > > --- a/Documentation/arm/sunxi/README
> > > +++ b/Documentation/arm/sunxi/README
> > > @@ -75,6 +75,12 @@ SunXi family
> > >          + Datasheet
> > > http://linux-sunxi.org/File:Allwinner_V3s_Datasheet_V1.0.pdf
> > > 
> > > +      - Allwinner R40 (sun8i)
> > > +        + Datasheet
> > > +
> > > https://github.com/tinalinux/docs/raw/r40-v1.y/R40_Datasheet_V1.0.pdf
> > > +        + User Manual
> > > +          https://github.com/tinalinux/docs/raw/r40-v1.y/Allwinner_R40_User_Manual_V1.0.pdf
> > > +
> > 
> > Please sort it by alphabetical order.
> 
> I prefer to sort it by the wafer ID (the number after w in the
> official ID).
> 
> The current document can be explained to follow the alphabetical
> order or the wafer ID.

You should know who your audience is. Whoever is going to end up here
to have a list of the SoC names and their datasheet is very likely to
not know by heart the wafer IDs, while anyone that can read knows the
alphabet.

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web