Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1717094 > unrolled thread
| Started by | Maciej Purski <m.purski@samsung.com> |
|---|---|
| First post | 2017-08-22 09:40 +0200 |
| Last post | 2017-08-22 14:10 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH v3] mfd: max77693: Add muic of_compatible in mfd_cell Maciej Purski <m.purski@samsung.com> - 2017-08-22 09:40 +0200
Re: [PATCH v3] mfd: max77693: Add muic of_compatible in mfd_cell Chanwoo Choi <cw00.choi@samsung.com> - 2017-08-22 10:00 +0200
Re: [PATCH v3] mfd: max77693: Add muic of_compatible in mfd_cell Krzysztof Kozlowski <krzk@kernel.org> - 2017-08-22 14:10 +0200
| From | Maciej Purski <m.purski@samsung.com> |
|---|---|
| Date | 2017-08-22 09:40 +0200 |
| Subject | [PATCH v3] mfd: max77693: Add muic of_compatible in mfd_cell |
| Message-ID | <uhbX3-7Cz-11@gated-at.bofh.it> |
This patch adds muic of_compatible in order to use the muic device
driver in device tree.
v2:
- added muic to documentation
v3:
- removed duplication
Signed-off-by: Maciej Purski <m.purski@samsung.com>
---
Documentation/devicetree/bindings/mfd/max77693.txt | 6 ++++++
drivers/mfd/max77693.c | 5 ++++-
2 files changed, 10 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/mfd/max77693.txt b/Documentation/devicetree/bindings/mfd/max77693.txt
index 6a1ae3a..e675497 100644
--- a/Documentation/devicetree/bindings/mfd/max77693.txt
+++ b/Documentation/devicetree/bindings/mfd/max77693.txt
@@ -127,6 +127,12 @@ Required properties for the LED child node:
Optional properties for the LED child node:
- label : see Documentation/devicetree/bindings/leds/common.txt
+Optional nodes:
+- max77693-muic :
+ Node used only by extcon consumers.
+ Required properties:
+ - compatible : "maxim,max77693-muic"
+
Example:
#include <dt-bindings/leds/common.h>
diff --git a/drivers/mfd/max77693.c b/drivers/mfd/max77693.c
index 662ae0d..1c05ea0 100644
--- a/drivers/mfd/max77693.c
+++ b/drivers/mfd/max77693.c
@@ -48,7 +48,10 @@ static const struct mfd_cell max77693_devs[] = {
.name = "max77693-charger",
.of_compatible = "maxim,max77693-charger",
},
- { .name = "max77693-muic", },
+ {
+ .name = "max77693-muic",
+ .of_compatible = "maxim,max77693-muic",
+ },
{
.name = "max77693-haptic",
.of_compatible = "maxim,max77693-haptic",
--
2.7.4
[toc] | [next] | [standalone]
| From | Chanwoo Choi <cw00.choi@samsung.com> |
|---|---|
| Date | 2017-08-22 10:00 +0200 |
| Message-ID | <uhcgp-7KH-3@gated-at.bofh.it> |
| In reply to | #1717094 |
On 2017년 08월 22일 16:38, Maciej Purski wrote:
> This patch adds muic of_compatible in order to use the muic device
> driver in device tree.
>
> v2:
> - added muic to documentation
>
> v3:
> - removed duplication
>
> Signed-off-by: Maciej Purski <m.purski@samsung.com>
> ---
> Documentation/devicetree/bindings/mfd/max77693.txt | 6 ++++++
> drivers/mfd/max77693.c | 5 ++++-
> 2 files changed, 10 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/mfd/max77693.txt b/Documentation/devicetree/bindings/mfd/max77693.txt
> index 6a1ae3a..e675497 100644
> --- a/Documentation/devicetree/bindings/mfd/max77693.txt
> +++ b/Documentation/devicetree/bindings/mfd/max77693.txt
> @@ -127,6 +127,12 @@ Required properties for the LED child node:
> Optional properties for the LED child node:
> - label : see Documentation/devicetree/bindings/leds/common.txt
>
> +Optional nodes:
> +- max77693-muic :
> + Node used only by extcon consumers.
> + Required properties:
> + - compatible : "maxim,max77693-muic"
> +
> Example:
> #include <dt-bindings/leds/common.h>
>
> diff --git a/drivers/mfd/max77693.c b/drivers/mfd/max77693.c
> index 662ae0d..1c05ea0 100644
> --- a/drivers/mfd/max77693.c
> +++ b/drivers/mfd/max77693.c
> @@ -48,7 +48,10 @@ static const struct mfd_cell max77693_devs[] = {
> .name = "max77693-charger",
> .of_compatible = "maxim,max77693-charger",
> },
> - { .name = "max77693-muic", },
> + {
> + .name = "max77693-muic",
> + .of_compatible = "maxim,max77693-muic",
> + },
> {
> .name = "max77693-haptic",
> .of_compatible = "maxim,max77693-haptic",
>
Looks good to me.
Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
--
Best Regards,
Chanwoo Choi
Samsung Electronics
[toc] | [prev] | [next] | [standalone]
| From | Krzysztof Kozlowski <krzk@kernel.org> |
|---|---|
| Date | 2017-08-22 14:10 +0200 |
| Message-ID | <uhgam-2av-11@gated-at.bofh.it> |
| In reply to | #1717094 |
On Tue, Aug 22, 2017 at 9:38 AM, Maciej Purski <m.purski@samsung.com> wrote:
> This patch adds muic of_compatible in order to use the muic device
> driver in device tree.
>
> v2:
> - added muic to documentation
Change log should not go to commit message. Put it after separator ---.
+cc devicetree - scripts/get_maintainer.pl should point you that list.
With the change in commit msg:
Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
Best regards,
Krzysztof
>
> v3:
> - removed duplication
>
> Signed-off-by: Maciej Purski <m.purski@samsung.com>
> ---
> Documentation/devicetree/bindings/mfd/max77693.txt | 6 ++++++
> drivers/mfd/max77693.c | 5 ++++-
> 2 files changed, 10 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/mfd/max77693.txt b/Documentation/devicetree/bindings/mfd/max77693.txt
> index 6a1ae3a..e675497 100644
> --- a/Documentation/devicetree/bindings/mfd/max77693.txt
> +++ b/Documentation/devicetree/bindings/mfd/max77693.txt
> @@ -127,6 +127,12 @@ Required properties for the LED child node:
> Optional properties for the LED child node:
> - label : see Documentation/devicetree/bindings/leds/common.txt
>
> +Optional nodes:
> +- max77693-muic :
> + Node used only by extcon consumers.
> + Required properties:
> + - compatible : "maxim,max77693-muic"
> +
> Example:
> #include <dt-bindings/leds/common.h>
>
> diff --git a/drivers/mfd/max77693.c b/drivers/mfd/max77693.c
> index 662ae0d..1c05ea0 100644
> --- a/drivers/mfd/max77693.c
> +++ b/drivers/mfd/max77693.c
> @@ -48,7 +48,10 @@ static const struct mfd_cell max77693_devs[] = {
> .name = "max77693-charger",
> .of_compatible = "maxim,max77693-charger",
> },
> - { .name = "max77693-muic", },
> + {
> + .name = "max77693-muic",
> + .of_compatible = "maxim,max77693-muic",
> + },
> {
> .name = "max77693-haptic",
> .of_compatible = "maxim,max77693-haptic",
> --
> 2.7.4
>
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web