Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1715725 > unrolled thread

[PATCH 0/3] constify drm i2c_device_id

Back to article view | Back to linux.kernel

Contents

  [PATCH 0/3] constify drm i2c_device_id Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-19 20:30 +0200
    [PATCH 1/3] drm: i2c: ch7006: constify i2c_device_id Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-19 20:30 +0200
    [PATCH 2/3] drm: i2c: sil164: constify i2c_device_id Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-19 20:30 +0200
    [PATCH 3/3] drm: i2c: tda998x: constify i2c_device_id Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-19 20:30 +0200
    Re: [PATCH 0/3] constify drm i2c_device_id Daniel Vetter <daniel@ffwll.ch> - 2017-08-22 08:40 +0200
      Re: [PATCH 0/3] constify drm i2c_device_id Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-22 11:50 +0200

#1715725 — [PATCH 0/3] constify drm i2c_device_id

i2c_device_id are not supposed to change at runtime. All functions
working with i2c_device_id provided by <linux/i2c.h> work with
const i2c_device_id. So mark the non-const structs as const.

Arvind Yadav (3):
  [PATCH 1/3] drm: i2c: ch7006: constify i2c_device_id
  [PATCH 2/3] drm: i2c: sil164: constify i2c_device_id
  [PATCH 3/3] drm: i2c: tda998x: constify i2c_device_id

 drivers/gpu/drm/i2c/ch7006_drv.c  | 2 +-
 drivers/gpu/drm/i2c/sil164_drv.c  | 2 +-
 drivers/gpu/drm/i2c/tda998x_drv.c | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

-- 
2.7.4

[toc] | [next] | [standalone]

#1715726 — [PATCH 1/3] drm: i2c: ch7006: constify i2c_device_id

i2c_device_id are not supposed to change at runtime. All functions
working with i2c_device_id provided by <linux/i2c.h> work with
const i2c_device_id. So mark the non-const structs as const.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
 drivers/gpu/drm/i2c/ch7006_drv.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i2c/ch7006_drv.c b/drivers/gpu/drm/i2c/ch7006_drv.c
index e9e8ae2..544a8a2 100644
--- a/drivers/gpu/drm/i2c/ch7006_drv.c
+++ b/drivers/gpu/drm/i2c/ch7006_drv.c
@@ -485,7 +485,7 @@ static int ch7006_encoder_init(struct i2c_client *client,
 	return 0;
 }
 
-static struct i2c_device_id ch7006_ids[] = {
+static const struct i2c_device_id ch7006_ids[] = {
 	{ "ch7006", 0 },
 	{ }
 };
-- 
2.7.4

[toc] | [prev] | [next] | [standalone]

#1715727 — [PATCH 2/3] drm: i2c: sil164: constify i2c_device_id

i2c_device_id are not supposed to change at runtime. All functions
working with i2c_device_id provided by <linux/i2c.h> work with
const i2c_device_id. So mark the non-const structs as const.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
 drivers/gpu/drm/i2c/sil164_drv.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i2c/sil164_drv.c b/drivers/gpu/drm/i2c/sil164_drv.c
index db0b03f..ecaa587 100644
--- a/drivers/gpu/drm/i2c/sil164_drv.c
+++ b/drivers/gpu/drm/i2c/sil164_drv.c
@@ -415,7 +415,7 @@ sil164_encoder_init(struct i2c_client *client,
 	return 0;
 }
 
-static struct i2c_device_id sil164_ids[] = {
+static const struct i2c_device_id sil164_ids[] = {
 	{ "sil164", 0 },
 	{ }
 };
-- 
2.7.4

[toc] | [prev] | [next] | [standalone]

#1715729 — [PATCH 3/3] drm: i2c: tda998x: constify i2c_device_id

i2c_device_id are not supposed to change at runtime. All functions
working with i2c_device_id provided by <linux/i2c.h> work with
const i2c_device_id. So mark the non-const structs as const.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
 drivers/gpu/drm/i2c/tda998x_drv.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i2c/tda998x_drv.c b/drivers/gpu/drm/i2c/tda998x_drv.c
index 86f47e1..7605661 100644
--- a/drivers/gpu/drm/i2c/tda998x_drv.c
+++ b/drivers/gpu/drm/i2c/tda998x_drv.c
@@ -1754,7 +1754,7 @@ static const struct of_device_id tda998x_dt_ids[] = {
 MODULE_DEVICE_TABLE(of, tda998x_dt_ids);
 #endif
 
-static struct i2c_device_id tda998x_ids[] = {
+static const struct i2c_device_id tda998x_ids[] = {
 	{ "tda998x", 0 },
 	{ }
 };
-- 
2.7.4

[toc] | [prev] | [next] | [standalone]

#1717065

On Sat, Aug 19, 2017 at 11:58:17PM +0530, Arvind Yadav wrote:
> i2c_device_id are not supposed to change at runtime. All functions
> working with i2c_device_id provided by <linux/i2c.h> work with
> const i2c_device_id. So mark the non-const structs as const.

All applied.

btw I think this isn't your first series, and we're trying to keep some of
the trivial mistakes around in drm, as an easy way for newbies to get into
the subsystem with their first patch.

We'd like more regular contributors to tackle some of the more involved
cleanup tasks, which should also be more valuable to the subsystem:

file:///home/daniel/linux/src/Documentation/output/gpu/todo.html#todo

Cheers, Daniel

> 
> Arvind Yadav (3):
>   [PATCH 1/3] drm: i2c: ch7006: constify i2c_device_id
>   [PATCH 2/3] drm: i2c: sil164: constify i2c_device_id
>   [PATCH 3/3] drm: i2c: tda998x: constify i2c_device_id
> 
>  drivers/gpu/drm/i2c/ch7006_drv.c  | 2 +-
>  drivers/gpu/drm/i2c/sil164_drv.c  | 2 +-
>  drivers/gpu/drm/i2c/tda998x_drv.c | 2 +-
>  3 files changed, 3 insertions(+), 3 deletions(-)
> 
> -- 
> 2.7.4
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

[toc] | [prev] | [next] | [standalone]

#1717229

Hi Daniel,


On Tuesday 22 August 2017 12:01 PM, Daniel Vetter wrote:
> On Sat, Aug 19, 2017 at 11:58:17PM +0530, Arvind Yadav wrote:
>> i2c_device_id are not supposed to change at runtime. All functions
>> working with i2c_device_id provided by <linux/i2c.h> work with
>> const i2c_device_id. So mark the non-const structs as const.
> All applied.
>
> btw I think this isn't your first series, and we're trying to keep some of
> the trivial mistakes around in drm, as an easy way for newbies to get into
> the subsystem with their first patch.
>
> We'd like more regular contributors to tackle some of the more involved
> cleanup tasks, which should also be more valuable to the subsystem:
>
> file:///home/daniel/linux/src/Documentation/output/gpu/todo.html#todo
I want to contribute drm and others subsystem. If you can guide me.
It will helpful for me.
> Cheers, Daniel
>
>> Arvind Yadav (3):
>>    [PATCH 1/3] drm: i2c: ch7006: constify i2c_device_id
>>    [PATCH 2/3] drm: i2c: sil164: constify i2c_device_id
>>    [PATCH 3/3] drm: i2c: tda998x: constify i2c_device_id
>>
>>   drivers/gpu/drm/i2c/ch7006_drv.c  | 2 +-
>>   drivers/gpu/drm/i2c/sil164_drv.c  | 2 +-
>>   drivers/gpu/drm/i2c/tda998x_drv.c | 2 +-
>>   3 files changed, 3 insertions(+), 3 deletions(-)
>>
>> -- 
>> 2.7.4
>>
>> _______________________________________________
>> dri-devel mailing list
>> dri-devel@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/dri-devel
~arvind

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web