Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1717157 > unrolled thread

[PATCH] net: ethernet: freescale: fs_enet: make mdiobb_ops const

Started byBhumika Goyal <bhumirks@gmail.com>
First post2017-08-22 10:20 +0200
Last post2017-08-22 23:30 +0200
Articles 2 — 2 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH] net: ethernet: freescale: fs_enet: make mdiobb_ops const Bhumika Goyal <bhumirks@gmail.com> - 2017-08-22 10:20 +0200
    Re: [PATCH] net: ethernet: freescale: fs_enet: make mdiobb_ops  const David Miller <davem@davemloft.net> - 2017-08-22 23:30 +0200

#1717157 — [PATCH] net: ethernet: freescale: fs_enet: make mdiobb_ops const

FromBhumika Goyal <bhumirks@gmail.com>
Date2017-08-22 10:20 +0200
Subject[PATCH] net: ethernet: freescale: fs_enet: make mdiobb_ops const
Message-ID<uhczM-87k-9@gated-at.bofh.it>
Make this const as it is only stored in a const field of a
mdiobb_ctrl structure.

Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
---
 drivers/net/ethernet/freescale/fs_enet/mii-bitbang.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/freescale/fs_enet/mii-bitbang.c b/drivers/net/ethernet/freescale/fs_enet/mii-bitbang.c
index 1f015ed..c8e5d88 100644
--- a/drivers/net/ethernet/freescale/fs_enet/mii-bitbang.c
+++ b/drivers/net/ethernet/freescale/fs_enet/mii-bitbang.c
@@ -100,7 +100,7 @@ static inline void mdc(struct mdiobb_ctrl *ctrl, int what)
 	in_be32(bitbang->dat);
 }
 
-static struct mdiobb_ops bb_ops = {
+static const struct mdiobb_ops bb_ops = {
 	.owner = THIS_MODULE,
 	.set_mdc = mdc,
 	.set_mdio_dir = mdio_dir,
-- 
1.9.1

[toc] | [next] | [standalone]


#1717852 — Re: [PATCH] net: ethernet: freescale: fs_enet: make mdiobb_ops const

FromDavid Miller <davem@davemloft.net>
Date2017-08-22 23:30 +0200
SubjectRe: [PATCH] net: ethernet: freescale: fs_enet: make mdiobb_ops const
Message-ID<uhoUi-82K-17@gated-at.bofh.it>
In reply to#1717157
From: Bhumika Goyal <bhumirks@gmail.com>
Date: Tue, 22 Aug 2017 13:45:59 +0530

> Make this const as it is only stored in a const field of a
> mdiobb_ctrl structure.
> 
> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>

Applied.

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web