Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1717080 > unrolled thread

[PATCH v2] mfd: max77693: Add muic of_compatible in mfd_cell

Started byMaciej Purski <m.purski@samsung.com>
First post2017-08-22 09:10 +0200
Last post2017-08-22 09:20 +0200
Articles 3 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  [PATCH v2] mfd: max77693: Add muic of_compatible in mfd_cell Maciej Purski <m.purski@samsung.com> - 2017-08-22 09:10 +0200
    Re: [PATCH v2] mfd: max77693: Add muic of_compatible in mfd_cell Chanwoo Choi <cw00.choi@samsung.com> - 2017-08-22 09:20 +0200
    Re: [PATCH v2] mfd: max77693: Add muic of_compatible in mfd_cell Chanwoo Choi <cw00.choi@samsung.com> - 2017-08-22 09:20 +0200

#1717080 — [PATCH v2] mfd: max77693: Add muic of_compatible in mfd_cell

FromMaciej Purski <m.purski@samsung.com>
Date2017-08-22 09:10 +0200
Subject[PATCH v2] mfd: max77693: Add muic of_compatible in mfd_cell
Message-ID<uhbu2-7on-11@gated-at.bofh.it>
This patch adds muic of_compatible in order to use the muic device
driver in device tree.

v2:
- added muic to documentation

Signed-off-by: Maciej Purski <m.purski@samsung.com>
---
 Documentation/devicetree/bindings/mfd/max77693.txt | 6 ++++++
 drivers/mfd/max77693.c                             | 5 ++++-
 2 files changed, 10 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/mfd/max77693.txt b/Documentation/devicetree/bindings/mfd/max77693.txt
index 6a1ae3a..6ca2478 100644
--- a/Documentation/devicetree/bindings/mfd/max77693.txt
+++ b/Documentation/devicetree/bindings/mfd/max77693.txt
@@ -127,6 +127,12 @@ Required properties for the LED child node:
 Optional properties for the LED child node:
 - label : see Documentation/devicetree/bindings/leds/common.txt
 
+Optional nodes:
+- max77693-muic/max77693-muic :
+	Node used only by extcon consumers.
+	Required properties:
+		- compatible : "maxim,max77693-muic" or "maxim,max77693-muic"
+
 Example:
 #include <dt-bindings/leds/common.h>
 
diff --git a/drivers/mfd/max77693.c b/drivers/mfd/max77693.c
index 662ae0d..1c05ea0 100644
--- a/drivers/mfd/max77693.c
+++ b/drivers/mfd/max77693.c
@@ -48,7 +48,10 @@ static const struct mfd_cell max77693_devs[] = {
 		.name = "max77693-charger",
 		.of_compatible = "maxim,max77693-charger",
 	},
-	{ .name = "max77693-muic", },
+	{
+		.name = "max77693-muic",
+		.of_compatible = "maxim,max77693-muic",
+	},
 	{
 		.name = "max77693-haptic",
 		.of_compatible = "maxim,max77693-haptic",
-- 
2.7.4

[toc] | [next] | [standalone]


#1717085

FromChanwoo Choi <cw00.choi@samsung.com>
Date2017-08-22 09:20 +0200
Message-ID<uhbDI-7uo-13@gated-at.bofh.it>
In reply to#1717080
On 2017년 08월 22일 16:14, Chanwoo Choi wrote:
> Hi,
> 
> On 2017년 08월 22일 16:09, Maciej Purski wrote:
>> This patch adds muic of_compatible in order to use the muic device
>> driver in device tree.
>>
>> v2:
>> - added muic to documentation
>>
>> Signed-off-by: Maciej Purski <m.purski@samsung.com>
>> ---
>>  Documentation/devicetree/bindings/mfd/max77693.txt | 6 ++++++
>>  drivers/mfd/max77693.c                             | 5 ++++-
>>  2 files changed, 10 insertions(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/mfd/max77693.txt b/Documentation/devicetree/bindings/mfd/max77693.txt
>> index 6a1ae3a..6ca2478 100644
>> --- a/Documentation/devicetree/bindings/mfd/max77693.txt
>> +++ b/Documentation/devicetree/bindings/mfd/max77693.txt
>> @@ -127,6 +127,12 @@ Required properties for the LED child node:
>>  Optional properties for the LED child node:
>>  - label : see Documentation/devicetree/bindings/leds/common.txt
>>  
>> +Optional nodes:
>> +- max77693-muic/max77693-muic :

Also, max77693-muic is duplicate.

>> +	Node used only by extcon consumers.
>> +	Required properties:
>> +		- compatible : "maxim,max77693-muic" or "maxim,max77693-muic"
> 
> "maxim,max77693-muic" is duplicate. Please add just one compatible.
> 
>> +
>>  Example:
>>  #include <dt-bindings/leds/common.h>
>>  
>> diff --git a/drivers/mfd/max77693.c b/drivers/mfd/max77693.c
>> index 662ae0d..1c05ea0 100644
>> --- a/drivers/mfd/max77693.c
>> +++ b/drivers/mfd/max77693.c
>> @@ -48,7 +48,10 @@ static const struct mfd_cell max77693_devs[] = {
>>  		.name = "max77693-charger",
>>  		.of_compatible = "maxim,max77693-charger",
>>  	},
>> -	{ .name = "max77693-muic", },
>> +	{
>> +		.name = "max77693-muic",
>> +		.of_compatible = "maxim,max77693-muic",
>> +	},
>>  	{
>>  		.name = "max77693-haptic",
>>  		.of_compatible = "maxim,max77693-haptic",
>>
> 
> 


-- 
Best Regards,
Chanwoo Choi
Samsung Electronics

[toc] | [prev] | [next] | [standalone]


#1717086

FromChanwoo Choi <cw00.choi@samsung.com>
Date2017-08-22 09:20 +0200
Message-ID<uhbDI-7uo-15@gated-at.bofh.it>
In reply to#1717080
Hi,

On 2017년 08월 22일 16:09, Maciej Purski wrote:
> This patch adds muic of_compatible in order to use the muic device
> driver in device tree.
> 
> v2:
> - added muic to documentation
> 
> Signed-off-by: Maciej Purski <m.purski@samsung.com>
> ---
>  Documentation/devicetree/bindings/mfd/max77693.txt | 6 ++++++
>  drivers/mfd/max77693.c                             | 5 ++++-
>  2 files changed, 10 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/mfd/max77693.txt b/Documentation/devicetree/bindings/mfd/max77693.txt
> index 6a1ae3a..6ca2478 100644
> --- a/Documentation/devicetree/bindings/mfd/max77693.txt
> +++ b/Documentation/devicetree/bindings/mfd/max77693.txt
> @@ -127,6 +127,12 @@ Required properties for the LED child node:
>  Optional properties for the LED child node:
>  - label : see Documentation/devicetree/bindings/leds/common.txt
>  
> +Optional nodes:
> +- max77693-muic/max77693-muic :
> +	Node used only by extcon consumers.
> +	Required properties:
> +		- compatible : "maxim,max77693-muic" or "maxim,max77693-muic"

"maxim,max77693-muic" is duplicate. Please add just one compatible.

> +
>  Example:
>  #include <dt-bindings/leds/common.h>
>  
> diff --git a/drivers/mfd/max77693.c b/drivers/mfd/max77693.c
> index 662ae0d..1c05ea0 100644
> --- a/drivers/mfd/max77693.c
> +++ b/drivers/mfd/max77693.c
> @@ -48,7 +48,10 @@ static const struct mfd_cell max77693_devs[] = {
>  		.name = "max77693-charger",
>  		.of_compatible = "maxim,max77693-charger",
>  	},
> -	{ .name = "max77693-muic", },
> +	{
> +		.name = "max77693-muic",
> +		.of_compatible = "maxim,max77693-muic",
> +	},
>  	{
>  		.name = "max77693-haptic",
>  		.of_compatible = "maxim,max77693-haptic",
> 


-- 
Best Regards,
Chanwoo Choi
Samsung Electronics

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web