Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1719034 > unrolled thread

[PATCH] pinctrl: rza1: Remove suffix from gpiochip label

Started byJacopo Mondi <jacopo+renesas@jmondi.org>
First post2017-08-24 11:00 +0200
Last post2017-08-24 11:00 +0200
Articles 1 — 1 participant

Back to article view | Back to linux.kernel


Contents

  [PATCH] pinctrl: rza1: Remove suffix from gpiochip label Jacopo Mondi <jacopo+renesas@jmondi.org> - 2017-08-24 11:00 +0200

#1719034 — [PATCH] pinctrl: rza1: Remove suffix from gpiochip label

FromJacopo Mondi <jacopo+renesas@jmondi.org>
Date2017-08-24 11:00 +0200
Subject[PATCH] pinctrl: rza1: Remove suffix from gpiochip label
Message-ID<uhW9B-4bT-47@gated-at.bofh.it>
The OF node name already contains the gpio chip identifier, no need to
append it when creating the label.

The following debug message clearly shows the suffix is not required
"pinctrl-rza1 fcfe3000.pin-controller: Parsed gpiochip gpio-0-0 with 6
pins"

Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
---
 drivers/pinctrl/pinctrl-rza1.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/pinctrl/pinctrl-rza1.c b/drivers/pinctrl/pinctrl-rza1.c
index dc164da..7e896bd 100644
--- a/drivers/pinctrl/pinctrl-rza1.c
+++ b/drivers/pinctrl/pinctrl-rza1.c
@@ -1096,8 +1096,8 @@ static int rza1_parse_gpiochip(struct rza1_pinctrl *rza1_pctl,

 	*chip		= rza1_gpiochip_template;
 	chip->base	= -1;
-	chip->label	= devm_kasprintf(rza1_pctl->dev, GFP_KERNEL, "%s-%u",
-					 np->name, gpioport);
+	chip->label	= devm_kasprintf(rza1_pctl->dev, GFP_KERNEL, "%s",
+					 np->name);
 	chip->ngpio	= of_args.args[2];
 	chip->of_node	= np;
 	chip->parent	= rza1_pctl->dev;
--
2.7.4

[toc] | [standalone]


Back to top | Article view | linux.kernel


csiph-web