Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1715925 > unrolled thread
| Started by | Konstantin Khlebnikov <khlebnikov@yandex-team.ru> |
|---|---|
| First post | 2017-08-20 13:40 +0200 |
| Last post | 2017-08-24 10:30 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] tools/perf: really install manpages by make install-man Konstantin Khlebnikov <khlebnikov@yandex-team.ru> - 2017-08-20 13:40 +0200
Re: [PATCH] tools/perf: really install manpages by make install-man Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-08-22 17:50 +0200
[tip:perf/core] perf tools: Really install manpages via 'make install-man' tip-bot for Konstantin Khlebnikov <tipbot@zytor.com> - 2017-08-24 10:30 +0200
| From | Konstantin Khlebnikov <khlebnikov@yandex-team.ru> |
|---|---|
| Date | 2017-08-20 13:40 +0200 |
| Subject | [PATCH] tools/perf: really install manpages by make install-man |
| Message-ID | <ugwKe-6mo-15@gated-at.bofh.it> |
Target install-man builds them but forget to install. Signed-off-by: Konstantin Khlebnikov <khlebnikov@yandex-team.ru> --- tools/perf/Documentation/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/Documentation/Makefile b/tools/perf/Documentation/Makefile index 098cfb9ca8f0..db11478e30b4 100644 --- a/tools/perf/Documentation/Makefile +++ b/tools/perf/Documentation/Makefile @@ -192,7 +192,7 @@ do-install-man: man # $(INSTALL) -m 644 $(DOC_MAN5) $(DESTDIR)$(man5dir); \ # $(INSTALL) -m 644 $(DOC_MAN7) $(DESTDIR)$(man7dir) -install-man: check-man-tools man +install-man: check-man-tools man do-install-man ifdef missing_tools DO_INSTALL_MAN = $(warning Please install $(missing_tools) to have the man pages installed)
[toc] | [next] | [standalone]
| From | Arnaldo Carvalho de Melo <acme@kernel.org> |
|---|---|
| Date | 2017-08-22 17:50 +0200 |
| Message-ID | <uhjBf-4nc-3@gated-at.bofh.it> |
| In reply to | #1715925 |
Em Sun, Aug 20, 2017 at 02:39:13PM +0300, Konstantin Khlebnikov escreveu: > Target install-man builds them but forget to install. Thanks, applied, I guess nobody noticed that because the man pages _are_ installed when using plain 'make -C tools/perf install', as it calls 'try-install-man' and it, in turn, uses do-install-man. - Arnaldo > Signed-off-by: Konstantin Khlebnikov <khlebnikov@yandex-team.ru> > --- > tools/perf/Documentation/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/perf/Documentation/Makefile b/tools/perf/Documentation/Makefile > index 098cfb9ca8f0..db11478e30b4 100644 > --- a/tools/perf/Documentation/Makefile > +++ b/tools/perf/Documentation/Makefile > @@ -192,7 +192,7 @@ do-install-man: man > # $(INSTALL) -m 644 $(DOC_MAN5) $(DESTDIR)$(man5dir); \ > # $(INSTALL) -m 644 $(DOC_MAN7) $(DESTDIR)$(man7dir) > > -install-man: check-man-tools man > +install-man: check-man-tools man do-install-man > > ifdef missing_tools > DO_INSTALL_MAN = $(warning Please install $(missing_tools) to have the man pages installed)
[toc] | [prev] | [next] | [standalone]
| From | tip-bot for Konstantin Khlebnikov <tipbot@zytor.com> |
|---|---|
| Date | 2017-08-24 10:30 +0200 |
| Subject | [tip:perf/core] perf tools: Really install manpages via 'make install-man' |
| Message-ID | <uhVGx-405-5@gated-at.bofh.it> |
| In reply to | #1715925 |
Commit-ID: 2826478a6660158d261bc49ad8954a8f5c39be07
Gitweb: http://git.kernel.org/tip/2826478a6660158d261bc49ad8954a8f5c39be07
Author: Konstantin Khlebnikov <khlebnikov@yandex-team.ru>
AuthorDate: Sun, 20 Aug 2017 14:39:13 +0300
Committer: Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Tue, 22 Aug 2017 13:24:53 -0300
perf tools: Really install manpages via 'make install-man'
Target install-man builds them but forget to install.
Signed-off-by: Konstantin Khlebnikov <khlebnikov@yandex-team.ru>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Borislav Petkov <borislav.petkov@amd.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Fixes: af3df2cf17f5 ("perf tools: Try to build Documentation when installing")
Link: http://lkml.kernel.org/r/150322915300.129715.13645857235229756834.stgit@buzz
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/Documentation/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/Documentation/Makefile b/tools/perf/Documentation/Makefile
index 098cfb9..db11478 100644
--- a/tools/perf/Documentation/Makefile
+++ b/tools/perf/Documentation/Makefile
@@ -192,7 +192,7 @@ do-install-man: man
# $(INSTALL) -m 644 $(DOC_MAN5) $(DESTDIR)$(man5dir); \
# $(INSTALL) -m 644 $(DOC_MAN7) $(DESTDIR)$(man7dir)
-install-man: check-man-tools man
+install-man: check-man-tools man do-install-man
ifdef missing_tools
DO_INSTALL_MAN = $(warning Please install $(missing_tools) to have the man pages installed)
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web