Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1718678 > unrolled thread

[PATCH 1/2] <linux/uaccess.h>: Fix copy_in_user() declaration

Started byBart Van Assche <bart.vanassche@wdc.com>
First post2017-08-24 00:40 +0200
Last post2017-08-24 00:40 +0200
Articles 1 — 1 participant

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  [PATCH 1/2] <linux/uaccess.h>: Fix copy_in_user() declaration Bart Van Assche <bart.vanassche@wdc.com> - 2017-08-24 00:40 +0200

#1718678 — [PATCH 1/2] <linux/uaccess.h>: Fix copy_in_user() declaration

FromBart Van Assche <bart.vanassche@wdc.com>
Date2017-08-24 00:40 +0200
Subject[PATCH 1/2] <linux/uaccess.h>: Fix copy_in_user() declaration
Message-ID<uhMtz-6r1-17@gated-at.bofh.it>
copy_in_user() copies data from user-space address @from to user-
space address @to. Hence declare both @from and @to as user-space
pointers.

Fixes: commit d597580d3737 ("generic ...copy_..._user primitives")
Signed-off-by: Bart Van Assche <bart.vanassche@wdc.com>
Cc: <stable@vger.kernel.org>
---
 include/linux/uaccess.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/uaccess.h b/include/linux/uaccess.h
index acdd6f915a8d..20ef8e6ec2db 100644
--- a/include/linux/uaccess.h
+++ b/include/linux/uaccess.h
@@ -156,7 +156,7 @@ copy_to_user(void __user *to, const void *from, unsigned long n)
 }
 #ifdef CONFIG_COMPAT
 static __always_inline unsigned long __must_check
-copy_in_user(void __user *to, const void *from, unsigned long n)
+copy_in_user(void __user *to, const void __user *from, unsigned long n)
 {
 	might_fault();
 	if (access_ok(VERIFY_WRITE, to, n) && access_ok(VERIFY_READ, from, n))
-- 
2.14.0

[toc] | [standalone]


Back to top | Article view | linux.kernel


csiph-web