Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1718103 > unrolled thread
| Started by | Jiri Slaby <jslaby@suse.cz> |
|---|---|
| First post | 2017-08-23 09:30 +0200 |
| Last post | 2017-08-23 20:20 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Stable apply request [was: Bluetooth: bnep: fix possible might sleep error in bnep_session] Jiri Slaby <jslaby@suse.cz> - 2017-08-23 09:30 +0200
Re: Stable apply request David Miller <davem@davemloft.net> - 2017-08-23 20:10 +0200
Re: Stable apply request [was: Bluetooth: bnep: fix possible might sleep error in bnep_session] Marcel Holtmann <marcel@holtmann.org> - 2017-08-23 20:20 +0200
| From | Jiri Slaby <jslaby@suse.cz> |
|---|---|
| Date | 2017-08-23 09:30 +0200 |
| Subject | Stable apply request [was: Bluetooth: bnep: fix possible might sleep error in bnep_session] |
| Message-ID | <uhygW-5YE-15@gated-at.bofh.it> |
On 06/27/2017, 07:32 PM, Marcel Holtmann wrote:
>> It looks like bnep_session has same pattern as the issue reported in
>> old rfcomm:
>>
>> while (1) {
>> set_current_state(TASK_INTERRUPTIBLE);
>> if (condition)
>> break;
>> // may call might_sleep here
>> schedule();
>> }
>> __set_current_state(TASK_RUNNING);
>>
>> Which fixed at:
>> dfb2fae Bluetooth: Fix nested sleeps
>>
>> So let's fix it at the same way, also follow the suggestion of:
>> https://lwn.net/Articles/628628/
...
> all 3 patches have been applied to bluetooth-next tree.
Hi,
given users are hitting it in at least 4.4 and 4.12, can we have all
three in all stables where this applies?
5da8e47d849d Bluetooth: hidp: fix possible might sleep error in
hidp_session_thread
f06d977309d0 Bluetooth: cmtp: fix possible might sleep error in cmtp_session
25717382c1dd Bluetooth: bnep: fix possible might sleep error in bnep_session
I am not sure: to stable directly or via net stable?
thanks,
--
js
suse labs
[toc] | [next] | [standalone]
| From | David Miller <davem@davemloft.net> |
|---|---|
| Date | 2017-08-23 20:10 +0200 |
| Subject | Re: Stable apply request |
| Message-ID | <uhIgh-3UK-3@gated-at.bofh.it> |
| In reply to | #1718103 |
From: Jiri Slaby <jslaby@suse.cz>
Date: Wed, 23 Aug 2017 09:29:44 +0200
> On 06/27/2017, 07:32 PM, Marcel Holtmann wrote:
>>> It looks like bnep_session has same pattern as the issue reported in
>>> old rfcomm:
>>>
>>> while (1) {
>>> set_current_state(TASK_INTERRUPTIBLE);
>>> if (condition)
>>> break;
>>> // may call might_sleep here
>>> schedule();
>>> }
>>> __set_current_state(TASK_RUNNING);
>>>
>>> Which fixed at:
>>> dfb2fae Bluetooth: Fix nested sleeps
>>>
>>> So let's fix it at the same way, also follow the suggestion of:
>>> https://lwn.net/Articles/628628/
>
> ...
>
>> all 3 patches have been applied to bluetooth-next tree.
>
> Hi,
>
> given users are hitting it in at least 4.4 and 4.12, can we have all
> three in all stables where this applies?
>
> 5da8e47d849d Bluetooth: hidp: fix possible might sleep error in
> hidp_session_thread
> f06d977309d0 Bluetooth: cmtp: fix possible might sleep error in cmtp_session
> 25717382c1dd Bluetooth: bnep: fix possible might sleep error in bnep_session
>
> I am not sure: to stable directly or via net stable?
I generally let the wireless family handle their own -stable submissions
and that includes bluetooth.
[toc] | [prev] | [next] | [standalone]
| From | Marcel Holtmann <marcel@holtmann.org> |
|---|---|
| Date | 2017-08-23 20:20 +0200 |
| Subject | Re: Stable apply request [was: Bluetooth: bnep: fix possible might sleep error in bnep_session] |
| Message-ID | <uhIpX-3XR-3@gated-at.bofh.it> |
| In reply to | #1718103 |
Hi Jiri,
>>> It looks like bnep_session has same pattern as the issue reported in
>>> old rfcomm:
>>>
>>> while (1) {
>>> set_current_state(TASK_INTERRUPTIBLE);
>>> if (condition)
>>> break;
>>> // may call might_sleep here
>>> schedule();
>>> }
>>> __set_current_state(TASK_RUNNING);
>>>
>>> Which fixed at:
>>> dfb2fae Bluetooth: Fix nested sleeps
>>>
>>> So let's fix it at the same way, also follow the suggestion of:
>>> https://lwn.net/Articles/628628/
>
> ...
>
>> all 3 patches have been applied to bluetooth-next tree.
>
> Hi,
>
> given users are hitting it in at least 4.4 and 4.12, can we have all
> three in all stables where this applies?
>
> 5da8e47d849d Bluetooth: hidp: fix possible might sleep error in
> hidp_session_thread
> f06d977309d0 Bluetooth: cmtp: fix possible might sleep error in cmtp_session
> 25717382c1dd Bluetooth: bnep: fix possible might sleep error in bnep_session
>
> I am not sure: to stable directly or via net stable?
as Dave said, just email -stable directly and have Greg pick them up.
Regards
Marcel
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web