Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1718559 > unrolled thread
| Started by | Pavel Tatashin <pasha.tatashin@oracle.com> |
|---|---|
| First post | 2017-08-23 20:10 +0200 |
| Last post | 2017-08-24 14:30 +0200 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH v1 0/1] Reversed logic in memblock_discard Pavel Tatashin <pasha.tatashin@oracle.com> - 2017-08-23 20:10 +0200
[PATCH v1 1/1] mm: Reversed logic in memblock_discard Pavel Tatashin <pasha.tatashin@oracle.com> - 2017-08-23 20:10 +0200
Re: [PATCH v1 1/1] mm: Reversed logic in memblock_discard Vlastimil Babka <vbabka@suse.cz> - 2017-08-24 14:30 +0200
| From | Pavel Tatashin <pasha.tatashin@oracle.com> |
|---|---|
| Date | 2017-08-23 20:10 +0200 |
| Subject | [PATCH v1 0/1] Reversed logic in memblock_discard |
| Message-ID | <uhIgh-3UK-1@gated-at.bofh.it> |
One line fix for reversed logic where static array is freed instead of allocated one Pavel Tatashin (1): mm: Reversed logic in memblock_discard mm/memblock.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.14.1
[toc] | [next] | [standalone]
| From | Pavel Tatashin <pasha.tatashin@oracle.com> |
|---|---|
| Date | 2017-08-23 20:10 +0200 |
| Subject | [PATCH v1 1/1] mm: Reversed logic in memblock_discard |
| Message-ID | <uhIgi-3UK-21@gated-at.bofh.it> |
| In reply to | #1718559 |
In recently introduced memblock_discard() there is a reversed logic bug.
Memory is freed of static array instead of dynamically allocated one.
Fixes: 3010f876500f ("mm: discard memblock data later")
Reported-and-tested-by: Woody Suwalski <terraluna977@gmail.com>
Signed-off-by: Pavel Tatashin <pasha.tatashin@oracle.com>
---
mm/memblock.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/memblock.c b/mm/memblock.c
index bf14aea6ab70..91205780e6b1 100644
--- a/mm/memblock.c
+++ b/mm/memblock.c
@@ -299,7 +299,7 @@ void __init memblock_discard(void)
__memblock_free_late(addr, size);
}
- if (memblock.memory.regions == memblock_memory_init_regions) {
+ if (memblock.memory.regions != memblock_memory_init_regions) {
addr = __pa(memblock.memory.regions);
size = PAGE_ALIGN(sizeof(struct memblock_region) *
memblock.memory.max);
--
2.14.1
[toc] | [prev] | [next] | [standalone]
| From | Vlastimil Babka <vbabka@suse.cz> |
|---|---|
| Date | 2017-08-24 14:30 +0200 |
| Subject | Re: [PATCH v1 1/1] mm: Reversed logic in memblock_discard |
| Message-ID | <uhZqO-6v9-1@gated-at.bofh.it> |
| In reply to | #1718561 |
+CC stable
On 08/23/2017 08:04 PM, Pavel Tatashin wrote:
> In recently introduced memblock_discard() there is a reversed logic bug.
> Memory is freed of static array instead of dynamically allocated one.
>
> Fixes: 3010f876500f ("mm: discard memblock data later")
That patch was CC'd stable. So this one should be too. Looks like it the
original patch wasn't yet included in a stable release, so we can avoid
breakage.
> Reported-and-tested-by: Woody Suwalski <terraluna977@gmail.com>
> Signed-off-by: Pavel Tatashin <pasha.tatashin@oracle.com>
> ---
> mm/memblock.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/memblock.c b/mm/memblock.c
> index bf14aea6ab70..91205780e6b1 100644
> --- a/mm/memblock.c
> +++ b/mm/memblock.c
> @@ -299,7 +299,7 @@ void __init memblock_discard(void)
> __memblock_free_late(addr, size);
> }
>
> - if (memblock.memory.regions == memblock_memory_init_regions) {
> + if (memblock.memory.regions != memblock_memory_init_regions) {
> addr = __pa(memblock.memory.regions);
> size = PAGE_ALIGN(sizeof(struct memblock_region) *
> memblock.memory.max);
>
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web