Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1718365 > unrolled thread

[PATCH] seccomp: add missing semicolon

Back to article view | Back to linux.kernel

Contents

  [PATCH] seccomp: add missing semicolon Arnd Bergmann <arnd@arndb.de> - 2017-08-23 15:50 +0200
    Re: [PATCH] seccomp: add missing semicolon Kees Cook <keescook@chromium.org> - 2017-08-23 18:30 +0200
      Re: [PATCH] seccomp: add missing semicolon Tyler Hicks <tyhicks@canonical.com> - 2017-08-23 18:40 +0200

#1718365 — [PATCH] seccomp: add missing semicolon

We get a compile error without it, at least in some configurations:

kernel/seccomp.c:1221:1: error: expected ',' or ';' at end of input

Fixes: 8e5f1ad116df ("seccomp: Sysctl to display available actions")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 kernel/seccomp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/seccomp.c b/kernel/seccomp.c
index c24579dfa7a1..3eeb2257bd62 100644
--- a/kernel/seccomp.c
+++ b/kernel/seccomp.c
@@ -1218,6 +1218,6 @@ static int __init seccomp_sysctl_init(void)
 	return 0;
 }
 
-device_initcall(seccomp_sysctl_init)
+device_initcall(seccomp_sysctl_init);
 
 #endif /* CONFIG_SYSCTL */
-- 
2.9.0

[toc] | [next] | [standalone]

#1718503

On Wed, Aug 23, 2017 at 6:43 AM, Arnd Bergmann <arnd@arndb.de> wrote:
> We get a compile error without it, at least in some configurations:
>
> kernel/seccomp.c:1221:1: error: expected ',' or ';' at end of input
>
> Fixes: 8e5f1ad116df ("seccomp: Sysctl to display available actions")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Oh, how completely strange. I never saw this in my build testing. If
you have the .config that tripped this, please let me know.

James, can you take this for -next please?

Acked-by: Kees Cook <keescook@chromium.org>

Thanks!

-Kees

> ---
>  kernel/seccomp.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/seccomp.c b/kernel/seccomp.c
> index c24579dfa7a1..3eeb2257bd62 100644
> --- a/kernel/seccomp.c
> +++ b/kernel/seccomp.c
> @@ -1218,6 +1218,6 @@ static int __init seccomp_sysctl_init(void)
>         return 0;
>  }
>
> -device_initcall(seccomp_sysctl_init)
> +device_initcall(seccomp_sysctl_init);
>
>  #endif /* CONFIG_SYSCTL */
> --
> 2.9.0
>



-- 
Kees Cook
Pixel Security

[toc] | [prev] | [next] | [standalone]

#1718510

[Multipart message — attachments visible in raw view] — view raw

On 08/23/2017 11:20 AM, Kees Cook wrote:
> On Wed, Aug 23, 2017 at 6:43 AM, Arnd Bergmann <arnd@arndb.de> wrote:
>> We get a compile error without it, at least in some configurations:
>>
>> kernel/seccomp.c:1221:1: error: expected ',' or ';' at end of input
>>
>> Fixes: 8e5f1ad116df ("seccomp: Sysctl to display available actions")
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> 
> Oh, how completely strange. I never saw this in my build testing. If
> you have the .config that tripped this, please let me know.

Same here...

Thanks for the fix, Arnd!

Tyler

> 
> James, can you take this for -next please?
> 
> Acked-by: Kees Cook <keescook@chromium.org>
> 
> Thanks!
> 
> -Kees
> 
>> ---
>>  kernel/seccomp.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/kernel/seccomp.c b/kernel/seccomp.c
>> index c24579dfa7a1..3eeb2257bd62 100644
>> --- a/kernel/seccomp.c
>> +++ b/kernel/seccomp.c
>> @@ -1218,6 +1218,6 @@ static int __init seccomp_sysctl_init(void)
>>         return 0;
>>  }
>>
>> -device_initcall(seccomp_sysctl_init)
>> +device_initcall(seccomp_sysctl_init);
>>
>>  #endif /* CONFIG_SYSCTL */
>> --
>> 2.9.0
>>
> 
> 
> 

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web