Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1718362 > unrolled thread

[PATCH] ASoC: tegra: Remove superfluous 'machine' variable

Started byArnd Bergmann <arnd@arndb.de>
First post2017-08-23 15:50 +0200
Last post2017-08-23 16:30 +0200
Articles 3 — 2 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH] ASoC: tegra: Remove superfluous 'machine' variable Arnd Bergmann <arnd@arndb.de> - 2017-08-23 15:50 +0200
    Re: [PATCH] ASoC: tegra: Remove superfluous 'machine' variable Arnd Bergmann <arnd@arndb.de> - 2017-08-23 16:30 +0200
    Re: [PATCH] ASoC: tegra: Remove superfluous 'machine' variable Mark Brown <broonie@kernel.org> - 2017-08-23 16:30 +0200

#1718362 — [PATCH] ASoC: tegra: Remove superfluous 'machine' variable

FromArnd Bergmann <arnd@arndb.de>
Date2017-08-23 15:50 +0200
Subject[PATCH] ASoC: tegra: Remove superfluous 'machine' variable
Message-ID<uhEcG-1bd-13@gated-at.bofh.it>
The last cleanup left behind an unused variable:

sound/soc/tegra/tegra_wm8903.c: In function 'tegra_wm8903_remove':
sound/soc/tegra/tegra_wm8903.c:206:23: error: unused variable 'machine' [-Werror=unused-variable]

This removes it as welremoves it as welll

Fixes: 2a8bd83af30e ("ASoC: tegra: Remove superfluous snd_soc_jack_free_gpios() call")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 sound/soc/tegra/tegra_wm8903.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/sound/soc/tegra/tegra_wm8903.c b/sound/soc/tegra/tegra_wm8903.c
index 2384cb9cb95c..18bdae59a4df 100644
--- a/sound/soc/tegra/tegra_wm8903.c
+++ b/sound/soc/tegra/tegra_wm8903.c
@@ -203,7 +203,6 @@ static int tegra_wm8903_remove(struct snd_soc_card *card)
 		snd_soc_get_pcm_runtime(card, card->dai_link[0].name);
 	struct snd_soc_dai *codec_dai = rtd->codec_dai;
 	struct snd_soc_codec *codec = codec_dai->codec;
-	struct tegra_wm8903 *machine = snd_soc_card_get_drvdata(card);
 
 	wm8903_mic_detect(codec, NULL, 0, 0);
 
-- 
2.9.0

[toc] | [next] | [standalone]


#1718399

FromArnd Bergmann <arnd@arndb.de>
Date2017-08-23 16:30 +0200
Message-ID<uhEPn-1DV-1@gated-at.bofh.it>
In reply to#1718362
On Wed, Aug 23, 2017 at 4:21 PM, Mark Brown <broonie@kernel.org> wrote:
> On Wed, Aug 23, 2017 at 03:46:30PM +0200, Arnd Bergmann wrote:
>> The last cleanup left behind an unused variable:
>
> This doesn't apply against current code, please check and resend.

I built against today's linux-next, but you already applied the same fix this
morning after Stephen reported the problem.

     Arnd

[toc] | [prev] | [next] | [standalone]


#1718408

FromMark Brown <broonie@kernel.org>
Date2017-08-23 16:30 +0200
Message-ID<uhEPn-1DV-3@gated-at.bofh.it>
In reply to#1718362

[Multipart message — attachments visible in raw view] — view raw

On Wed, Aug 23, 2017 at 03:46:30PM +0200, Arnd Bergmann wrote:
> The last cleanup left behind an unused variable:

This doesn't apply against current code, please check and resend.

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web