Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1718200 > unrolled thread

Re: [PATCH 3/3] net: rsi: netlink: constify genl_ops

Started byKalle Valo <kvalo@codeaurora.org>
First post2017-08-23 12:10 +0200
Last post2017-08-23 12:10 +0200
Articles 2 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [PATCH 3/3] net: rsi: netlink: constify genl_ops Kalle Valo <kvalo@codeaurora.org> - 2017-08-23 12:10 +0200
    Re: [PATCH 3/3] net: rsi: netlink: constify genl_ops Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-23 12:10 +0200

#1718200 — Re: [PATCH 3/3] net: rsi: netlink: constify genl_ops

FromKalle Valo <kvalo@codeaurora.org>
Date2017-08-23 12:10 +0200
SubjectRe: [PATCH 3/3] net: rsi: netlink: constify genl_ops
Message-ID<uhALL-7CP-5@gated-at.bofh.it>
Arvind Yadav <arvind.yadav.cs@gmail.com> writes:

> genl_ops are not supposed to change at runtime. All functions
> working with genl_ops provided by <net/genetlink.h> work with
> const genl_ops. So mark the non-const structs as const.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> ---
>  net/tipc/netlink_compat.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Using the prefix "rsi:" looks wrong for this patch.

-- 
Kalle Valo

[toc] | [next] | [standalone]


#1718202

FromArvind Yadav <arvind.yadav.cs@gmail.com>
Date2017-08-23 12:10 +0200
Message-ID<uhALM-7CP-17@gated-at.bofh.it>
In reply to#1718200
Hi,


On Wednesday 23 August 2017 03:32 PM, Kalle Valo wrote:
> Arvind Yadav <arvind.yadav.cs@gmail.com> writes:
>
>> genl_ops are not supposed to change at runtime. All functions
>> working with genl_ops provided by <net/genetlink.h> work with
>> const genl_ops. So mark the non-const structs as const.
>>
>> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
>> ---
>>   net/tipc/netlink_compat.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
> Using the prefix "rsi:" looks wrong for this patch.
Thanks for pointing. I will update.
>
~arvind

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web