Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1715570 > unrolled thread
| Started by | Arvind Yadav <arvind.yadav.cs@gmail.com> |
|---|---|
| First post | 2017-08-19 09:00 +0200 |
| Last post | 2017-08-20 02:20 +0200 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH 0/5] constify net eisa_device_id Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-19 09:00 +0200
[PATCH 1/5] net: 3c509: constify eisa_device_id Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-19 09:00 +0200
Re: [PATCH 0/5] constify net eisa_device_id David Miller <davem@davemloft.net> - 2017-08-20 02:20 +0200
| From | Arvind Yadav <arvind.yadav.cs@gmail.com> |
|---|---|
| Date | 2017-08-19 09:00 +0200 |
| Subject | [PATCH 0/5] constify net eisa_device_id |
| Message-ID | <ug5TI-6lW-1@gated-at.bofh.it> |
eisa_device_id are not supposed to change at runtime. All functions working with eisa_device_id provided by <linux/eisa.h> work with const eisa_device_id. So mark the non-const structs as const. Arvind Yadav (5): [PATCH 1/5] net: 3c509: constify eisa_device_id [PATCH 2/5] net: 3c59x: constify eisa_device_id [PATCH 3/5] net: de4x5: constify eisa_device_id [PATCH 4/5] net: hp100: constify eisa_device_id [PATCH 5/5] net: defxx: constify eisa_device_id drivers/net/ethernet/3com/3c509.c | 2 +- drivers/net/ethernet/3com/3c59x.c | 2 +- drivers/net/ethernet/dec/tulip/de4x5.c | 2 +- drivers/net/ethernet/hp/hp100.c | 2 +- drivers/net/fddi/defxx.c | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) -- 2.7.4
[toc] | [next] | [standalone]
| From | Arvind Yadav <arvind.yadav.cs@gmail.com> |
|---|---|
| Date | 2017-08-19 09:00 +0200 |
| Subject | [PATCH 1/5] net: 3c509: constify eisa_device_id |
| Message-ID | <ug5TI-6lW-9@gated-at.bofh.it> |
| In reply to | #1715570 |
eisa_device_id are not supposed to change at runtime. All functions
working with eisa_device_id provided by <linux/eisa.h> work with
const eisa_device_id. So mark the non-const structs as const.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/net/ethernet/3com/3c509.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/3com/3c509.c b/drivers/net/ethernet/3com/3c509.c
index 077d01d..b223769 100644
--- a/drivers/net/ethernet/3com/3c509.c
+++ b/drivers/net/ethernet/3com/3c509.c
@@ -474,7 +474,7 @@ static int pnp_registered;
#endif /* CONFIG_PNP */
#ifdef CONFIG_EISA
-static struct eisa_device_id el3_eisa_ids[] = {
+static const struct eisa_device_id el3_eisa_ids[] = {
{ "TCM5090" },
{ "TCM5091" },
{ "TCM5092" },
--
2.7.4
[toc] | [prev] | [next] | [standalone]
| From | David Miller <davem@davemloft.net> |
|---|---|
| Date | 2017-08-20 02:20 +0200 |
| Message-ID | <ugm89-85n-1@gated-at.bofh.it> |
| In reply to | #1715570 |
From: Arvind Yadav <arvind.yadav.cs@gmail.com> Date: Sat, 19 Aug 2017 12:21:42 +0530 > eisa_device_id are not supposed to change at runtime. All functions > working with eisa_device_id provided by <linux/eisa.h> work with > const eisa_device_id. So mark the non-const structs as const. Series applied, thanks.
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web