Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1716402 > unrolled thread

Re: [PATCH] mmc: vub300: constify usb_device_id

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH] mmc: vub300: constify usb_device_id Ulf Hansson <ulf.hansson@linaro.org> - 2017-08-21 14:40 +0200

#1716402 — Re: [PATCH] mmc: vub300: constify usb_device_id

On 9 August 2017 at 19:50, Arvind Yadav <arvind.yadav.cs@gmail.com> wrote:
> usb_device_id are not supposed to change at runtime. All functions
> working with usb_device_id provided by <linux/usb.h> work with
> const usb_device_id. So mark the non-const structs as const.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>

Thanks, applied for next!

Kind regards
Uffe

> ---
>  drivers/mmc/host/vub300.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/vub300.c b/drivers/mmc/host/vub300.c
> index fbeea1a..6c99102 100644
> --- a/drivers/mmc/host/vub300.c
> +++ b/drivers/mmc/host/vub300.c
> @@ -266,7 +266,7 @@ MODULE_PARM_DESC(firmware_rom_wait_states,
>  #define ELAN_VENDOR_ID         0x2201
>  #define VUB300_VENDOR_ID       0x0424
>  #define VUB300_PRODUCT_ID      0x012C
> -static struct usb_device_id vub300_table[] = {
> +static const struct usb_device_id vub300_table[] = {
>         {USB_DEVICE(ELAN_VENDOR_ID, VUB300_PRODUCT_ID)},
>         {USB_DEVICE(VUB300_VENDOR_ID, VUB300_PRODUCT_ID)},
>         {} /* Terminating entry */
> --
> 2.7.4
>

[toc] | [standalone]

Back to top | Article view | linux.kernel

csiph-web