Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1711959 > unrolled thread

[PATCH 1/1] Revert "mfd: da9061: Fix to remove BBAT_CONT register from chip model"

Started byLee Jones <lee.jones@linaro.org>
First post2017-08-15 10:40 +0200
Last post2017-08-23 10:00 +0200
Articles 4 — 2 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH 1/1] Revert "mfd: da9061: Fix to remove BBAT_CONT register from chip model" Lee Jones <lee.jones@linaro.org> - 2017-08-15 10:40 +0200
    Re: [PATCH 1/1] Revert "mfd: da9061: Fix to remove BBAT_CONT  register from chip model" Lee Jones <lee.jones@linaro.org> - 2017-08-21 09:50 +0200
      RE: [PATCH 1/1] Revert "mfd: da9061: Fix to remove BBAT_CONT  register from chip model" Steve Twiss <stwiss.opensource@diasemi.com> - 2017-08-21 14:40 +0200
        Re: [PATCH 1/1] Revert "mfd: da9061: Fix to remove BBAT_CONT  register from chip model" Lee Jones <lee.jones@linaro.org> - 2017-08-23 10:00 +0200

#1711959 — [PATCH 1/1] Revert "mfd: da9061: Fix to remove BBAT_CONT register from chip model"

FromLee Jones <lee.jones@linaro.org>
Date2017-08-15 10:40 +0200
Subject[PATCH 1/1] Revert "mfd: da9061: Fix to remove BBAT_CONT register from chip model"
Message-ID<ueFyi-7nU-17@gated-at.bofh.it>
This patch was applied to the MFD twice, causing unwanted behavour.

This reverts commit b77eb79acca3203883e8d8dbc7f2b842def1bff8.

Fixes: b77eb79acca3 ("mfd: da9061: Fix to remove BBAT_CONT register from chip model")
Reported-by: Steve Twiss <stwiss.opensource@diasemi.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
 drivers/mfd/da9062-core.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/mfd/da9062-core.c b/drivers/mfd/da9062-core.c
index fbe0f245ce8e..fe1811523e4a 100644
--- a/drivers/mfd/da9062-core.c
+++ b/drivers/mfd/da9062-core.c
@@ -645,6 +645,9 @@ static const struct regmap_range da9062_aa_readable_ranges[] = {
 		.range_min = DA9062AA_VLDO1_B,
 		.range_max = DA9062AA_VLDO4_B,
 	}, {
+		.range_min = DA9062AA_BBAT_CONT,
+		.range_max = DA9062AA_BBAT_CONT,
+	}, {
 		.range_min = DA9062AA_INTERFACE,
 		.range_max = DA9062AA_CONFIG_E,
 	}, {
@@ -721,6 +724,9 @@ static const struct regmap_range da9062_aa_writeable_ranges[] = {
 		.range_min = DA9062AA_VLDO1_B,
 		.range_max = DA9062AA_VLDO4_B,
 	}, {
+		.range_min = DA9062AA_BBAT_CONT,
+		.range_max = DA9062AA_BBAT_CONT,
+	}, {
 		.range_min = DA9062AA_GP_ID_0,
 		.range_max = DA9062AA_GP_ID_19,
 	},
-- 
2.11.0

[toc] | [next] | [standalone]

#1716137 — Re: [PATCH 1/1] Revert "mfd: da9061: Fix to remove BBAT_CONT register from chip model"

FromLee Jones <lee.jones@linaro.org>
Date2017-08-21 09:50 +0200
SubjectRe: [PATCH 1/1] Revert "mfd: da9061: Fix to remove BBAT_CONT register from chip model"
Message-ID<ugPDb-1pc-5@gated-at.bofh.it>
In reply to#1711959
On Tue, 15 Aug 2017, Lee Jones wrote:

> This patch was applied to the MFD twice, causing unwanted behavour.
> 
> This reverts commit b77eb79acca3203883e8d8dbc7f2b842def1bff8.
> 
> Fixes: b77eb79acca3 ("mfd: da9061: Fix to remove BBAT_CONT register from chip model")
> Reported-by: Steve Twiss <stwiss.opensource@diasemi.com>
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
> ---
>  drivers/mfd/da9062-core.c | 6 ++++++
>  1 file changed, 6 insertions(+)

Steve, It would be good to obtain a {Reviewed|Acked}-by from you
before applying.

> diff --git a/drivers/mfd/da9062-core.c b/drivers/mfd/da9062-core.c
> index fbe0f245ce8e..fe1811523e4a 100644
> --- a/drivers/mfd/da9062-core.c
> +++ b/drivers/mfd/da9062-core.c
> @@ -645,6 +645,9 @@ static const struct regmap_range da9062_aa_readable_ranges[] = {
>  		.range_min = DA9062AA_VLDO1_B,
>  		.range_max = DA9062AA_VLDO4_B,
>  	}, {
> +		.range_min = DA9062AA_BBAT_CONT,
> +		.range_max = DA9062AA_BBAT_CONT,
> +	}, {
>  		.range_min = DA9062AA_INTERFACE,
>  		.range_max = DA9062AA_CONFIG_E,
>  	}, {
> @@ -721,6 +724,9 @@ static const struct regmap_range da9062_aa_writeable_ranges[] = {
>  		.range_min = DA9062AA_VLDO1_B,
>  		.range_max = DA9062AA_VLDO4_B,
>  	}, {
> +		.range_min = DA9062AA_BBAT_CONT,
> +		.range_max = DA9062AA_BBAT_CONT,
> +	}, {
>  		.range_min = DA9062AA_GP_ID_0,
>  		.range_max = DA9062AA_GP_ID_19,
>  	},

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

[toc] | [prev] | [next] | [standalone]

#1716401 — RE: [PATCH 1/1] Revert "mfd: da9061: Fix to remove BBAT_CONT register from chip model"

FromSteve Twiss <stwiss.opensource@diasemi.com>
Date2017-08-21 14:40 +0200
SubjectRE: [PATCH 1/1] Revert "mfd: da9061: Fix to remove BBAT_CONT register from chip model"
Message-ID<ugU9Q-4ml-19@gated-at.bofh.it>
In reply to#1716137
On 21 August 2017 08:50, Lee Jones wrote:

Hi Lee,

> To: Steve Twiss
> Cc: linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH 1/1] Revert "mfd: da9061: Fix to remove BBAT_CONT register from chip model"
> 
> On Tue, 15 Aug 2017, Lee Jones wrote:
> 
> > This patch was applied to the MFD twice, causing unwanted behavour.
> >
> > This reverts commit b77eb79acca3203883e8d8dbc7f2b842def1bff8.
> >
> > Fixes: b77eb79acca3 ("mfd: da9061: Fix to remove BBAT_CONT register from chip model")
> > Reported-by: Steve Twiss <stwiss.opensource@diasemi.com>
> > Signed-off-by: Lee Jones <lee.jones@linaro.org>
> > ---
> >  drivers/mfd/da9062-core.c | 6 ++++++
> >  1 file changed, 6 insertions(+)
> 
> Steve, It would be good to obtain a {Reviewed|Acked}-by from you
> before applying.
>

Sure.

> > diff --git a/drivers/mfd/da9062-core.c b/drivers/mfd/da9062-core.c
> > index fbe0f245ce8e..fe1811523e4a 100644
> > --- a/drivers/mfd/da9062-core.c
> > +++ b/drivers/mfd/da9062-core.c
> > @@ -645,6 +645,9 @@ static const struct regmap_range da9062_aa_readable_ranges[] = {
> >  		.range_min = DA9062AA_VLDO1_B,
> >  		.range_max = DA9062AA_VLDO4_B,
> >  	}, {
> > +		.range_min = DA9062AA_BBAT_CONT,
> > +		.range_max = DA9062AA_BBAT_CONT,
> > +	}, {
> >  		.range_min = DA9062AA_INTERFACE,
> >  		.range_max = DA9062AA_CONFIG_E,
> >  	}, {
> > @@ -721,6 +724,9 @@ static const struct regmap_range da9062_aa_writeable_ranges[] = {
> >  		.range_min = DA9062AA_VLDO1_B,
> >  		.range_max = DA9062AA_VLDO4_B,
> >  	}, {
> > +		.range_min = DA9062AA_BBAT_CONT,
> > +		.range_max = DA9062AA_BBAT_CONT,
> > +	}, {
> >  		.range_min = DA9062AA_GP_ID_0,
> >  		.range_max = DA9062AA_GP_ID_19,
> >  	},

This looks good. Thanks for the changes.

Reviewed-by: Steve Twiss <stwiss.opensource@diasemi.com>
Acked-by: Steve Twiss <stwiss.opensource@diasemi.com>

Regards,
Steve

[toc] | [prev] | [next] | [standalone]

#1718122 — Re: [PATCH 1/1] Revert "mfd: da9061: Fix to remove BBAT_CONT register from chip model"

FromLee Jones <lee.jones@linaro.org>
Date2017-08-23 10:00 +0200
SubjectRe: [PATCH 1/1] Revert "mfd: da9061: Fix to remove BBAT_CONT register from chip model"
Message-ID<uhyJY-69D-9@gated-at.bofh.it>
In reply to#1716401
On Mon, 21 Aug 2017, Steve Twiss wrote:

> On 21 August 2017 08:50, Lee Jones wrote:
> 
> Hi Lee,
> 
> > To: Steve Twiss
> > Cc: linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org
> > Subject: Re: [PATCH 1/1] Revert "mfd: da9061: Fix to remove BBAT_CONT register from chip model"
> > 
> > On Tue, 15 Aug 2017, Lee Jones wrote:
> > 
> > > This patch was applied to the MFD twice, causing unwanted behavour.
> > >
> > > This reverts commit b77eb79acca3203883e8d8dbc7f2b842def1bff8.
> > >
> > > Fixes: b77eb79acca3 ("mfd: da9061: Fix to remove BBAT_CONT register from chip model")
> > > Reported-by: Steve Twiss <stwiss.opensource@diasemi.com>
> > > Signed-off-by: Lee Jones <lee.jones@linaro.org>
> > > ---
> > >  drivers/mfd/da9062-core.c | 6 ++++++
> > >  1 file changed, 6 insertions(+)
> > 
> > Steve, It would be good to obtain a {Reviewed|Acked}-by from you
> > before applying.
> >
> 
> Sure.
> 
> > > diff --git a/drivers/mfd/da9062-core.c b/drivers/mfd/da9062-core.c
> > > index fbe0f245ce8e..fe1811523e4a 100644
> > > --- a/drivers/mfd/da9062-core.c
> > > +++ b/drivers/mfd/da9062-core.c
> > > @@ -645,6 +645,9 @@ static const struct regmap_range da9062_aa_readable_ranges[] = {
> > >  		.range_min = DA9062AA_VLDO1_B,
> > >  		.range_max = DA9062AA_VLDO4_B,
> > >  	}, {
> > > +		.range_min = DA9062AA_BBAT_CONT,
> > > +		.range_max = DA9062AA_BBAT_CONT,
> > > +	}, {
> > >  		.range_min = DA9062AA_INTERFACE,
> > >  		.range_max = DA9062AA_CONFIG_E,
> > >  	}, {
> > > @@ -721,6 +724,9 @@ static const struct regmap_range da9062_aa_writeable_ranges[] = {
> > >  		.range_min = DA9062AA_VLDO1_B,
> > >  		.range_max = DA9062AA_VLDO4_B,
> > >  	}, {
> > > +		.range_min = DA9062AA_BBAT_CONT,
> > > +		.range_max = DA9062AA_BBAT_CONT,
> > > +	}, {
> > >  		.range_min = DA9062AA_GP_ID_0,
> > >  		.range_max = DA9062AA_GP_ID_19,
> > >  	},
> 
> This looks good. Thanks for the changes.
> 
> Reviewed-by: Steve Twiss <stwiss.opensource@diasemi.com>
> Acked-by: Steve Twiss <stwiss.opensource@diasemi.com>

Patch now send to Mainline for v4.13 fixes.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web