Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1715637 > unrolled thread

[PATCH] net: dsa: mv88e6xxx: make irq_chip const

Started byBhumika Goyal <bhumirks@gmail.com>
First post2017-08-19 13:00 +0200
Last post2017-08-21 05:10 +0200
Articles 3 — 3 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH] net: dsa: mv88e6xxx: make irq_chip const Bhumika Goyal <bhumirks@gmail.com> - 2017-08-19 13:00 +0200
    Re: [PATCH] net: dsa: mv88e6xxx: make irq_chip const Andrew Lunn <andrew@lunn.ch> - 2017-08-19 15:30 +0200
    Re: [PATCH] net: dsa: mv88e6xxx: make irq_chip const David Miller <davem@davemloft.net> - 2017-08-21 05:10 +0200

#1715637 — [PATCH] net: dsa: mv88e6xxx: make irq_chip const

FromBhumika Goyal <bhumirks@gmail.com>
Date2017-08-19 13:00 +0200
Subject[PATCH] net: dsa: mv88e6xxx: make irq_chip const
Message-ID<ug9DY-gQ-11@gated-at.bofh.it>
Make this const as it is only used in a copy operation.
Done using Coccinelle.

Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
---
 drivers/net/dsa/mv88e6xxx/chip.c    | 2 +-
 drivers/net/dsa/mv88e6xxx/global2.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/dsa/mv88e6xxx/chip.c b/drivers/net/dsa/mv88e6xxx/chip.c
index 918d8f0..c6678aa 100644
--- a/drivers/net/dsa/mv88e6xxx/chip.c
+++ b/drivers/net/dsa/mv88e6xxx/chip.c
@@ -307,7 +307,7 @@ static void mv88e6xxx_g1_irq_bus_sync_unlock(struct irq_data *d)
 	mutex_unlock(&chip->reg_lock);
 }
 
-static struct irq_chip mv88e6xxx_g1_irq_chip = {
+static const struct irq_chip mv88e6xxx_g1_irq_chip = {
 	.name			= "mv88e6xxx-g1",
 	.irq_mask		= mv88e6xxx_g1_irq_mask,
 	.irq_unmask		= mv88e6xxx_g1_irq_unmask,
diff --git a/drivers/net/dsa/mv88e6xxx/global2.c b/drivers/net/dsa/mv88e6xxx/global2.c
index 16f5562..af07278 100644
--- a/drivers/net/dsa/mv88e6xxx/global2.c
+++ b/drivers/net/dsa/mv88e6xxx/global2.c
@@ -1019,7 +1019,7 @@ static void mv88e6xxx_g2_irq_bus_sync_unlock(struct irq_data *d)
 	mutex_unlock(&chip->reg_lock);
 }
 
-static struct irq_chip mv88e6xxx_g2_irq_chip = {
+static const struct irq_chip mv88e6xxx_g2_irq_chip = {
 	.name			= "mv88e6xxx-g2",
 	.irq_mask		= mv88e6xxx_g2_irq_mask,
 	.irq_unmask		= mv88e6xxx_g2_irq_unmask,
-- 
1.9.1

[toc] | [next] | [standalone]


#1715667

FromAndrew Lunn <andrew@lunn.ch>
Date2017-08-19 15:30 +0200
Message-ID<ugbZ7-1PQ-9@gated-at.bofh.it>
In reply to#1715637
On Sat, Aug 19, 2017 at 04:25:52PM +0530, Bhumika Goyal wrote:
> Make this const as it is only used in a copy operation.
> Done using Coccinelle.
> 
> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew

[toc] | [prev] | [next] | [standalone]


#1716079

FromDavid Miller <davem@davemloft.net>
Date2017-08-21 05:10 +0200
Message-ID<ugLgd-7f3-7@gated-at.bofh.it>
In reply to#1715637
From: Bhumika Goyal <bhumirks@gmail.com>
Date: Sat, 19 Aug 2017 16:25:52 +0530

> Make this const as it is only used in a copy operation.
> Done using Coccinelle.
> 
> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>

Applied to net-next, thanks.

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web