Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1715893 > unrolled thread
| Started by | Julia Lawall <julia.lawall@lip6.fr> |
|---|---|
| First post | 2017-08-20 11:20 +0200 |
| Last post | 2017-08-20 22:40 +0200 |
| Articles | 4 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] input/keyboard: fix platform_no_drv_owner.cocci warnings Julia Lawall <julia.lawall@lip6.fr> - 2017-08-20 11:20 +0200
Re: [PATCH] input/keyboard: fix platform_no_drv_owner.cocci warnings Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2017-08-20 18:30 +0200
Re: [PATCH] input/keyboard: fix platform_no_drv_owner.cocci warnings Julia Lawall <julia.lawall@lip6.fr> - 2017-08-20 18:50 +0200
Re: [PATCH] input/keyboard: fix platform_no_drv_owner.cocci warnings Takashi Iwai <tiwai@suse.de> - 2017-08-20 22:40 +0200
| From | Julia Lawall <julia.lawall@lip6.fr> |
|---|---|
| Date | 2017-08-20 11:20 +0200 |
| Subject | [PATCH] input/keyboard: fix platform_no_drv_owner.cocci warnings |
| Message-ID | <uguyJ-52R-5@gated-at.bofh.it> |
No need to set .owner here. The core will do it.
Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci
Fixes: 52cf590518d7 ("input/keyboard: Add support for Dollar Cove TI power button")
Signed-off-by: Julia Lawall <julia.lawall@lip6.fr>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
dc_ti_pwrbtn.c | 1 -
1 file changed, 1 deletion(-)
--- a/drivers/input/keyboard/dc_ti_pwrbtn.c
+++ b/drivers/input/keyboard/dc_ti_pwrbtn.c
@@ -75,7 +75,6 @@ static int dc_ti_pwrbtn_probe(struct pla
static struct platform_driver dc_ti_pwrbtn_driver = {
.driver = {
.name = DRIVER_NAME,
- .owner = THIS_MODULE,
},
.probe = dc_ti_pwrbtn_probe,
};
[toc] | [next] | [standalone]
| From | Dmitry Torokhov <dmitry.torokhov@gmail.com> |
|---|---|
| Date | 2017-08-20 18:30 +0200 |
| Message-ID | <ugBgS-Qz-11@gated-at.bofh.it> |
| In reply to | #1715893 |
On Sun, Aug 20, 2017 at 11:19:38AM +0200, Julia Lawall wrote:
> No need to set .owner here. The core will do it.
>
> Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci
>
> Fixes: 52cf590518d7 ("input/keyboard: Add support for Dollar Cove TI power button")
> Signed-off-by: Julia Lawall <julia.lawall@lip6.fr>
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> ---
>
> dc_ti_pwrbtn.c | 1 -
Hm, this driver is neither in my tree nor in next; where is it coming
from?
> 1 file changed, 1 deletion(-)
>
> --- a/drivers/input/keyboard/dc_ti_pwrbtn.c
> +++ b/drivers/input/keyboard/dc_ti_pwrbtn.c
> @@ -75,7 +75,6 @@ static int dc_ti_pwrbtn_probe(struct pla
> static struct platform_driver dc_ti_pwrbtn_driver = {
> .driver = {
> .name = DRIVER_NAME,
> - .owner = THIS_MODULE,
> },
> .probe = dc_ti_pwrbtn_probe,
> };
--
Dmitry
[toc] | [prev] | [next] | [standalone]
| From | Julia Lawall <julia.lawall@lip6.fr> |
|---|---|
| Date | 2017-08-20 18:50 +0200 |
| Subject | Re: [PATCH] input/keyboard: fix platform_no_drv_owner.cocci warnings |
| Message-ID | <ugBAe-Z0-5@gated-at.bofh.it> |
| In reply to | #1715956 |
On Sun, 20 Aug 2017, Dmitry Torokhov wrote:
> On Sun, Aug 20, 2017 at 11:19:38AM +0200, Julia Lawall wrote:
> > No need to set .owner here. The core will do it.
> >
> > Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci
> >
> > Fixes: 52cf590518d7 ("input/keyboard: Add support for Dollar Cove TI power button")
> > Signed-off-by: Julia Lawall <julia.lawall@lip6.fr>
> > Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> > ---
> >
> > dc_ti_pwrbtn.c | 1 -
>
> Hm, this driver is neither in my tree nor in next; where is it coming
> from?
Sorry, it's a kbuild message and I seem to have deleted the message with
that information...
julia
>
> > 1 file changed, 1 deletion(-)
> >
> > --- a/drivers/input/keyboard/dc_ti_pwrbtn.c
> > +++ b/drivers/input/keyboard/dc_ti_pwrbtn.c
> > @@ -75,7 +75,6 @@ static int dc_ti_pwrbtn_probe(struct pla
> > static struct platform_driver dc_ti_pwrbtn_driver = {
> > .driver = {
> > .name = DRIVER_NAME,
> > - .owner = THIS_MODULE,
> > },
> > .probe = dc_ti_pwrbtn_probe,
> > };
>
> --
> Dmitry
>
[toc] | [prev] | [next] | [standalone]
| From | Takashi Iwai <tiwai@suse.de> |
|---|---|
| Date | 2017-08-20 22:40 +0200 |
| Message-ID | <ugFaO-3fW-9@gated-at.bofh.it> |
| In reply to | #1715956 |
On Sun, 20 Aug 2017 18:28:41 +0200,
Dmitry Torokhov wrote:
>
> On Sun, Aug 20, 2017 at 11:19:38AM +0200, Julia Lawall wrote:
> > No need to set .owner here. The core will do it.
> >
> > Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci
> >
> > Fixes: 52cf590518d7 ("input/keyboard: Add support for Dollar Cove TI power button")
> > Signed-off-by: Julia Lawall <julia.lawall@lip6.fr>
> > Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> > ---
> >
> > dc_ti_pwrbtn.c | 1 -
>
> Hm, this driver is neither in my tree nor in next; where is it coming
> from?
It's only in my tree for testing, but kbuild bot takes all branches
unconditionally, so...
In anyway, I hope I can submit sooner or later :)
Takashi
>
> > 1 file changed, 1 deletion(-)
> >
> > --- a/drivers/input/keyboard/dc_ti_pwrbtn.c
> > +++ b/drivers/input/keyboard/dc_ti_pwrbtn.c
> > @@ -75,7 +75,6 @@ static int dc_ti_pwrbtn_probe(struct pla
> > static struct platform_driver dc_ti_pwrbtn_driver = {
> > .driver = {
> > .name = DRIVER_NAME,
> > - .owner = THIS_MODULE,
> > },
> > .probe = dc_ti_pwrbtn_probe,
> > };
>
> --
> Dmitry
>
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web