Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1714269 > unrolled thread

Re: [PATCH] staging: olpc_dcon: Fix coding style issue caught bycheckpatch.pl related to function name in debug print

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH] staging: olpc_dcon: Fix coding style issue caught  bycheckpatch.pl related to function name in debug print Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-08-17 20:10 +0200

#1714269 — Re: [PATCH] staging: olpc_dcon: Fix coding style issue caught bycheckpatch.pl related to function name in debug print

On Sun, Aug 06, 2017 at 12:12:47AM +0800, 张树荣 wrote:
> Replace hard-coded function names in strings with "%s", __func__
>     in the olpc_dcon.c file. Issue found by checkpatch.pl.

Your subject line is too long :(

> 
> Signed-off-by: Marvin Zhang <MarvinZhang.kernel@gmail.com>
> ---
>  drivers/staging/olpc_dcon/olpc_dcon.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/olpc_dcon/olpc_dcon.c
> b/drivers/staging/olpc_dcon/olpc_dcon.c
> index f7f3a78..429ca58 100644
> --- a/drivers/staging/olpc_dcon/olpc_dcon.c
> +++ b/drivers/staging/olpc_dcon/olpc_dcon.c
> @@ -456,7 +456,7 @@ static ssize_t dcon_freeze_store(struct device *dev,
>   if (ret)
>   return ret;
> 
> - pr_info("dcon_freeze_store: %lu\n", output);
> + pr_info("%s: %lu\n",__func__, output);

Your patch is corrupted and can not be applied :(

Please fix up and resend.

thanks,

greg k-h

[toc] | [standalone]

Back to top | Article view | linux.kernel

csiph-web