Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1714083 > unrolled thread

[PATCH 1/2] lockd: Delete an error message for a failed memory allocation in reclaimer()

Started bySF Markus Elfring <elfring@users.sourceforge.net>
First post2017-08-17 16:40 +0200
Last post2017-08-17 16:40 +0200
Articles 1 — 1 participant

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  [PATCH 1/2] lockd: Delete an error message for a failed memory  allocation in reclaimer() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-08-17 16:40 +0200

#1714083 — [PATCH 1/2] lockd: Delete an error message for a failed memory allocation in reclaimer()

FromSF Markus Elfring <elfring@users.sourceforge.net>
Date2017-08-17 16:40 +0200
Subject[PATCH 1/2] lockd: Delete an error message for a failed memory allocation in reclaimer()
Message-ID<ufu7L-67i-1@gated-at.bofh.it>
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Wed, 16 Aug 2017 22:35:24 +0200

Omit an extra message for a memory allocation failure in this function.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 fs/lockd/clntlock.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/fs/lockd/clntlock.c b/fs/lockd/clntlock.c
index 27d577dbe51a..96c1d14c18f1 100644
--- a/fs/lockd/clntlock.c
+++ b/fs/lockd/clntlock.c
@@ -235,12 +235,8 @@ reclaimer(void *ptr)
 	struct net *net = host->net;
 
 	req = kmalloc(sizeof(*req), GFP_KERNEL);
-	if (!req) {
-		printk(KERN_ERR "lockd: reclaimer unable to alloc memory."
-				" Locks for %s won't be reclaimed!\n",
-				host->h_name);
+	if (!req)
 		return 0;
-	}
 
 	allow_signal(SIGKILL);
 
-- 
2.14.0

[toc] | [standalone]


Back to top | Article view | linux.kernel


csiph-web