Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1714029 > unrolled thread
| Started by | Arvind Yadav <arvind.yadav.cs@gmail.com> |
|---|---|
| First post | 2017-08-17 15:30 +0200 |
| Last post | 2017-08-17 19:20 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] net: ibm: ibmveth: constify vio_device_id Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-17 15:30 +0200
Re: [PATCH] net: ibm: ibmveth: constify vio_device_id David Miller <davem@davemloft.net> - 2017-08-17 19:20 +0200
| From | Arvind Yadav <arvind.yadav.cs@gmail.com> |
|---|---|
| Date | 2017-08-17 15:30 +0200 |
| Subject | [PATCH] net: ibm: ibmveth: constify vio_device_id |
| Message-ID | <uft22-5re-7@gated-at.bofh.it> |
vio_device_id are not supposed to change at runtime. All functions
working with vio_device_id provided by <asm/vio.h> work with
const vio_device_id. So mark the non-const structs as const.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/net/ethernet/ibm/ibmveth.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/ibm/ibmveth.c b/drivers/net/ethernet/ibm/ibmveth.c
index d17c2b0..f210398 100644
--- a/drivers/net/ethernet/ibm/ibmveth.c
+++ b/drivers/net/ethernet/ibm/ibmveth.c
@@ -1897,7 +1897,7 @@ static int ibmveth_resume(struct device *dev)
return 0;
}
-static struct vio_device_id ibmveth_device_table[] = {
+static const struct vio_device_id ibmveth_device_table[] = {
{ "network", "IBM,l-lan"},
{ "", "" }
};
--
2.7.4
[toc] | [next] | [standalone]
| From | David Miller <davem@davemloft.net> |
|---|---|
| Date | 2017-08-17 19:20 +0200 |
| Message-ID | <ufwCB-7Vp-3@gated-at.bofh.it> |
| In reply to | #1714029 |
From: Arvind Yadav <arvind.yadav.cs@gmail.com> Date: Thu, 17 Aug 2017 18:52:53 +0530 > vio_device_id are not supposed to change at runtime. All functions > working with vio_device_id provided by <asm/vio.h> work with > const vio_device_id. So mark the non-const structs as const. > > Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com> Applied.
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web