Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1713842 > unrolled thread

[PATCH 00/30] constify input serio_device_id

Started byArvind Yadav <arvind.yadav.cs@gmail.com>
First post2017-08-17 13:40 +0200
Last post2017-08-20 18:40 +0200
Articles 9 on this page of 29 — 2 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH 00/30] constify input serio_device_id Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-17 13:40 +0200
    [PATCH 02/30] Input: magellan: constify serio_device_id Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-17 13:40 +0200
    [PATCH 09/30] Input: iatkbd: constify serio_device_id Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-17 13:50 +0200
    [PATCH 11/30] Input: lkkbd: constify serio_device_id Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-17 13:50 +0200
    [PATCH 25/30] Input: penmount: constify serio_device_id Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-17 13:50 +0200
    [PATCH 18/30] Input: dynapro: constify serio_device_id Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-17 13:50 +0200
    [PATCH 03/30] Input: spaceball: constify serio_device_id Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-17 13:50 +0200
    [PATCH 22/30] Input: hampshire: constify serio_device_id Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-17 13:50 +0200
    [PATCH 26/30] Input: touchit213: constify serio_device_id Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-17 13:50 +0200
    [PATCH 12/30] Input: newtonkbd: constify serio_device_id Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-17 13:50 +0200
    [PATCH 27/30] Input: touchright: constify serio_device_id Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-17 13:50 +0200
    [PATCH 08/30] Input: zhenhua: constify serio_device_id Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-17 13:50 +0200
    [PATCH 07/30] Input: warrior: constify serio_device_id Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-17 13:50 +0200
    [PATCH 17/30] Input: wacom_serial4: constify serio_device_id Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-17 13:50 +0200
    [PATCH 13/30] Input: stowaway: constify serio_device_id Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-17 13:50 +0200
    [PATCH 16/30] Input: serio: constify serio_device_id Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-17 13:50 +0200
    [PATCH 20/30] Input: fujitsu_ts: constify serio_device_id Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-17 13:50 +0200
    [PATCH 24/30] Input: mtouch: constify serio_device_id Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-17 13:50 +0200
    [PATCH 01/30] Input: iforce: constify serio_device_id Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-17 13:50 +0200
    [PATCH 14/30] Input: sunkbd: constify serio_device_id Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-17 13:50 +0200
    [PATCH 10/30] Input: hil_kbd: constify serio_device_id Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-17 13:50 +0200
    [PATCH 28/30] Input: touchwin: constify serio_device_id Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-17 13:50 +0200
    [PATCH 21/30] Input: gunze: constify serio_device_id Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-17 13:50 +0200
    [PATCH 30/30] Input: wacom_w8001: constify serio_device_id Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-17 13:50 +0200
    [PATCH 05/30] Input: stinger: constify serio_device_id Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-17 13:50 +0200
    [PATCH 23/30] Input: inexio: constify serio_device_id Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-17 13:50 +0200
    [PATCH 29/30] Input: tsc40: constify serio_device_id Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-17 13:50 +0200
    [PATCH 19/30] Input: elo: constify serio_device_id Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-17 13:50 +0200
    Re: [PATCH 00/30] constify input serio_device_id Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2017-08-20 18:40 +0200

Page 2 of 2 — ← Prev page 1 [2]

#1713864 — [PATCH 10/30] Input: hil_kbd: constify serio_device_id

FromArvind Yadav <arvind.yadav.cs@gmail.com>
Date2017-08-17 13:50 +0200
Subject[PATCH 10/30] Input: hil_kbd: constify serio_device_id
Message-ID<ufrth-4hy-49@gated-at.bofh.it>
In reply to#1713842
serio_device_id are not supposed to change at runtime. All functions
working with serio_device_id provided by <linux/serio.h> work with
const serio_device_id. So mark the non-const structs as const.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
 drivers/input/keyboard/hil_kbd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/input/keyboard/hil_kbd.c b/drivers/input/keyboard/hil_kbd.c
index 5b152f2..bb29a7c 100644
--- a/drivers/input/keyboard/hil_kbd.c
+++ b/drivers/input/keyboard/hil_kbd.c
@@ -559,7 +559,7 @@ static int hil_dev_connect(struct serio *serio, struct serio_driver *drv)
 	return error;
 }
 
-static struct serio_device_id hil_dev_ids[] = {
+static const struct serio_device_id hil_dev_ids[] = {
 	{
 		.type = SERIO_HIL_MLC,
 		.proto = SERIO_HIL,
-- 
2.7.4

[toc] | [prev] | [next] | [standalone]

#1713866 — [PATCH 28/30] Input: touchwin: constify serio_device_id

FromArvind Yadav <arvind.yadav.cs@gmail.com>
Date2017-08-17 13:50 +0200
Subject[PATCH 28/30] Input: touchwin: constify serio_device_id
Message-ID<ufrth-4hy-53@gated-at.bofh.it>
In reply to#1713842
serio_device_id are not supposed to change at runtime. All functions
working with serio_device_id provided by <linux/serio.h> work with
const serio_device_id. So mark the non-const structs as const.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
 drivers/input/touchscreen/touchwin.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/input/touchscreen/touchwin.c b/drivers/input/touchscreen/touchwin.c
index ba90f44..2ba6b4c 100644
--- a/drivers/input/touchscreen/touchwin.c
+++ b/drivers/input/touchscreen/touchwin.c
@@ -159,7 +159,7 @@ static int tw_connect(struct serio *serio, struct serio_driver *drv)
  * The serio driver structure.
  */
 
-static struct serio_device_id tw_serio_ids[] = {
+static const struct serio_device_id tw_serio_ids[] = {
 	{
 		.type	= SERIO_RS232,
 		.proto	= SERIO_TOUCHWIN,
-- 
2.7.4

[toc] | [prev] | [next] | [standalone]

#1713867 — [PATCH 21/30] Input: gunze: constify serio_device_id

FromArvind Yadav <arvind.yadav.cs@gmail.com>
Date2017-08-17 13:50 +0200
Subject[PATCH 21/30] Input: gunze: constify serio_device_id
Message-ID<ufrth-4hy-57@gated-at.bofh.it>
In reply to#1713842
serio_device_id are not supposed to change at runtime. All functions
working with serio_device_id provided by <linux/serio.h> work with
const serio_device_id. So mark the non-const structs as const.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
 drivers/input/touchscreen/gunze.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/input/touchscreen/gunze.c b/drivers/input/touchscreen/gunze.c
index e2ee626..4815869 100644
--- a/drivers/input/touchscreen/gunze.c
+++ b/drivers/input/touchscreen/gunze.c
@@ -162,7 +162,7 @@ static int gunze_connect(struct serio *serio, struct serio_driver *drv)
  * The serio driver structure.
  */
 
-static struct serio_device_id gunze_serio_ids[] = {
+static const struct serio_device_id gunze_serio_ids[] = {
 	{
 		.type	= SERIO_RS232,
 		.proto	= SERIO_GUNZE,
-- 
2.7.4

[toc] | [prev] | [next] | [standalone]

#1713868 — [PATCH 30/30] Input: wacom_w8001: constify serio_device_id

FromArvind Yadav <arvind.yadav.cs@gmail.com>
Date2017-08-17 13:50 +0200
Subject[PATCH 30/30] Input: wacom_w8001: constify serio_device_id
Message-ID<ufrth-4hy-51@gated-at.bofh.it>
In reply to#1713842
serio_device_id are not supposed to change at runtime. All functions
working with serio_device_id provided by <linux/serio.h> work with
const serio_device_id. So mark the non-const structs as const.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
 drivers/input/touchscreen/wacom_w8001.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/input/touchscreen/wacom_w8001.c b/drivers/input/touchscreen/wacom_w8001.c
index 85e9572..3715d1e 100644
--- a/drivers/input/touchscreen/wacom_w8001.c
+++ b/drivers/input/touchscreen/wacom_w8001.c
@@ -681,7 +681,7 @@ static int w8001_connect(struct serio *serio, struct serio_driver *drv)
 	return err;
 }
 
-static struct serio_device_id w8001_serio_ids[] = {
+static const struct serio_device_id w8001_serio_ids[] = {
 	{
 		.type	= SERIO_RS232,
 		.proto	= SERIO_W8001,
-- 
2.7.4

[toc] | [prev] | [next] | [standalone]

#1713869 — [PATCH 05/30] Input: stinger: constify serio_device_id

FromArvind Yadav <arvind.yadav.cs@gmail.com>
Date2017-08-17 13:50 +0200
Subject[PATCH 05/30] Input: stinger: constify serio_device_id
Message-ID<ufrth-4hy-55@gated-at.bofh.it>
In reply to#1713842
serio_device_id are not supposed to change at runtime. All functions
working with serio_device_id provided by <linux/serio.h> work with
const serio_device_id. So mark the non-const structs as const.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
 drivers/input/joystick/stinger.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/input/joystick/stinger.c b/drivers/input/joystick/stinger.c
index 099c6d7..cb10e7b 100644
--- a/drivers/input/joystick/stinger.c
+++ b/drivers/input/joystick/stinger.c
@@ -184,7 +184,7 @@ static int stinger_connect(struct serio *serio, struct serio_driver *drv)
  * The serio driver structure.
  */
 
-static struct serio_device_id stinger_serio_ids[] = {
+static const struct serio_device_id stinger_serio_ids[] = {
 	{
 		.type	= SERIO_RS232,
 		.proto	= SERIO_STINGER,
-- 
2.7.4

[toc] | [prev] | [next] | [standalone]

#1713870 — [PATCH 23/30] Input: inexio: constify serio_device_id

FromArvind Yadav <arvind.yadav.cs@gmail.com>
Date2017-08-17 13:50 +0200
Subject[PATCH 23/30] Input: inexio: constify serio_device_id
Message-ID<ufrth-4hy-59@gated-at.bofh.it>
In reply to#1713842
serio_device_id are not supposed to change at runtime. All functions
working with serio_device_id provided by <linux/serio.h> work with
const serio_device_id. So mark the non-const structs as const.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
 drivers/input/touchscreen/inexio.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/input/touchscreen/inexio.c b/drivers/input/touchscreen/inexio.c
index adb80b6..b9bc562 100644
--- a/drivers/input/touchscreen/inexio.c
+++ b/drivers/input/touchscreen/inexio.c
@@ -165,7 +165,7 @@ static int inexio_connect(struct serio *serio, struct serio_driver *drv)
  * The serio driver structure.
  */
 
-static struct serio_device_id inexio_serio_ids[] = {
+static const struct serio_device_id inexio_serio_ids[] = {
 	{
 		.type	= SERIO_RS232,
 		.proto	= SERIO_INEXIO,
-- 
2.7.4

[toc] | [prev] | [next] | [standalone]

#1713871 — [PATCH 29/30] Input: tsc40: constify serio_device_id

FromArvind Yadav <arvind.yadav.cs@gmail.com>
Date2017-08-17 13:50 +0200
Subject[PATCH 29/30] Input: tsc40: constify serio_device_id
Message-ID<ufrti-4hy-61@gated-at.bofh.it>
In reply to#1713842
serio_device_id are not supposed to change at runtime. All functions
working with serio_device_id provided by <linux/serio.h> work with
const serio_device_id. So mark the non-const structs as const.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
 drivers/input/touchscreen/tsc40.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/input/touchscreen/tsc40.c b/drivers/input/touchscreen/tsc40.c
index 2968787..d4ae4ba 100644
--- a/drivers/input/touchscreen/tsc40.c
+++ b/drivers/input/touchscreen/tsc40.c
@@ -141,7 +141,7 @@ static void tsc_disconnect(struct serio *serio)
 	serio_set_drvdata(serio, NULL);
 }
 
-static struct serio_device_id tsc_serio_ids[] = {
+static const struct serio_device_id tsc_serio_ids[] = {
 	{
 		.type   = SERIO_RS232,
 		.proto  = SERIO_TSC40,
-- 
2.7.4

[toc] | [prev] | [next] | [standalone]

#1713872 — [PATCH 19/30] Input: elo: constify serio_device_id

FromArvind Yadav <arvind.yadav.cs@gmail.com>
Date2017-08-17 13:50 +0200
Subject[PATCH 19/30] Input: elo: constify serio_device_id
Message-ID<ufrti-4hy-63@gated-at.bofh.it>
In reply to#1713842
serio_device_id are not supposed to change at runtime. All functions
working with serio_device_id provided by <linux/serio.h> work with
const serio_device_id. So mark the non-const structs as const.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
 drivers/input/touchscreen/elo.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/input/touchscreen/elo.c b/drivers/input/touchscreen/elo.c
index 8051a4b..83433e8 100644
--- a/drivers/input/touchscreen/elo.c
+++ b/drivers/input/touchscreen/elo.c
@@ -381,7 +381,7 @@ static int elo_connect(struct serio *serio, struct serio_driver *drv)
  * The serio driver structure.
  */
 
-static struct serio_device_id elo_serio_ids[] = {
+static const struct serio_device_id elo_serio_ids[] = {
 	{
 		.type	= SERIO_RS232,
 		.proto	= SERIO_ELO,
-- 
2.7.4

[toc] | [prev] | [next] | [standalone]

#1715959

FromDmitry Torokhov <dmitry.torokhov@gmail.com>
Date2017-08-20 18:40 +0200
Message-ID<ugBqx-Uw-9@gated-at.bofh.it>
In reply to#1713842
On Thu, Aug 17, 2017 at 05:08:01PM +0530, Arvind Yadav wrote:
> serio_device_id are not supposed to change at runtime. All functions
> working with serio_device_id provided by <linux/serio.h> work with
> const serio_device_id. So mark the non-const structs as const.

Applied the lot, thank you.

> 
> Arvind Yadav (30):
>   [PATCH 01/30] Input: iforce: constify serio_device_id
>   [PATCH 02/30] Input: magellan: constify serio_device_id
>   [PATCH 03/30] Input: spaceball: constify serio_device_id
>   [PATCH 04/30] Input: spaceorb: constify serio_device_id
>   [PATCH 05/30] Input: stinger: constify serio_device_id
>   [PATCH 06/30] Input: twidjoy: constify serio_device_id
>   [PATCH 07/30] Input: warrior: constify serio_device_id
>   [PATCH 08/30] Input: zhenhua: constify serio_device_id
>   [PATCH 09/30] Input: iatkbd: constify serio_device_id
>   [PATCH 10/30] Input: hil_kbd: constify serio_device_id
>   [PATCH 11/30] Input: lkkbd: constify serio_device_id
>   [PATCH 12/30] Input: newtonkbd: constify serio_device_id
>   [PATCH 13/30] Input: stowaway: constify serio_device_id
>   [PATCH 14/30] Input: sunkbd: constify serio_device_id
>   [PATCH 15/30] Input: xtkbd: constify serio_device_id
>   [PATCH 16/30] Input: serio: constify serio_device_id
>   [PATCH 17/30] Input: wacom_serial4: constify serio_device_id
>   [PATCH 18/30] Input: dynapro: constify serio_device_id
>   [PATCH 19/30] Input: elo: constify serio_device_id
>   [PATCH 20/30] Input: fujitsu_ts: constify serio_device_id
>   [PATCH 21/30] Input: gunze: constify serio_device_id
>   [PATCH 22/30] Input: hampshire: constify serio_device_id
>   [PATCH 23/30] Input: inexio: constify serio_device_id
>   [PATCH 24/30] Input: mtouch: constify serio_device_id
>   [PATCH 25/30] Input: penmount: constify serio_device_id
>   [PATCH 26/30] Input: touchit213: constify serio_device_id
>   [PATCH 27/30] Input: touchright: constify serio_device_id
>   [PATCH 28/30] Input: touchwin: constify serio_device_id
>   [PATCH 29/30] Input: tsc40: constify serio_device_id
>   [PATCH 30/30] Input: wacom_w8001: constify serio_device_id
> 
>  drivers/input/joystick/iforce/iforce-serio.c | 2 +-
>  drivers/input/joystick/magellan.c            | 2 +-
>  drivers/input/joystick/spaceball.c           | 2 +-
>  drivers/input/joystick/spaceorb.c            | 2 +-
>  drivers/input/joystick/stinger.c             | 2 +-
>  drivers/input/joystick/twidjoy.c             | 2 +-
>  drivers/input/joystick/warrior.c             | 2 +-
>  drivers/input/joystick/zhenhua.c             | 2 +-
>  drivers/input/keyboard/atkbd.c               | 2 +-
>  drivers/input/keyboard/hil_kbd.c             | 2 +-
>  drivers/input/keyboard/lkkbd.c               | 2 +-
>  drivers/input/keyboard/newtonkbd.c           | 2 +-
>  drivers/input/keyboard/stowaway.c            | 2 +-
>  drivers/input/keyboard/sunkbd.c              | 2 +-
>  drivers/input/keyboard/xtkbd.c               | 2 +-
>  drivers/input/serio/serio_raw.c              | 2 +-
>  drivers/input/tablet/wacom_serial4.c         | 2 +-
>  drivers/input/touchscreen/dynapro.c          | 2 +-
>  drivers/input/touchscreen/elo.c              | 2 +-
>  drivers/input/touchscreen/fujitsu_ts.c       | 2 +-
>  drivers/input/touchscreen/gunze.c            | 2 +-
>  drivers/input/touchscreen/hampshire.c        | 2 +-
>  drivers/input/touchscreen/inexio.c           | 2 +-
>  drivers/input/touchscreen/mtouch.c           | 2 +-
>  drivers/input/touchscreen/penmount.c         | 2 +-
>  drivers/input/touchscreen/touchit213.c       | 2 +-
>  drivers/input/touchscreen/touchright.c       | 2 +-
>  drivers/input/touchscreen/touchwin.c         | 2 +-
>  drivers/input/touchscreen/tsc40.c            | 2 +-
>  drivers/input/touchscreen/wacom_w8001.c      | 2 +-
>  30 files changed, 30 insertions(+), 30 deletions(-)
> 
> -- 
> 2.7.4
> 

-- 
Dmitry

[toc] | [prev] | [standalone]

Page 2 of 2 — ← Prev page 1 [2]

Back to top | Article view | linux.kernel

csiph-web