Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1713694 > unrolled thread

Re: [RFC 2/5] i3c: Add core I3C infrastructure

Started byLinus Walleij <linus.walleij@linaro.org>
First post2017-08-17 11:10 +0200
Last post2017-08-17 11:30 +0200
Articles 2 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [RFC 2/5] i3c: Add core I3C infrastructure Linus Walleij <linus.walleij@linaro.org> - 2017-08-17 11:10 +0200
    Re: [RFC 2/5] i3c: Add core I3C infrastructure Boris Brezillon <boris.brezillon@free-electrons.com> - 2017-08-17 11:30 +0200

#1713694 — Re: [RFC 2/5] i3c: Add core I3C infrastructure

FromLinus Walleij <linus.walleij@linaro.org>
Date2017-08-17 11:10 +0200
SubjectRe: [RFC 2/5] i3c: Add core I3C infrastructure
Message-ID<ufoYr-2Kf-53@gated-at.bofh.it>
On Mon, Jul 31, 2017 at 6:24 PM, Boris Brezillon
<boris.brezillon@free-electrons.com> wrote:

> This infrastructure is not complete yet and will be extended over
> time.

I noticed the lack of pm_* from the core.

This will be noticed very quickly since the means the problem seen
in e.g. commit 04f59143b571 and the wakeup IRQ business will make it
impossible to do power-efficient drivers until that is resolved.

It'd be nice to have it to PM right from the start, and the I2C core has
all the right infrastructure in place, so when this stabilize I'd say
atleast it'd be *nice* if the PM business was added in the same
kernel release that introduce this core infrastructure, even if it will
be a separate patch.

I.e. I consider that more of necessary bread and butter and less of
nice to have topping on the cake.

What I have seen that leaf vendors doing (i3c) device drivers do
otherwise is complain "it is broken" and then they start to hack
around it instead of helping out with the core. (I think you're
well aware of that phenomenon.)

Yours,
Linus Walleij

[toc] | [next] | [standalone]


#1713720

FromBoris Brezillon <boris.brezillon@free-electrons.com>
Date2017-08-17 11:30 +0200
Message-ID<ufphM-2RP-11@gated-at.bofh.it>
In reply to#1713694
Le Thu, 17 Aug 2017 11:03:10 +0200,
Linus Walleij <linus.walleij@linaro.org> a écrit :

> On Mon, Jul 31, 2017 at 6:24 PM, Boris Brezillon
> <boris.brezillon@free-electrons.com> wrote:
> 
> > This infrastructure is not complete yet and will be extended over
> > time.  
> 
> I noticed the lack of pm_* from the core.
> 
> This will be noticed very quickly since the means the problem seen
> in e.g. commit 04f59143b571 and the wakeup IRQ business will make it
> impossible to do power-efficient drivers until that is resolved.
> 
> It'd be nice to have it to PM right from the start, and the I2C core has
> all the right infrastructure in place, so when this stabilize I'd say
> atleast it'd be *nice* if the PM business was added in the same
> kernel release that introduce this core infrastructure, even if it will
> be a separate patch.
> 
> I.e. I consider that more of necessary bread and butter and less of
> nice to have topping on the cake.
> 
> What I have seen that leaf vendors doing (i3c) device drivers do
> otherwise is complain "it is broken" and then they start to hack
> around it instead of helping out with the core. (I think you're
> well aware of that phenomenon.)

Noted. I'll try to provide core infrastructure for PM in my v2, but it's
kind of hard to design something when you don't have real devices. I
guess I can mimic I2C for now and make it evolve based on users needs.

Regards,

Boris

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web