Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1713777 > unrolled thread
| Started by | Arvind Yadav <arvind.yadav.cs@gmail.com> |
|---|---|
| First post | 2017-08-17 12:20 +0200 |
| Last post | 2017-08-17 12:50 +0200 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH 00/15] constify pnp_device_id and pnp_card_device_id Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-17 12:20 +0200
[PATCH 04/15] ALSA: ad1816a: constify pnp_card_device_id Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-17 12:20 +0200
Re: [PATCH 00/15] constify pnp_device_id and pnp_card_device_id Takashi Iwai <tiwai@suse.de> - 2017-08-17 12:50 +0200
| From | Arvind Yadav <arvind.yadav.cs@gmail.com> |
|---|---|
| Date | 2017-08-17 12:20 +0200 |
| Subject | [PATCH 00/15] constify pnp_device_id and pnp_card_device_id |
| Message-ID | <ufpUt-3mI-3@gated-at.bofh.it> |
*_device_id are not supposed to change at runtime. All functions working with *_device_id provided by <linux/pnp.h> work with const *_device_id. So mark the non-const structs as const. Arvind Yadav (15): [PATCH 01/15] ALSA: drivers: mpu401: constify pnp_device_id [PATCH 02/15] ALSA: es18xx: constify pnp_device_id and pnp_card_device_id [PATCH 03/15] ALSA: opl3sa2: constify pnp_device_id and pnp_card_device_id [PATCH 04/15] ALSA: ad1816a: constify pnp_card_device_id [PATCH 05/15] ALSA: als100: constify pnp_card_device_id [PATCH 06/15] ALSA: azt2320: constify pnp_card_device_id [PATCH 07/15] ALSA: cmi8330: constify pnp_card_device_id [PATCH 08/15] ALSA: cs4236: constify pnp_card_device_id [PATCH 09/15] ALSA: es1688: constify pnp_card_device_id [PATCH 10/15] ALSA: gus: constify pnp_card_device_id [PATCH 11/15] ALSA: msnd: constify pnp_card_device_id [PATCH 12/15] ALSA: opti9xx: constify pnp_card_device_id [PATCH 13/15] ALSA: sb16: constify pnp_card_device_id [PATCH 14/15] ALSA: sscape: constify pnp_card_device_id [PATCH 15/15] ALSA: wavefront: constify pnp_card_device_id sound/drivers/mpu401/mpu401.c | 2 +- sound/isa/ad1816a/ad1816a.c | 2 +- sound/isa/als100.c | 2 +- sound/isa/azt2320.c | 2 +- sound/isa/cmi8330.c | 2 +- sound/isa/cs423x/cs4236.c | 2 +- sound/isa/es1688/es1688.c | 2 +- sound/isa/es18xx.c | 4 ++-- sound/isa/gus/interwave.c | 2 +- sound/isa/msnd/msnd_pinnacle.c | 2 +- sound/isa/opl3sa2.c | 4 ++-- sound/isa/opti9xx/miro.c | 2 +- sound/isa/opti9xx/opti92x-ad1848.c | 2 +- sound/isa/sb/sb16.c | 2 +- sound/isa/sscape.c | 2 +- sound/isa/wavefront/wavefront.c | 2 +- 16 files changed, 18 insertions(+), 18 deletions(-) -- 2.7.4
[toc] | [next] | [standalone]
| From | Arvind Yadav <arvind.yadav.cs@gmail.com> |
|---|---|
| Date | 2017-08-17 12:20 +0200 |
| Subject | [PATCH 04/15] ALSA: ad1816a: constify pnp_card_device_id |
| Message-ID | <ufq4b-3s3-39@gated-at.bofh.it> |
| In reply to | #1713777 |
pnp_card_device_id are not supposed to change at runtime. All functions
working with pnp_card_device_id provided by <linux/pnp.h> work with
const pnp_card_device_id. So mark the non-const structs as const.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
sound/isa/ad1816a/ad1816a.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/isa/ad1816a/ad1816a.c b/sound/isa/ad1816a/ad1816a.c
index 7692265..4be6c12 100644
--- a/sound/isa/ad1816a/ad1816a.c
+++ b/sound/isa/ad1816a/ad1816a.c
@@ -63,7 +63,7 @@ MODULE_PARM_DESC(enable, "Enable ad1816a based soundcard.");
module_param_array(clockfreq, int, NULL, 0444);
MODULE_PARM_DESC(clockfreq, "Clock frequency for ad1816a driver (default = 0).");
-static struct pnp_card_device_id snd_ad1816a_pnpids[] = {
+static const struct pnp_card_device_id snd_ad1816a_pnpids[] = {
/* Analog Devices AD1815 */
{ .id = "ADS7150", .devs = { { .id = "ADS7150" }, { .id = "ADS7151" } } },
/* Analog Device AD1816? */
--
2.7.4
[toc] | [prev] | [next] | [standalone]
| From | Takashi Iwai <tiwai@suse.de> |
|---|---|
| Date | 2017-08-17 12:50 +0200 |
| Message-ID | <ufqxd-3DI-31@gated-at.bofh.it> |
| In reply to | #1713777 |
On Thu, 17 Aug 2017 12:06:15 +0200, Arvind Yadav wrote: > > *_device_id are not supposed to change at runtime. All functions > working with *_device_id provided by <linux/pnp.h> work with > const *_device_id. So mark the non-const structs as const. > > Arvind Yadav (15): > [PATCH 01/15] ALSA: drivers: mpu401: constify pnp_device_id > [PATCH 02/15] ALSA: es18xx: constify pnp_device_id and pnp_card_device_id > [PATCH 03/15] ALSA: opl3sa2: constify pnp_device_id and pnp_card_device_id > [PATCH 04/15] ALSA: ad1816a: constify pnp_card_device_id > [PATCH 05/15] ALSA: als100: constify pnp_card_device_id > [PATCH 06/15] ALSA: azt2320: constify pnp_card_device_id > [PATCH 07/15] ALSA: cmi8330: constify pnp_card_device_id > [PATCH 08/15] ALSA: cs4236: constify pnp_card_device_id > [PATCH 09/15] ALSA: es1688: constify pnp_card_device_id > [PATCH 10/15] ALSA: gus: constify pnp_card_device_id > [PATCH 11/15] ALSA: msnd: constify pnp_card_device_id > [PATCH 12/15] ALSA: opti9xx: constify pnp_card_device_id > [PATCH 13/15] ALSA: sb16: constify pnp_card_device_id > [PATCH 14/15] ALSA: sscape: constify pnp_card_device_id > [PATCH 15/15] ALSA: wavefront: constify pnp_card_device_id Applied all patches now. Thanks. Takashi
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web